From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 8E7231C00 for ; Fri, 8 Dec 2017 15:57:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Dec 2017 06:57:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,378,1508828400"; d="scan'208";a="10794967" Received: from awalabdu-mobl.ger.corp.intel.com (HELO [163.33.228.212]) ([163.33.228.212]) by fmsmga004.fm.intel.com with ESMTP; 08 Dec 2017 06:57:08 -0800 From: Mohammad Abdul Awal To: Ferruh Yigit Cc: Remy Horton , Declan Doherty , dev@dpdk.org References: <1510929733-7225-1-git-send-email-mohammad.abdul.awal@intel.com> <1510929733-7225-2-git-send-email-mohammad.abdul.awal@intel.com> Message-ID: Date: Fri, 8 Dec 2017 14:57:07 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/6] lib/representor: port representor library to manage broker infrastructure and representor PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 14:57:11 -0000 On 17/11/2017 23:03, Ferruh Yigit wrote: > On 11/17/2017 6:42 AM, Mohammad Abdul Awal wrote: >> diff --git a/lib/librte_representor/rte_port_representor_version.map b/lib/librte_representor/rte_port_representor_version.map >> new file mode 100644 >> index 0000000..09ed768 >> --- /dev/null >> +++ b/lib/librte_representor/rte_port_representor_version.map >> @@ -0,0 +1,12 @@ >> +DPDK_18.02 {2 { >> + global: >> + >> + rte_representor_broker_find; >> + rte_representor_broker_init; >> + rte_representor_broker_uninit; >> + rte_representor_port_get_vport_id; >> + rte_representor_port_register; >> + rte_representor_port_unregister; > Is any of these APIs intended to be used by application? > From rest of the patch it looks like these are used by PMDs, if so why creating > a new library? These API's are to be used by PMDs only. We will remove them from here. Thanks, Awal. > >> + >> + local: *; >> +};