From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A506FA10DA for ; Thu, 1 Aug 2019 20:24:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D717C1C1D6; Thu, 1 Aug 2019 20:24:33 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by dpdk.org (Postfix) with ESMTP id 7D2111C1CB for ; Thu, 1 Aug 2019 20:24:32 +0200 (CEST) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x71ICijo144674; Thu, 1 Aug 2019 14:24:31 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0b-001b2d01.pphosted.com with ESMTP id 2u44742p6u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Aug 2019 14:24:31 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x71IA2Kh019539; Thu, 1 Aug 2019 18:24:29 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma04dal.us.ibm.com with ESMTP id 2u0e877nuc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Aug 2019 18:24:29 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x71IOSqa44564772 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 1 Aug 2019 18:24:28 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 70B42C6059; Thu, 1 Aug 2019 18:24:28 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 268C6C605A; Thu, 1 Aug 2019 18:24:28 +0000 (GMT) Received: from davids-mbp.usor.ibm.com (unknown [9.70.85.74]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 1 Aug 2019 18:24:27 +0000 (GMT) To: Slava Ovsiienko Cc: "dev@dpdk.org" References: <1564612871-162495-1-git-send-email-drc@linux.vnet.ibm.com> From: David Christensen Message-ID: Date: Thu, 1 Aug 2019 11:24:27 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-08-01_08:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908010190 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: txq_inline_min not set for ConnectX-5 adapters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Yes, thank you for the patch, acked. > > The "txq_inline_min" value was not set for ConnectX-5 to 0 as default. > At the TX queue setup time the "txq_inline_min" is checked against MLX5_ARG_UNSET > and default value 0 is set: > > txq_set_params() > ... > inlen_mode = (config->txq_inline_min == MLX5_ARG_UNSET) ? > 0 : (unsigned int)config->txq_inline_min; > > So, there should be no negative backwards. Did you observe any? The gdb session below shows how the value is unchanged after passing through mlx5_set_min_inline on my system without the change. sudo LD_LIBRARY_PATH=/home/davec/src/dpdk/build/lib gdb --args /home/davec/src/dpdk/build/app/testpmd -w 0000:01:00.0 -w 0000:01:00.1 -l 4,8-79 -n 4 --iova-mode=pa -- --rxq=4 --rxd=1024 --txq=4 --txd=4096 --nb-cores=8 -i -a --numa --forward-mode=rxonly GNU gdb (GDB) Red Hat Enterprise Linux 7.6.1-114.el7 Copyright (C) 2013 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "ppc64le-redhat-linux-gnu". For bug reporting instructions, please see: ... Reading symbols from /home/davec/src/dpdk/build/app/testpmd...done. (gdb) b mlx5_set_min_inline Breakpoint 1 at 0x10579da0: file /home/davec/src/dpdk/drivers/net/mlx5/mlx5.c, line 1251. (gdb) start Temporary breakpoint 2 at 0x100a9b38: file /home/davec/src/dpdk/app/test-pmd/testpmd.c, line 3234. Starting program: /home/davec/src/dpdk/build/app/testpmd -w 0000:01:00.0 -w 0000:01:00.1 -l 4,8-79 -n 4 --iova-mode=pa -- --rxq=4 --rxd=1024 --txq=4 --txd=4096 --nb-cores=8 -i -a --numa --forward-mode=rxonly warning: Could not load shared library symbols for linux-vdso64.so.1. Do you need "set solib-search-path" or "set sysroot"? warning: Unable to find libthread_db matching inferior's thread library, thread debugging will not be available. Temporary breakpoint 2, main (argc=20, argv=0x7fffffffef68) at /home/davec/src/dpdk/app/test-pmd/testpmd.c:3234 3234 signal(SIGINT, signal_handler); Missing separate debuginfos, use: debuginfo-install advance-toolchain-at12.0-runtime-12.0-1.ppc64le libibverbs-17.2-3.el7.ppc64le (gdb) c Continuing. EAL: Detected 160 lcore(s) EAL: Detected 2 NUMA nodes EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IOVA mode 'PA' EAL: No available hugepages reported in hugepages-2048kB EAL: Probing VFIO support... EAL: PCI device 0000:01:00.0 on NUMA socket 0 EAL: probe driver: 15b3:1019 net_mlx5 net_mlx5: mlx5.c:1684: mlx5_dev_spawn(): MPLS over GRE/UDP tunnel offloading disabled due to old OFED/rdma-core version or firmware configuration Breakpoint 1, mlx5_set_min_inline (spawn=0x7fffffffe500, config=0x7fffffffe4a0) at /home/davec/src/dpdk/drivers/net/mlx5/mlx5.c:1251 1251 if (config->txq_inline_min != MLX5_ARG_UNSET) { (gdb) p config->txq_inline_min $1 = -1 (gdb) n 1268 if (config->hca_attr.eth_net_offloads) { (gdb) n 1323 switch (spawn->pci_dev->id.device_id) { (gdb) p/x spawn->pci_dev->id.vendor_id $2 = 0x15b3 (gdb) p/x spawn->pci_dev->id.device_id $3 = 0x1019 (gdb) n 1343 config->hw_vlan_insert = 0; (gdb) n 1344 config->txq_inline_min = MLX5_INLINE_HSIZE_NONE; (gdb) tbreak +1 Temporary breakpoint 3 at 0x1057a0f0: file /home/davec/src/dpdk/drivers/net/mlx5/mlx5.c, line 1345. (gdb) jump +1 Continuing at 0x1057a0f0. Temporary breakpoint 3, mlx5_set_min_inline (spawn=0x7fffffffe500, config=0x7fffffffe4a0) at /home/davec/src/dpdk/drivers/net/mlx5/mlx5.c:1345 1345 break; (gdb) n 1351 DRV_LOG(DEBUG, "min tx inline configured: %d", config->txq_inline_min); (gdb) p config->txq_inline_min $4 = -1 (gdb)