From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 22F801B62F for ; Wed, 4 Oct 2017 13:28:42 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2017 04:28:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,477,1500966000"; d="scan'208";a="158708494" Received: from nikhilr-mobl.amr.corp.intel.com (HELO [10.106.138.15]) ([10.106.138.15]) by fmsmga005.fm.intel.com with ESMTP; 04 Oct 2017 04:28:39 -0700 To: Jerin Jacob Cc: bruce.richardson@intel.com, gage.eads@intel.com, dev@dpdk.org, thomas@monjalon.net, harry.van.haaren@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, narender.vangati@intel.com, erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com, santosh.shukla@caviumnetworks.com References: <1506028634-22998-1-git-send-email-nikhil.rao@intel.com> <1506028634-22998-5-git-send-email-nikhil.rao@intel.com> <20170922121225.GA22639@jerin> <3e1ca03f-5f83-5fe6-c96e-c3bda149823a@intel.com> <20171002103125.GA10407@jerin> From: "Rao, Nikhil" Message-ID: Date: Wed, 4 Oct 2017 16:58:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171002103125.GA10407@jerin> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 4/4] eventdev: Add tests for event eth Rx adapter APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Oct 2017 11:28:43 -0000 On 10/2/2017 4:01 PM, Jerin Jacob wrote: > -----Original Message----- >> Date: Sun, 24 Sep 2017 23:54:38 +0530 >> From: "Rao, Nikhil" >> To: Jerin Jacob >> CC: bruce.richardson@intel.com, gage.eads@intel.com, dev@dpdk.org, >> thomas@monjalon.net, harry.van.haaren@intel.com, hemant.agrawal@nxp.com, >> nipun.gupta@nxp.com, narender.vangati@intel.com, >> erik.g.carrillo@intel.com, abhinandan.gujjar@intel.com, >> santosh.shukla@caviumnetworks.com >> Subject: Re: [PATCH v4 4/4] eventdev: Add tests for event eth Rx adapter >> APIs >> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 >> Thunderbird/52.3.0 >> >> On 9/22/2017 5:42 PM, Jerin Jacob wrote: >>> -----Original Message----- >>>> Date: Fri, 22 Sep 2017 02:47:14 +0530 >>>> From: Nikhil Rao >>>> To: jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com >>>> CC: gage.eads@intel.com, dev@dpdk.org, thomas@monjalon.net, >>>> harry.van.haaren@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, >>>> narender.vangati@intel.com, erik.g.carrillo@intel.com, >>>> abhinandan.gujjar@intel.com, santosh.shukla@caviumnetworks.com >>>> Subject: [PATCH v4 4/4] eventdev: Add tests for event eth Rx adapter APIs >>>> X-Mailer: git-send-email 2.7.4 >>>> >>>> Add unit tests for rte_event_eth_rx_adapter_xxx() APIs >>> >> >> >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> +#include >>>> + >>>> +#include >>>> + >>>> +#include "test.h" >>>> + >>>> +/* i40e limits max to 64 */ >>> >>> This comment could be removed. >>> >> OK, I am documenting why the code doesn't just use dev_info.max_rx_queues, >> won't the comment be useful to retain ? > > OK. If dev_info.max_rx_queues for i40e is not 64 as expected then we > could the fix the i40e driver as well. This change was added in c9eb97fb9212a38, will check with i40e PMD maintainer (this is a holiday week in PRC though), a quick check showed that it is possible to allocate dev_info.max_rx_queues - dev_info.vmdq_queue_num Rx queues I will re post with the comment removed for now and post a patch later. Nikhil