From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: Yangchao Zhou <zhouyates@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] lpm: skip table entries update if rules found
Date: Fri, 17 Apr 2020 14:01:57 +0000 [thread overview]
Message-ID: <f6217717b0414e74881dd6305a261c4f@intel.com> (raw)
In-Reply-To: <20200417134830.13600-1-zhouyates@gmail.com>
Hi Zhou,
NACK.
This patch makes lpm inconsistent.
From the programmers guide
"If a rule with the same prefix is already present in the table, the next hop of the rule is updated."
So, here in case of presence of a route, next hop will be updated only in rules_table which is helper data struct, but won't be updated in lpm data plane struct.
-----Original Message-----
From: Yangchao Zhou <zhouyates@gmail.com>
Sent: Friday, April 17, 2020 2:49 PM
To: dev@dpdk.org
Cc: Richardson, Bruce <bruce.richardson@intel.com>; Medvedkin, Vladimir <vladimir.medvedkin@intel.com>
Subject: [PATCH] lpm: skip table entries update if rules found
Table entries do not need to be updated if the same rules can be found.
Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
---
lib/librte_lpm/rte_lpm.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c index 268756419..ee44fc4e5 100644
--- a/lib/librte_lpm/rte_lpm.c
+++ b/lib/librte_lpm/rte_lpm.c
@@ -287,7 +287,7 @@ rule_add(struct rte_lpm *lpm, uint32_t ip_masked, uint8_t depth,
if (lpm->rules_tbl[rule_index].ip == ip_masked) {
lpm->rules_tbl[rule_index].next_hop = next_hop;
- return rule_index;
+ return -EEXIST;
}
}
@@ -674,6 +674,10 @@ rte_lpm_add(struct rte_lpm *lpm, uint32_t ip, uint8_t depth,
/* Add the rule to the rule table. */
rule_index = rule_add(lpm, ip_masked, depth, next_hop);
+ /* Skip table entries update if rule is found in rule table */
+ if (rule_index == -EEXIST)
+ return 0;
+
/* If the is no space available for new rule return error. */
if (rule_index < 0) {
return rule_index;
--
2.17.1
next prev parent reply other threads:[~2020-04-17 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 13:48 Yangchao Zhou
2020-04-17 14:01 ` Medvedkin, Vladimir [this message]
[not found] ` <CABLiTuxTNQYYSCwWRuqqSZy+0JhBqjcE2v5ha+OqWk+YH42+TA@mail.gmail.com>
2020-04-17 15:07 ` Yangchao Zhou
2020-04-17 15:09 ` [dpdk-dev] [PATCH v2] " Yangchao Zhou
2020-04-17 17:26 ` [dpdk-dev] [PATCH v3] " Yangchao Zhou
2020-04-20 2:48 ` [dpdk-dev] [PATCH v4] " Yangchao Zhou
2020-04-21 15:44 ` Medvedkin, Vladimir
2020-04-24 17:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6217717b0414e74881dd6305a261c4f@intel.com \
--to=vladimir.medvedkin@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=zhouyates@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).