From: Ferruh Yigit <ferruh.yigit@intel.com> To: Kumara Parameshwaran <kumaraparamesh92@gmail.com>, <keith.wiles@intel.com> Cc: <dev@dpdk.org>, Kumara Parameshwaran <kparameshwar@vmware.com>, "Thomas Monjalon" <thomas@monjalon.net>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, David Marchand <david.marchand@redhat.com> Subject: Re: [PATCH] net/tap: Bug fix to populate fds in secondary process Date: Mon, 17 Jan 2022 18:28:04 +0000 Message-ID: <f63698fc-21eb-64b0-94b7-3e605ea725cd@intel.com> (raw) In-Reply-To: <20211126041515.96259-1-kumaraparamesh92@gmail.com> On 11/26/2021 4:15 AM, Kumara Parameshwaran wrote: > From: Kumara Parameshwaran <kparameshwar@vmware.com> > > When a tap device is hotplugged to primary process which in turn > adds the device to all secondary process, the secondary process > does a tap_mp_attach_queues, but the fds are not populated in > the primary during the probe they are populated during the queue_setup, > added a fix to sync the queues during rte_eth_dev_start > > Signed-off-by: Kumara Parameshwaran <kparameshwar@vmware.com> <...> > > +static int > +tap_mp_req_start_rxtx(const struct rte_mp_msg *request, __rte_unused const void *peer) > +{ > + struct rte_eth_dev *dev; > + int ret; > + uint16_t port_id; > + const struct ipc_queues *request_param = > + (const struct ipc_queues *)request->param; > + int fd_iterator; > + int queue; > + struct pmd_process_private *process_private; > + > + ret = rte_eth_dev_get_port_by_name(request_param->port_name, &port_id); > + if (ret) { > + TAP_LOG(ERR, "Failed to get port id for %s", > + request_param->port_name); > + return -1; > + } > + dev = &rte_eth_devices[port_id]; Since this is not really related with your patch, I want to have a separate thread for it. It is not good to access the 'rte_eth_devices' global variable directly from a driver, that is error prone. Btw, what 'peer' supposed to contain? It can be solved by adding an internal API, only for drivers to get eth_dev from the name, like: 'rte_eth_dev_get_by_name()'. This way a few other usage can be converted to this API. @Thomas and @Andrew what do you think about the new API proposal?
next prev parent reply other threads:[~2022-01-17 18:28 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-26 4:15 Kumara Parameshwaran 2022-01-17 18:22 ` Ferruh Yigit 2022-01-18 4:39 ` Kumara Parameshwaran 2022-01-18 9:10 ` Ferruh Yigit 2022-01-18 10:52 ` kumaraparameshwaran rathinavel 2022-01-18 12:14 ` Ferruh Yigit 2022-01-17 18:28 ` Ferruh Yigit [this message] 2022-01-17 18:33 ` Thomas Monjalon 2022-01-18 9:47 ` Ferruh Yigit 2022-01-18 11:21 ` kumaraparameshwaran rathinavel 2022-01-18 12:12 ` Ferruh Yigit 2022-01-18 12:31 ` Thomas Monjalon 2022-01-17 22:16 ` Stephen Hemminger 2022-01-18 5:22 ` Kumara Parameshwaran 2022-01-18 16:21 ` Stephen Hemminger 2022-01-19 4:33 ` kumaraparameshwaran rathinavel 2022-01-19 4:51 ` Stephen Hemminger -- strict thread matches above, loose matches on Subject: below -- 2022-01-21 4:29 Kumara Parameshwaran 2022-01-24 9:47 ` Ferruh Yigit 2022-01-20 13:38 Kumara Parameshwaran 2022-01-20 13:26 Kumara Parameshwaran 2022-01-20 11:12 Kumara Parameshwaran 2022-01-20 15:49 ` Stephen Hemminger 2022-01-24 9:32 ` Ferruh Yigit 2021-11-25 12:25 Kumara Parameshwaran 2021-11-25 12:23 Kumara Parameshwaran 2021-11-25 12:04 Kumara Parameshwaran
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f63698fc-21eb-64b0-94b7-3e605ea725cd@intel.com \ --to=ferruh.yigit@intel.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=keith.wiles@intel.com \ --cc=kparameshwar@vmware.com \ --cc=kumaraparamesh92@gmail.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git