From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <akhil.goyal@nxp.com>
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
(mail-eopbgr40079.outbound.protection.outlook.com [40.107.4.79])
by dpdk.org (Postfix) with ESMTP id 5BE155B36
for <dev@dpdk.org>; Wed, 4 Jul 2018 14:04:51 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=s1Fsez62HPpaxvX149xzhjTXAGWNkQVZL+p/VxZ3hyc=;
b=V39U03WCZZxhRqkDYFCnhd/iJbNjH+pYki4UtuiTBXv44jcdi1tSu00zqF2Kf03FtLxPTFSEKeGvysRhdicLUcwdVxUxZcXpu95mCxhwahkgwPDiTG/1tHixjeb2X8jgp5RIa3BDZBtc7xwSmqcvMdNTgKmc0qFdT3q9MunH+9Y=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=akhil.goyal@nxp.com;
Received: from [10.232.134.144] (14.142.187.166) by
VI1PR04MB1391.eurprd04.prod.outlook.com (2a01:111:e400:5348::22) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.26; Wed, 4 Jul
2018 12:04:47 +0000
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>, declan.doherty@intel.com,
shally.verma@caviumnetworks.com, ravi1.kumar@amd.com,
jerin.jacob@caviumnetworks.com, roy.fan.zhang@intel.com,
fiona.trahe@intel.com, tdu@semihalf.com, jianjay.zhou@huawei.com
Cc: dev@dpdk.org
References: <20180608220234.10170-1-pablo.de.lara.guarch@intel.com>
<20180628005304.26544-1-pablo.de.lara.guarch@intel.com>
<20180628005304.26544-6-pablo.de.lara.guarch@intel.com>
From: Akhil Goyal <akhil.goyal@nxp.com>
Message-ID: <f6399581-593a-1772-c4c9-cedfe20ddbee@nxp.com>
Date: Wed, 4 Jul 2018 17:34:30 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180628005304.26544-6-pablo.de.lara.guarch@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Originating-IP: [14.142.187.166]
X-ClientProxiedBy: BM1PR01CA0118.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::34)
To VI1PR04MB1391.eurprd04.prod.outlook.com
(2a01:111:e400:5348::22)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: c9e84053-7d23-42a3-a546-08d5e1a65768
X-MS-Office365-Filtering-HT: Tenant
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);
SRVR:VI1PR04MB1391;
X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1391;
3:vxFH4zU5mnWfubL778Ej6o1CNps+9LW1evJMB4m3lZHX07TdJSXHlOcS75ROeRfMXlFyctMYBn/WyBMMatb+gy6SFwT12ebSGa8YiJl6YKetfmiq2fKHNnFYs1IGj9Nb2RiakCffIoxgWfhDMa43yl2ZuKysX2V4I9sb3z0Dr32PaIFIb1fkCW4nxFMDEmCs/TEpke4re0y8VkKYxxltQD6sOmCe+fy+QVCfZsxB0kFKN87pxuh6h4cw4iLBk4DW;
25:15XB/0XvYqDRhh/oZVDXvOmzfyY/W1uqF02f8zNQZwtImvKRpeOpTQHsW0/ReQo4B3z9AiwXlJfh2/owGTb1lwL/xAzlDcpwsVmNfLEvZTDlVeNQwdQykk6WQp1CQHXBYiQPHZf67r6DsxLmSIA6Ip9W6b5PXBiH9l387bUS7stPDS7VTrZoBmeuw0RxX6r2tixWbAEMOa68o3/9/ogi46uYUITYRw6W54jlG+ekOIubZWzN9OHsLwuviBkLl1dY9DrxjSPclo4XBMzCM4FsLwzt5gI5F+OONidTERU/Ehwg0i2vhJHorR3znmvBOFLvpgjftnnUlyvPX0CJajjYMA==;
31:Ywl5xqJJCjsw+rGn7N9X4cAqBfQgrZDgT/o2kLfK6ur3ss9n6+eKVUUZzZHY4WQkjEMrw97ITWN22ug1dxoQe6oRb2dHkeOl5+XRFsHiPiqg/qax0wnmEFDryHARK32vm1qPGgYJTO+xu2F1toq5HpdCl2TNT+N45/vmFAERoWDer1TTd+k52KphxekDEtCxzGa9vvnPzqxfsI/62hNCF+yR2TFie9dCPX0dpLAGAss=
X-MS-TrafficTypeDiagnostic: VI1PR04MB1391:
X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1391;
20:SgpTKaBaxuPXaUt7dIOo9J9HetNwPFJfb70k5erqizLXSfLQrcRlolfNhOxqGIigLaEodWdr8QCNWvAOIvCi+VnFq0jb2ZrElaUXGMiU6BM91qwa3/Wd1oFo4GkV8cDuxV7YRE4nGcEcsbE8Z6YAJ5HE+BkKFWnDK/+UQAUwJyftST6AguVeO9TuzNmICOA/E1Q7x7boiq9v5FwWOaZTJPEke5s4WFoXAvjxykeCAzgZmkI1TaXOfEQJo2/Sj8hFoXGny7ETr6NxFvkbYbgtMXWZE45SYAiUYX040vAeXFhnKT4dlsH9Y9H4M4akIFVmif48G/z5lo0ZfJiS1Ud/vwKI1t3a3s8z6y6TdBiq7Vd3DR7lYOnzJmax0O+6IEDIlb2R1ltuLva4GXKblamK8jUOLJsYuIpGhJD40LBg9ynyO7v09N6240HnN1iREVi4LDDKhdsf+DWYJPun3ieboZEcuEjto92nfDI1e8afvBB06BCELmw1028ELzaHDSNi;
4:YPnyLMxL2pgoTRl0NexFdZJPKZJRNYX1LGyDnVld2URN8X5lsxdJ/RV4n7CNS6oemVLv5ruceuFwAaWwOSu7e7fMa3nTt4VBtK/4prQnjG4u+/VRlLwd0VdY8Or6E2xj3eq9dmVMCvMM0AslITM926Wm4oZab2wRHvLNI7JzP3aPkeiwox00sSp8lyNVNvio33NmIdjJ99CKGuwN5ZpiihElFxAef8Ye7i8TI2L0VFLJ8kGMfn8JAVI1PRlHl1GGSHa2gOTZK1MAmCXEIHquBlU27h4bT8OCJFE3COHGIrSmpq0gu9EJ4ArdRbmsL6mg
X-Microsoft-Antispam-PRVS: <VI1PR04MB13916FE1B167F5C75CB0817AE6410@VI1PR04MB1391.eurprd04.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(228905959029699);
X-MS-Exchange-SenderADCheck: 1
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(6072148)(201708071742011)(7699016);
SRVR:VI1PR04MB1391; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB1391;
X-Forefront-PRVS: 0723A02764
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(6049001)(396003)(136003)(366004)(376002)(39860400002)(346002)(199004)(189003)(3846002)(316002)(8936002)(7736002)(16576012)(81156014)(3260700006)(68736007)(25786009)(229853002)(6486002)(26005)(31696002)(5660300001)(5009440100003)(305945005)(6116002)(64126003)(81166006)(7416002)(2906002)(8676002)(105586002)(6666003)(230700001)(4326008)(106356001)(65826007)(65806001)(36756003)(97736004)(52116002)(86362001)(23676004)(76176011)(486006)(67846002)(65956001)(66066001)(47776003)(2486003)(478600001)(53936002)(31686004)(52146003)(53546011)(386003)(16526019)(575784001)(55236004)(44832011)(2616005)(77096007)(186003)(6246003)(956004)(50466002)(446003)(58126008)(11346002)(476003)(110426005);
DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB1391; H:[10.232.134.144]; FPR:;
SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
Received-SPF: None (protection.outlook.com: nxp.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA0TUIxMzkxOzIzOmlqSk1qcklTbFdwU1lqMDVGVUU3ZklVTmU4?=
=?utf-8?B?NDVlWVJ4ZFFJM0FOd1k3Y1JjYTZYbGh3MUVNWktCRTYvZCtWMGMvb3lTdk5F?=
=?utf-8?B?Snp3VnVmR3libkMwbFdOTDJmQnowMTJsOTNvM0J2RnBrbWJRdlpiSzA3TDAy?=
=?utf-8?B?UlZ4NGd3RGVpUVNOa1pGWU4wTVErY1RaTUlUK29KdzJuc3I1UlFqMWlpbEFl?=
=?utf-8?B?RjJuSjBxMHZrNXhnZnVPS0VsMFU2MmMybDVxRDJpU3ZrMzBVRkFGOExSQ1BL?=
=?utf-8?B?KzhkQjZ0VDZEL2M4b1hJT2p6UUJsSUVZd3FCUHRienJqVEd0dkx1UWxnbzB3?=
=?utf-8?B?anExTmhNaE41aGxIL2x3RmxWMnM5WXcrbXhuR3hpRHduU2ZPZHB4c0k1RzZk?=
=?utf-8?B?dGNySnZsand5ZUtXWHEzMnRBd2RwUWJBekV0MGQzSXEwNzBZWmFLaVI4V1Uw?=
=?utf-8?B?VkNQOTM0V2hPaW5vM3hVSTQ4bDIzZEVBSWF3dkh6NHpDdml0dnJXRmVnNUtS?=
=?utf-8?B?Z0pObWpyY1ZPZUh3Rk80QlhNM2VyZ0pkTmhYeWliZzFCK2VWK2Z0Vnl6NGJh?=
=?utf-8?B?VGtQMUdOMWxOT3N2NXhpbWdEWVFNVnovaXlwM0ZsNWptaTNjRzhDQU1lNVNz?=
=?utf-8?B?VWwrQkxMZTg5SXQ3UDNTN1hEMnF0MEZRRlk4aTUwZzdjTGxLWlBWeU94TUFN?=
=?utf-8?B?ODcrSWJ3ZE5BOGVRL1RFNUVBbDZraEJab1dDZ201N2dSaGNHSGRBOTAyTlhw?=
=?utf-8?B?cTVRdzN5ZnpwQUQ3cURWUExsZ21jOGNTZTFGS2ZQcXZNUUo2SFFMVWR0ajJq?=
=?utf-8?B?TFFUeHRhSG5KdWxhUUc2SmJqUGR6ZXhQS0VPekR2NnBaM0t5T1N4UnJUK0NH?=
=?utf-8?B?RHlmdVRlTzRoWU4ranErWjFaNHFXR3huS2xqaW5XTGtTaG8wL0JQWmN6bGNs?=
=?utf-8?B?cmJYS09nQ1YwOFdzTTNTUXVtZmpoQTlzUlJYRWprV2l0azhkK3lMZEZoWGVT?=
=?utf-8?B?aU5vRDBOSG10TExXakNreHFMZDFmdUZUL0Z3TG9aOVlnTjVEa2pZbVdhSU1t?=
=?utf-8?B?SzRLcnJJTWoxa3lULy9mM0dNZkpkUURoMDYyY2cxbzQxMmhJa3pQMGdXK04v?=
=?utf-8?B?czdqejZHL3FYcTdjd2hLa2wzZEZSeXRsQi93LzJqMUF3N29nNVptc3YvV3pi?=
=?utf-8?B?M3NnRDFjNlNZQmpyK1FPWkpMNTBzeG5MVTV1RzdveHlJRkhKaDFBWTk5NklI?=
=?utf-8?B?Z0JNZzJzVTNKb0RJeVBTWFR4UFdveTJ2MndnT0dRRXhrOGtiNnhDZnFGcWkv?=
=?utf-8?B?WW43VlV2Q1RrRVlxQ2hqaldMUUUzYk9HT1Q5MHBYWmtiNCtESUZWZXBpWVZG?=
=?utf-8?B?dG05a0FSVDVYaTEyL3FBMk9NUnpjdzE5VXJuemNuUHhKNURETnVoQWZjdEM5?=
=?utf-8?B?VmFRUzk3QTRDWUREMlFiOVdqUm1pajF4MVhXSklHbnJ0OUd5SkpYUGRuVnRB?=
=?utf-8?B?d3FOa0Jabldjc0tTSUd6ckgyVkR4VkdzczVJNjkvWFBYcG5DSE84WmpRVitI?=
=?utf-8?B?aElnT0poZnM0Mlp1VlIvUnBjVlkycjFkK0lGSWh3RjFiRnZTRFNGc1JzN1Y5?=
=?utf-8?B?cVRtZTZZR1FkWnhUUTlUZWd2WS9KK1d6bHdvenN2STEzV1hsa0RHK3QzYU93?=
=?utf-8?B?ZW5oMWIxYXY2UUsrOWdyK25rTURhNTNsaGYzY0drdm5lUUM2SjROR2VSVG1Y?=
=?utf-8?B?NmRnMHdsc1liS1ZLZ2VZdjB0UmtzTWpPeVNidTBsTXlvdm5FcVo2QWs1b3c4?=
=?utf-8?B?TC9ObTBzL3oweVFUZ2lPTVRSZDMvdkVrRnFlMENBVzg4bzNYSTRZdmg3aGVm?=
=?utf-8?B?ekt5WUczMVFNSk5UU24rVFdiUkZKMitiQzBHRVlLMTZKbU1uWklpRGwrRjFz?=
=?utf-8?B?SVZiSlRSN1FEYlJGT0VzdERQbmg1ODhGbnVZZ2pjR0tHbkswOEtYeDZDQUJv?=
=?utf-8?B?S3pTNkx6QXJDaFg4SkpkQnNqR1hhRlVFL0J5QStWT1g5d3BrNU1ZeU9qaUhR?=
=?utf-8?B?M3RzQjNMdzkvYkovelFzbkxSMi9PVzNXY1FJNlhSS3lIMkZScC8rd1dkZUdX?=
=?utf-8?Q?6r+U96fnPcU7a/JvrJLuur4=3D?=
X-Microsoft-Antispam-Message-Info: Uly7uX4VW+/LxE4+bKUCjTvV0JQ2reJseyxJ6JGm48T+6wx26obIMjnko843l35dJw+7AK+CkT1BwWe81zA1wcF/tZe7OLDNrHSyq6Yx5KuDLPtb+BgCc/njC/P+MAv1qGPLaQKA4mCMkvSc8o313fR0Jn/JS6A0USKmKEVncDe9JdpxXQESDaIlJB/RIVDde98932frUkU4sewUXgma9oL8rHHFw8n9mzbfoRa9FAyEwBqgpGMR+JBLH6yd4kgYRfReC1djFUKh7nuro4FG/6eTV4YOsVVLv0lVEFyoUzjhSsu8Y79+x0VCWkXfb31CGE4EkjLXrtAn8d8BQ7pFx+Q//lzvB7D1Btr7eGFM3jA=
X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1391;
6:RA1Yva2NRSb2v1pjbhVyiCik8d0h3Ea+by04RPpJZv+HvgR/KYxA9mAEquohNhG+NHVaNAP4aZKkITA9MC4RldpWKN5UPLTe4SAWpYjYPWJZMrk1V3riqDmndV5q3sGRDfu8yfZHg+YD/RtOBl/7MFCteCmm/P5SQ29tLrpgtXypJTVmjpwA8EDdpbWh3taI6dLwRtRNJceqW7S0Mo51NBQul3H38pY1O7QwPLPIe2bFTKD0lhEpW9l1zPoDWeXXNU+IjDcS9iDqei2mpHeP3uMuTAcc9LjypZ5jgBz6wtvrFjqcRjgxjQXqhaeeknVSh0X2pbaZvh8c/3SglvW2Ni8IgYN7YNGuKq8FAKvGCB8d8hpzFJU5fpxmiyh552nFLha6bdeASZsZtq/zzU/IR+z2ueyk/kbOtpkePZNA+0Z6vXvprSguBL9rp6Eq6BRRyc5op8vqixeIMkTXEpH/IQ==;
5:nCbhQqpua4zMZ41gFoiUjLMUgnJtMkfsVPkQnNDfSEXJKtlnChLFIM80vN4dYa/2KtAHu58HkaxzI5aroBYPJ0/vO2SJje69N9/QtsC5rYGbz2Z6ruuJLZFsLlGTj/Q5O0YBQDtXAOoYayKEPyln1/YalnBuGSt8/FLg/ewY4fo=;
24:ODika8FgGkFFZs/ZJIwvc/X1W3ol1s8oNe/RscdaTWUPZkWZ+nj7DeK+FevaEMYNrnZeencUUtBeDYh6+wSEIY9UdhirYCl3+5YxIoWlwf4=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1391;
7:hAeRVzPUmLZdGJylKQyo9w6RWzNDfr/xDiW+OW9lR/HQ4IstSGcuM/LghgROlhPy3ierRCfoH89ORFsEBe5ItM5i/6hhgir6w0kNOYLbkdRj25L9/hY0jaQPhAvmvHyuxTf/kJb6WQFIfCH0SeCMC0p0IIvCyL+N81gXPd76cTYYyRgUMTtbuRh8uV+uSJv9j2leYnfDmF7KttidjGjj/cKVYg8TUp/4WaqV3/OTTZhaOth8nBfI2ekuoGvGRUmr
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2018 12:04:47.1612 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c9e84053-7d23-42a3-a546-08d5e1a65768
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1391
Subject: Re: [dpdk-dev] [PATCH v3 05/16] examples/l2fwd-crypto: limit number
of sessions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jul 2018 12:04:51 -0000
On 6/28/2018 6:22 AM, Pablo de Lara wrote:
> Calculate the number of sessions required for the application,
> knowing that there is only one session required per device.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> examples/l2fwd-crypto/main.c | 19 +++++++++++++++++--
> 1 file changed, 17 insertions(+), 2 deletions(-)
>
> diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
> index 4bca87b19..e8384b0c1 100644
> --- a/examples/l2fwd-crypto/main.c
> +++ b/examples/l2fwd-crypto/main.c
> @@ -42,6 +42,9 @@
> #include <rte_prefetch.h>
> #include <rte_random.h>
> #include <rte_hexdump.h>
> +#ifdef RTE_LIBRTE_PMD_CRYPTO_SCHEDULER
> +#include <rte_cryptodev_scheduler.h>
> +#endif
>
> enum cdev_type {
> CDEV_TYPE_ANY,
> @@ -59,7 +62,6 @@ enum cdev_type {
> #define MAX_AAD_SIZE 65535
> #define MAX_PKT_BURST 32
> #define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */
> -#define MAX_SESSIONS 32
> #define SESSION_POOL_CACHE_SIZE 0
>
> #define MAXIMUM_IV_LENGTH 16
> @@ -2010,6 +2012,19 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,
>
> rte_cryptodev_info_get(cdev_id, &dev_info);
>
> + /* Two sessions objects are required for each session
> + * (one for the header, one for the private data)
> + */
> + uint32_t sessions_needed = 2 * enabled_cdev_count;
Should we do this in #else of
RTE_LIBRTE_PMD_CRYPTO_SCHEDULER ?
Otherwise, Acked.
> +#ifdef RTE_LIBRTE_PMD_CRYPTO_SCHEDULER
> + if (!strcmp(dev_info.driver_name, "crypto_scheduler")) {
> + uint32_t nb_slaves =
> + rte_cryptodev_scheduler_slaves_get(cdev_id,
> + NULL);
> +
> + sessions_needed = 2 * enabled_cdev_count * nb_slaves;
> + }
> +#endif
> if (session_pool_socket[socket_id] == NULL) {
> char mp_name[RTE_MEMPOOL_NAMESIZE];
> struct rte_mempool *sess_mp;
> @@ -2022,7 +2037,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports,
> * device private data
> */
> sess_mp = rte_mempool_create(mp_name,
> - MAX_SESSIONS * 2,
> + sessions_needed,
> max_sess_sz,
> SESSION_POOL_CACHE_SIZE,
> 0, NULL, NULL, NULL,
>