From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B68AA2EFC for ; Tue, 15 Oct 2019 14:31:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A3E61E946; Tue, 15 Oct 2019 14:31:38 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id F0B701E942 for ; Tue, 15 Oct 2019 14:31:36 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 9839314006C; Tue, 15 Oct 2019 12:31:32 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 15 Oct 2019 13:31:21 +0100 To: "Yigit, Ferruh" , Thomas Monjalon , John McNamara , "Marko Kovacevic" , Ajit Khaparde , Somnath Kotur , Ferruh Yigit , John Daley , "Hyong Youb Kim" , Beilei Xing , Qi Zhang , Wenzhuo Lu , Rosen Xu , Konstantin Ananyev , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Rasesh Mody , Shahed Shaikh CC: , David Marchand , "Adrien Mazarguil" References: <20190730155726.26450-1-thomas@monjalon.net> <8145f03d-0911-91a8-73ee-9febe0c1dbec@linux.intel.com> From: Andrew Rybchenko Message-ID: Date: Tue, 15 Oct 2019 15:31:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <8145f03d-0911-91a8-73ee-9febe0c1dbec@linux.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24978.003 X-TM-AS-Result: No-11.189400-8.000000-10 X-TMASE-MatchedRID: 0dFPYP4mu5TmLzc6AOD8DfHkpkyUphL9/lboZPqaz5VUjspoiX02F+rl ububtXXA40wXyO1R6vUAzLwZoZKu8h1d0XLSuq1MPwKTD1v8YV55dnPVq3ls7FfLpI8fOvDuRBC YLdWIlohIa7Y/hxC4Jh0+WPndTSBO0kZSdXm5RCT9xyC38S1f/cWLeiJW8Z+pB/K1FebAbeAX3r 77y8r98VAa2WC3aDeY/Xt2f5DRlpindnNXXW0PEjdfT4zyWoZSZ3KXhrKnN9sy2ckJNvUX+NtuL nl6rSi7nxp6cGETvnCBzSSqd+URSdtLSbjubp9KbMGKOuLn5FUPo0vi0aZfNRbozYDXkvVA7qac 2kKmrwiI/qBnWaQ8VNdM2voEnlx/34rosB7suCR8orCXAPNkJMzzMs2dyeyVUCgEErrUGFz1WUY GMIOdyF3TKYsUo7qO+LgyCwn9RfpccQ8eam5EfTl/1fD/GopdWQy9YC5qGvz6APa9i04WGCq2rl 3dzGQ1+y21Qho7kEmPcYmKPLvemdhupBAfvWklWzGp7yC7iquDyJX674evoA== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--11.189400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24978.003 X-MDID: 1571142696-UsHSfGi-oXY7 Subject: Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Cc Adrien On 10/15/19 2:08 PM, Yigit, Ferruh wrote: > On 7/30/2019 4:57 PM, Thomas Monjalon wrote: >> As legacy filter API "filter_ctrl" is superseded since 2017 >> by the rte_flow API, and got the deprecated attribute in DPDK 19.05, >> it is time to remove the associated features from the matrix. >> Not documenting deprecated features as supported will avoid confusion. >> >> Signed-off-by: Thomas Monjalon > <...> > >> diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini >> index f1a39d0f0..dfbdf084e 100644 >> --- a/doc/guides/nics/features/default.ini >> +++ b/doc/guides/nics/features/default.ini >> @@ -36,13 +36,6 @@ VMDq = >> SR-IOV = >> DCB = >> VLAN filter = >> -Ethertype filter = >> -N-tuple filter = >> -SYN filter = >> -Tunnel filter = >> -Flexible filter = >> -Hash filter = >> -Flow director = >> Flow control = >> Flow API = >> Rate limitation = > I suggest adding these features back! > > "Flow director" and other filters are features that device/driver supports. > > And "Flow API" and "filter_ctrl" are methods used to implement these features. > Indeed they are only different APIs to get input from application/user. > > It doesn't really mean much to say "Flow API" is supported? So what is really > supported? It matters more what feature is supported. > > Since we are saying old method is deprecated, we can update the feature list of > drivers which implements filtering features using old method as not supported. > And that is the case with this patch since old APIs are marked as deprecated, > users can't use them to enable a filtering feature. > > Indeed I am for removing the "Flow API" from feature list, first it is not a > feature, second if it is only method to enable a filtering, and if filtering is > enabled in a driver, what is the point of redundant "Flow API" listing? > > I can make a quick patch if there is no objection, thanks. As I understand it was a decision to avoid details about flow API support in features matrix. Mainly because matrix would be really huge in attempt to represent it. The question is why filters/patterns mentioned above are better than others and should be mentioned. I'm not against adding some details, just want to understand criteria. Flexible and hash are definitely not well defined. What is flow director and which features should be supported to say yes?