From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] net/sfc: advertise offload caps directly by Rx datapaths
Date: Thu, 6 Jun 2019 17:54:04 +0100 [thread overview]
Message-ID: <f659e460-7a3a-0d22-e635-1d56355a6ec1@intel.com> (raw)
In-Reply-To: <1559378564-14636-1-git-send-email-arybchenko@solarflare.com>
On 6/1/2019 9:42 AM, Andrew Rybchenko wrote:
> Rx datapath feature bits were useful on migration from the old offload API
> to the new one. However, right now it just adds indirection which
> complicates code reading and understanding. Also addition of a new
> offloads requires addition of a new feature bits and makes patches longer
> and harder to understand. So, remove feature bits which correspond to Rx
> offloads and simply advertise device and per-queue offloads directly.
> Generic code could still mask some offloads if running HW or FW does not
> support it.
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Reviewed-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Reviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Series applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2019-06-06 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-01 8:42 Andrew Rybchenko
2019-06-01 8:42 ` [dpdk-dev] [PATCH 2/2] net/sfc: advertise offload caps directly by Tx datapaths Andrew Rybchenko
2019-06-06 16:54 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f659e460-7a3a-0d22-e635-1d56355a6ec1@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).