From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03A89A04F5; Thu, 12 Dec 2019 10:45:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AB172374C; Thu, 12 Dec 2019 10:45:07 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 2A38F2BC8 for ; Thu, 12 Dec 2019 10:45:05 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2019 01:45:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,305,1571727600"; d="scan'208";a="265162212" Received: from klaatz-mobl1.ger.corp.intel.com (HELO [10.237.221.89]) ([10.237.221.89]) by FMSMGA003.fm.intel.com with ESMTP; 12 Dec 2019 01:45:03 -0800 To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com, ray.kinsella@intel.com References: <20191129210905.1865-1-kevin.laatz@intel.com> <20191211182147.19355-1-kevin.laatz@intel.com> <20191211182147.19355-2-kevin.laatz@intel.com> <0e73ef91-56d4-8933-0d5a-b98f1a1b5141@redhat.com> From: "Laatz, Kevin" Message-ID: Date: Thu, 12 Dec 2019 09:45:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <0e73ef91-56d4-8933-0d5a-b98f1a1b5141@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v4 1/3] build: add dump files for v20.0 ABI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/12/2019 08:43, David Marchand wrote: > > On 11/12/2019 19:21, Kevin Laatz wrote: >> This patch adds the .dump files generated for the v20.0 ABI. These files >> will be used to compare the ABI during the meson build when the >> compat_checks meson is enabled. If there is a mismatch between the .dump >> files (the baseline, ie. current stable ABI version) and the code being >> compiled, then abidiff will report an error and the build will fail. >> >> The .dump files are stored in the drivers/.abi and lib/.abi directories. >> The directories are hidden to reduce clutter in the respective directories >> and also to discourage changing these files since they should not be >> modified. >> >> Signed-off-by: Kevin Laatz >> --- >> drivers/.abi/librte_bus_dpaa.dump | 5303 ++++++++++++++ >> drivers/.abi/librte_bus_fslmc.dump | 5084 +++++++++++++ >> drivers/.abi/librte_bus_ifpga.dump | 973 +++ >> drivers/.abi/librte_bus_pci.dump | 835 +++ >> drivers/.abi/librte_bus_vdev.dump | 408 ++ >> drivers/.abi/librte_bus_vmbus.dump | 918 +++ >> drivers/.abi/librte_common_cpt.dump | 36 + >> drivers/.abi/librte_common_dpaax.dump | 177 + >> drivers/.abi/librte_common_octeontx.dump | 77 + >> drivers/.abi/librte_common_octeontx2.dump | 988 +++ >> drivers/.abi/librte_mempool_bucket.dump | 15 + >> drivers/.abi/librte_mempool_dpaa.dump | 323 + >> drivers/.abi/librte_mempool_dpaa2.dump | 484 ++ >> drivers/.abi/librte_mempool_octeontx.dump | 22 + >> drivers/.abi/librte_mempool_octeontx2.dump | 643 ++ >> drivers/.abi/librte_mempool_ring.dump | 15 + >> drivers/.abi/librte_mempool_stack.dump | 16 + >> drivers/.abi/librte_pmd_af_packet.dump | 22 + >> drivers/.abi/librte_pmd_af_xdp.dump | 23 + >> drivers/.abi/librte_pmd_ark.dump | 26 + >> drivers/.abi/librte_pmd_atlantic.dump | 1296 ++++ >> drivers/.abi/librte_pmd_avp.dump | 26 + >> drivers/.abi/librte_pmd_axgbe.dump | 27 + >> .../.abi/librte_pmd_bbdev_fpga_lte_fec.dump | 74 + >> drivers/.abi/librte_pmd_bbdev_null.dump | 17 + >> drivers/.abi/librte_pmd_bbdev_turbo_sw.dump | 17 + >> drivers/.abi/librte_pmd_bnx2x.dump | 28 + >> drivers/.abi/librte_pmd_bnxt.dump | 3499 +++++++++ >> drivers/.abi/librte_pmd_bond.dump | 3586 +++++++++ >> drivers/.abi/librte_pmd_caam_jr.dump | 47 + >> drivers/.abi/librte_pmd_ccp.dump | 1870 +++++ >> drivers/.abi/librte_pmd_crypto_scheduler.dump | 1473 ++++ >> drivers/.abi/librte_pmd_cxgbe.dump | 27 + >> drivers/.abi/librte_pmd_dpaa.dump | 2929 ++++++++ >> drivers/.abi/librte_pmd_dpaa2.dump | 3319 +++++++++ >> drivers/.abi/librte_pmd_dpaa2_event.dump | 36 + >> drivers/.abi/librte_pmd_dpaa2_sec.dump | 1511 ++++ >> drivers/.abi/librte_pmd_dpaa_event.dump | 32 + >> drivers/.abi/librte_pmd_dpaa_sec.dump | 1459 ++++ >> drivers/.abi/librte_pmd_dsw_event.dump | 23 + >> drivers/.abi/librte_pmd_e1000.dump | 3414 +++++++++ >> drivers/.abi/librte_pmd_ena.dump | 32 + >> drivers/.abi/librte_pmd_enetc.dump | 27 + >> drivers/.abi/librte_pmd_enic.dump | 3282 +++++++++ >> drivers/.abi/librte_pmd_failsafe.dump | 3162 ++++++++ >> drivers/.abi/librte_pmd_fm10k.dump | 894 +++ >> drivers/.abi/librte_pmd_hinic.dump | 3110 ++++++++ >> drivers/.abi/librte_pmd_hns3.dump | 28 + >> drivers/.abi/librte_pmd_i40e.dump | 3553 +++++++++ >> drivers/.abi/librte_pmd_iavf.dump | 71 + >> drivers/.abi/librte_pmd_ice.dump | 6395 +++++++++++++++++ >> drivers/.abi/librte_pmd_ifc.dump | 24 + >> drivers/.abi/librte_pmd_ixgbe.dump | 3369 +++++++++ >> drivers/.abi/librte_pmd_kni.dump | 22 + >> drivers/.abi/librte_pmd_liquidio.dump | 27 + >> drivers/.abi/librte_pmd_memif.dump | 27 + >> drivers/.abi/librte_pmd_netvsc.dump | 28 + >> drivers/.abi/librte_pmd_nfp.dump | 27 + >> drivers/.abi/librte_pmd_nitrox.dump | 19 + >> drivers/.abi/librte_pmd_null.dump | 22 + >> drivers/.abi/librte_pmd_null_crypto.dump | 1317 ++++ >> drivers/.abi/librte_pmd_octeontx.dump | 49 + >> drivers/.abi/librte_pmd_octeontx2.dump | 3140 ++++++++ >> drivers/.abi/librte_pmd_octeontx2_crypto.dump | 28 + >> drivers/.abi/librte_pmd_octeontx2_event.dump | 29 + >> .../.abi/librte_pmd_octeontx_compress.dump | 25 + >> drivers/.abi/librte_pmd_octeontx_crypto.dump | 28 + >> drivers/.abi/librte_pmd_octeontx_event.dump | 36 + >> drivers/.abi/librte_pmd_opdl_event.dump | 28 + >> drivers/.abi/librte_pmd_openssl.dump | 1315 ++++ >> drivers/.abi/librte_pmd_pcap.dump | 23 + >> drivers/.abi/librte_pmd_pfe.dump | 41 + >> drivers/.abi/librte_pmd_qat.dump | 118 + >> drivers/.abi/librte_pmd_qede.dump | 46 + >> drivers/.abi/librte_pmd_ring.dump | 142 + >> drivers/.abi/librte_pmd_sfc.dump | 3905 ++++++++++ >> drivers/.abi/librte_pmd_skeleton_event.dump | 25 + >> drivers/.abi/librte_pmd_softnic.dump | 5523 ++++++++++++++ >> drivers/.abi/librte_pmd_sw_event.dump | 28 + >> drivers/.abi/librte_pmd_tap.dump | 26 + >> drivers/.abi/librte_pmd_thunderx.dump | 28 + >> drivers/.abi/librte_pmd_vdev_netvsc.dump | 22 + >> drivers/.abi/librte_pmd_vhost.dump | 57 + >> drivers/.abi/librte_pmd_virtio.dump | 3808 ++++++++++ >> drivers/.abi/librte_pmd_virtio_crypto.dump | 1419 ++++ >> drivers/.abi/librte_pmd_vmxnet3.dump | 27 + >> drivers/.abi/librte_pmd_zlib.dump | 1035 +++ >> drivers/.abi/librte_rawdev_dpaa2_cmdif.dump | 32 + >> drivers/.abi/librte_rawdev_dpaa2_qdma.dump | 185 + >> drivers/.abi/librte_rawdev_ioat.dump | 19 + >> drivers/.abi/librte_rawdev_ntb.dump | 772 ++ >> drivers/.abi/librte_rawdev_octeontx2_dma.dump | 23 + >> drivers/.abi/librte_rawdev_skeleton.dump | 21 + >> lib/.abi/librte_acl.dump | 329 + >> lib/.abi/librte_bbdev.dump | 1789 +++++ >> lib/.abi/librte_bitratestats.dump | 85 + >> lib/.abi/librte_bpf.dump | 280 + >> lib/.abi/librte_cfgfile.dump | 188 + >> lib/.abi/librte_cmdline.dump | 728 ++ >> lib/.abi/librte_compressdev.dump | 1249 ++++ >> lib/.abi/librte_cryptodev.dump | 1806 +++++ >> lib/.abi/librte_distributor.dump | 627 ++ >> lib/.abi/librte_eal.dump | 3330 +++++++++ >> lib/.abi/librte_efd.dump | 319 + >> lib/.abi/librte_ethdev.dump | 5272 ++++++++++++++ >> lib/.abi/librte_eventdev.dump | 5520 ++++++++++++++ >> lib/.abi/librte_fib.dump | 327 + >> lib/.abi/librte_flow_classify.dump | 1054 +++ >> lib/.abi/librte_gro.dump | 428 ++ >> lib/.abi/librte_gso.dump | 402 ++ >> lib/.abi/librte_hash.dump | 578 ++ >> lib/.abi/librte_ip_frag.dump | 814 +++ >> lib/.abi/librte_ipsec.dump | 1269 ++++ >> lib/.abi/librte_jobstats.dump | 197 + >> lib/.abi/librte_kni.dump | 657 ++ >> lib/.abi/librte_kvargs.dump | 98 + >> lib/.abi/librte_latencystats.dump | 427 ++ >> lib/.abi/librte_lpm.dump | 330 + >> lib/.abi/librte_mbuf.dump | 746 ++ >> lib/.abi/librte_member.dump | 216 + >> lib/.abi/librte_mempool.dump | 764 ++ >> lib/.abi/librte_meter.dump | 197 + >> lib/.abi/librte_metrics.dump | 102 + >> lib/.abi/librte_net.dump | 489 ++ >> lib/.abi/librte_pci.dump | 85 + >> lib/.abi/librte_pdump.dump | 339 + >> lib/.abi/librte_pipeline.dump | 1795 +++++ >> lib/.abi/librte_port.dump | 567 ++ >> lib/.abi/librte_power.dump | 490 ++ >> lib/.abi/librte_rawdev.dump | 840 +++ >> lib/.abi/librte_rcu.dump | 218 + >> lib/.abi/librte_reorder.dump | 455 ++ >> lib/.abi/librte_rib.dump | 556 ++ >> lib/.abi/librte_ring.dump | 285 + >> lib/.abi/librte_sched.dump | 1108 +++ >> lib/.abi/librte_security.dump | 1125 +++ >> lib/.abi/librte_stack.dump | 183 + >> lib/.abi/librte_table.dump | 544 ++ >> lib/.abi/librte_telemetry.dump | 122 + >> lib/.abi/librte_timer.dump | 322 + >> lib/.abi/librte_vhost.dump | 1624 +++++ >> 141 files changed, 129812 insertions(+) > This mail did not make it to the list, I suppose because of its size > (Thomas?). Yes, it was due to its size :( Any suggested ways to send this instead? Maybe split drivers and lib into separate patches? What's the max size? > > You missed some drivers, which makes my tests fail right away: > > $ for file in $(find lib/ drivers/ -name "*.map") > do > pattern=$(basename ${file/_version.map}) > [ $(find lib/ drivers/ -name "*$pattern*.dump" |wc -l) = 0 ] || > continue > echo $file > done > > drivers/common/mvep/rte_common_mvep_version.map > drivers/crypto/snow3g/rte_pmd_snow3g_version.map > drivers/crypto/mvsam/rte_pmd_mvsam_version.map > drivers/crypto/kasumi/rte_pmd_kasumi_version.map > drivers/crypto/aesni_gcm/rte_pmd_aesni_gcm_version.map > drivers/crypto/aesni_mb/rte_pmd_aesni_mb_version.map > drivers/crypto/armv8/rte_pmd_armv8_version.map > drivers/crypto/zuc/rte_pmd_zuc_version.map > drivers/compress/isal/rte_pmd_isal_version.map > drivers/raw/ifpga/rte_rawdev_ifpga_version.map > drivers/net/szedata2/rte_pmd_szedata2_version.map > drivers/net/nfb/rte_pmd_nfb_version.map > drivers/net/mlx4/rte_pmd_mlx4_version.map > drivers/net/mvpp2/rte_pmd_mvpp2_version.map > drivers/net/ipn3ke/rte_pmd_ipn3ke_version.map > drivers/net/mlx5/rte_pmd_mlx5_version.map > drivers/net/mvneta/rte_pmd_mvneta_version.map > > > I will try to fix this and test it further later today. Will try to get the build working with all and can re-spin the patch.