Re: [dpdk-dev] [PATCH v2 17/29] net/ena: add support for large LLQ headers

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 4/1/2020 3:21 PM, Michal Krawczyk wrote:
> If the device supports larger LLQ (Low Latency Queue) headers, the user
> can activate them by enabling CONFIG_RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS
> flag in the configuration file.
> 
> If the device isn't supporting this feature, the default value will be
> used.
> 
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> Reviewed-by: Igor Chauskin <igorch@amazon.com>
> Reviewed-by: Guy Tzalik <gtzalik@amazon.com>
> ---
> v2:
>   * Use devargs instead of compilation options
> 
>  doc/guides/nics/ena.rst      |   8 +++
>  drivers/net/ena/ena_ethdev.c | 110 +++++++++++++++++++++++++++++++++--
>  drivers/net/ena/ena_ethdev.h |   2 +
>  3 files changed, 114 insertions(+), 6 deletions(-)
> 
> diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst
> index bbf27f235a..d5081e91e5 100644
> --- a/doc/guides/nics/ena.rst
> +++ b/doc/guides/nics/ena.rst
> @@ -95,6 +95,14 @@ Configuration information
>     * **CONFIG_RTE_LIBRTE_ENA_COM_DEBUG** (default n): Enables or disables debug
>       logging of low level tx/rx logic in ena_com(base) within the ENA PMD driver.
>  
> +**Runtime Configuration Parameters**
> +
> +   * **large_llq_hdr** (default 0)
> +
> +     Enables or disables usage of large LLQ headers. This option will have
> +     effect only if the device also supports large LLQ headers. Otherwise, the
> +     default value will be used.

Again, better to describe what 'LLQ' is, and you may want to describe what is
the usage/benefit of enabling large LLQ headers, up to you.