From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Krzysztof Karas <krzysztof.karas@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org, "Xueming(Steven) Li" <xuemingl@nvidia.com>
Subject: Re: [PATCH] ethdev: initialize id in eth_representor_cmp()
Date: Tue, 28 Feb 2023 23:23:44 +0000 [thread overview]
Message-ID: <f67e424a-d32b-f7a0-9336-b7bae3e5b451@amd.com> (raw)
In-Reply-To: <20230220164406.1490041-1-krzysztof.karas@intel.com>
On 2/20/2023 4:44 PM, Krzysztof Karas wrote:
> When Link Time Optimization is enabled, compiler may
> complain about "id" in eth_representor_cmp() being
> uninitialized.
>
> To suppress the warning it is enough to add explicit
> initialization of the variable causing the issue.
>
> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
Fixes: df7547a6a2cc ("ethdev: add helper function to get representor ID")
Cc: stable@dpdk.org
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
> ---
> .mailmap | 1 +
> lib/ethdev/rte_class_eth.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/.mailmap b/.mailmap
> index 5015494210..ba34945bc5 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -1573,3 +1573,4 @@ Ziye Yang <ziye.yang@intel.com>
> Zoltan Kiss <zoltan.kiss@schaman.hu> <zoltan.kiss@linaro.org>
> Zorik Machulsky <zorik@amazon.com>
> Zyta Szpak <zyta@marvell.com> <zr@semihalf.com> <zyta.szpak@semihalf.com>
> +Krzysztof Karas <krzysztof.karas@intel.com>
Alphabetically sorted while merging.
Also patch title updated since it gives warning:
$ ./devtools/check-git-log.sh -n1
Wrong headline format:
ethdev: initialize id in eth_representor_cmp()
prev parent reply other threads:[~2023-02-28 23:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 16:44 Krzysztof Karas
2023-02-28 23:23 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f67e424a-d32b-f7a0-9336-b7bae3e5b451@amd.com \
--to=ferruh.yigit@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=krzysztof.karas@intel.com \
--cc=thomas@monjalon.net \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).