From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id F0BBB1B4FA for ; Thu, 21 Mar 2019 15:18:37 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5D468C13070C; Thu, 21 Mar 2019 14:18:37 +0000 (UTC) Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 74F4319C57; Thu, 21 Mar 2019 14:18:33 +0000 (UTC) To: Stephen Hemminger , Tiwei Bie Cc: Kevin Traynor , Jens Freimann , zhihong.wang@intel.com, dev@dpdk.org References: <20190319064312.13743-1-tiwei.bie@intel.com> <20190319064312.13743-6-tiwei.bie@intel.com> <20190319094432.iap4i7ffs6soukr7@jenstp.localdomain> <20190319100939.GA3839@dpdk-tbie.sh.intel.com> <20190319134751.ibgaalfravjm77lh@jenstp.localdomain> <1d05e311-c60b-cb1d-ff2b-974e01a0451b@redhat.com> <64884489-8cc7-7c3f-5b65-09f46112adb0@redhat.com> <20190320044026.GA23715@dpdk-tbie.sh.intel.com> <20190320105009.27ef685c@shemminger-XPS-13-9360> From: Maxime Coquelin Message-ID: Date: Thu, 21 Mar 2019 15:18:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190320105009.27ef685c@shemminger-XPS-13-9360> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 21 Mar 2019 14:18:37 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2019 14:18:38 -0000 On 3/20/19 6:50 PM, Stephen Hemminger wrote: > On Wed, 20 Mar 2019 12:40:26 +0800 > Tiwei Bie wrote: > >>> I agree the vq_ prefix is not needed and I think the code is more >>> readable in general seeing the packed/split name when using the struct. >>> >>> Please also consider that cosmetic changes in multiple places likely >>> mean backports will not apply cleanly to the stable branches anymore, so >>> it does have a cost. >> >> Yeah, agree. > > > prefixing structure elements is an old school BSD thing back from when > compilers were not smart about namespaces for identifiers. Ha, good to know! I wasn't aware of that. > > Agree that it is no longer needed. > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A144DA00E6 for ; Thu, 21 Mar 2019 15:18:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F3231B4FC; Thu, 21 Mar 2019 15:18:39 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id F0BBB1B4FA for ; Thu, 21 Mar 2019 15:18:37 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5D468C13070C; Thu, 21 Mar 2019 14:18:37 +0000 (UTC) Received: from [10.36.112.59] (ovpn-112-59.ams2.redhat.com [10.36.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 74F4319C57; Thu, 21 Mar 2019 14:18:33 +0000 (UTC) To: Stephen Hemminger , Tiwei Bie Cc: Kevin Traynor , Jens Freimann , zhihong.wang@intel.com, dev@dpdk.org References: <20190319064312.13743-1-tiwei.bie@intel.com> <20190319064312.13743-6-tiwei.bie@intel.com> <20190319094432.iap4i7ffs6soukr7@jenstp.localdomain> <20190319100939.GA3839@dpdk-tbie.sh.intel.com> <20190319134751.ibgaalfravjm77lh@jenstp.localdomain> <1d05e311-c60b-cb1d-ff2b-974e01a0451b@redhat.com> <64884489-8cc7-7c3f-5b65-09f46112adb0@redhat.com> <20190320044026.GA23715@dpdk-tbie.sh.intel.com> <20190320105009.27ef685c@shemminger-XPS-13-9360> From: Maxime Coquelin Message-ID: Date: Thu, 21 Mar 2019 15:18:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190320105009.27ef685c@shemminger-XPS-13-9360> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 21 Mar 2019 14:18:37 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 05/10] net/virtio: refactor virtqueue structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190321141831.ogd9sDt4RAVGlduZFf3WHM1Shu2UP9USG7i3Lxnv_6M@z> On 3/20/19 6:50 PM, Stephen Hemminger wrote: > On Wed, 20 Mar 2019 12:40:26 +0800 > Tiwei Bie wrote: > >>> I agree the vq_ prefix is not needed and I think the code is more >>> readable in general seeing the packed/split name when using the struct. >>> >>> Please also consider that cosmetic changes in multiple places likely >>> mean backports will not apply cleanly to the stable branches anymore, so >>> it does have a cost. >> >> Yeah, agree. > > > prefixing structure elements is an old school BSD thing back from when > compilers were not smart about namespaces for identifiers. Ha, good to know! I wasn't aware of that. > > Agree that it is no longer needed. >