From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B31641CB2; Thu, 16 Feb 2023 14:50:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 596FF40EE3; Thu, 16 Feb 2023 14:50:55 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2049.outbound.protection.outlook.com [40.107.94.49]) by mails.dpdk.org (Postfix) with ESMTP id C51C440A8B for ; Thu, 16 Feb 2023 14:50:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XiirHbKd3EN9alITkgawdRK8VXS+uxnTY07X8CnC4J9Kd0PWdWsy1ReOVjbcFGpXyxStp/aYO9z/eTFal9/jqMY4pKblvICsh1LuOpBxEXFIMJQUteKrqaq1lwlYYQAFTHoTQEIgBxrYA2jQW3Uj1V4mXg9K011NVY0f8vc9Mj7b56ljnF/qsgCTJUvQwJYB01YJYiqBzJ3TIM3ZZ1aEw5nAJ7RasCBWDFtT71ZYVRpn4ygoag99izI02SoQOQDVdehcu2Za6bjE2zc+F7OGXHC5c/fhdzFu5J2/rRj6P8tRDmwD/d6a4sA58G3DNxohKEgkMyJ7jgjD7qaEiwa7Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7gNRUqJFEjhhRZgH92FuzL6stz0UL/wsUqL1oDuXHFQ=; b=Knc7vnlkhcXskO1iJ6lEosDh9ui14lr4/hosVIkWLcmQgTJE4zyPez/eDEp2y5PhGB1oMND5eOor6eQV70IzTvvw5Zwg6jVuz1JqbyXxTVgy8Rjq+wE5r994NxC0og76mENgCbhrXbSmDPxjwtpz9z0H/cZvH3pMrEW25PrcftBDooNCp4yHr6HO5mlaPv0FBDmpp+7I1UwGT8aLCWaODyHy/gZ0eoaB7rEIqAgEMX8khsOD0xK0LPTFIbmP6/Q7as9WSlgtwyJ/VnUB97CmHNT0JXqaZNWMTxE15BZB2NmBxgytJpUpjrUiWLq9ID9v2+2V29JaYxBzfxRgUA9pJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7gNRUqJFEjhhRZgH92FuzL6stz0UL/wsUqL1oDuXHFQ=; b=tu5ZjpQElegbtb2343757xdSQe9Bdunsa46jVtwZztOSuEivzy0VXxaFFqW4qytna2JaeHoCBpYcrMt+k8jWMisyJjsn2hWs8b9ZLUFHXt+/1rPBsi0/+idrlyC+aJhLELWrXVMwH5A7MmC6uJjHE2EKR3JwGut1ed5bZrypimA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS7PR12MB5981.namprd12.prod.outlook.com (2603:10b6:8:7c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Thu, 16 Feb 2023 13:50:52 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6111.013; Thu, 16 Feb 2023 13:50:52 +0000 Message-ID: Date: Thu, 16 Feb 2023 13:50:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: Shibin Koikkara Reeny , dev@dpdk.org, qi.z.zhang@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, john.mcnamara@intel.com Cc: ciara.loftus@intel.com References: <20230210154828.397475-1-shibin.koikkara.reeny@intel.com> <20230215163014.725646-1-shibin.koikkara.reeny@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v6] net/af_xdp: support CNI Integration In-Reply-To: <20230215163014.725646-1-shibin.koikkara.reeny@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0394.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:f::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS7PR12MB5981:EE_ X-MS-Office365-Filtering-Correlation-Id: bca6a532-d274-4a6a-b181-08db1024d19c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XHallisna85uMbjpYMnvfCQwZCvDBekxVx81PZ1ANKojxG8i6Q+uZaNCaQbIywRur0/WswWpIQE2X03/8MzmNNRvqvAm8rJpawBSqgF66LKuN3UER4NpfU1u/nmlmWnO4FdzoGQj8X0hp7xNq2Iz3EkXlw0mr0hh095CAZ8AilKf+o/tNnJeZ/p9dmxYWSNYtbaav0kQopwGMk6ReIMdA9wpCNAWpuO3RIXJUtdHW7kv0mDCeahGoAiIPH2flKr7Op29bDNgbCggF5c7xJb1P4owr97FQc9/QI9LX+Z3Qsa5FDY0iGAW11Ole/2c6frw+/JvS2aF8XUGb2a4Qz5/P0ygv2SwpjHOE94qXwC1pRIAJ025cg3yQp7Gapd+CjIl79+Y6JUzlKCPNM128YErz4zGZKT0rAy5Ymlczaz0xyYNg7gJLLiqNYnoM5SGur90vcREwGHKt/bJy43t9kiPfo0sbDoNmuirYf+MefZFAzuwGb0hLRRmxQUO/qYoOtlkCU7s0RUwD7g2PaXWPOa0+cCm8GEUF7/lHaGcLXY7oOVf4kCkWqq7TVloveYG9StAvQfk86llXVHvYTz4tb2n79cM0omLmHFQngWyJHSczWLge5jMQ7wjHi8tB6dh1fS2aF/gkwCXFLd0fKeGxAH/E5QNGNyS4CKR2v4jnIeuLcZ2OwhrUj1B1boELdIIyyEM2y5wAgakSmNoaXR/3fbXaTF/ZrGHe5ea1bG7XNkhr/c= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(136003)(376002)(396003)(366004)(346002)(451199018)(6666004)(86362001)(478600001)(8936002)(966005)(8676002)(66556008)(36756003)(4326008)(66946007)(83380400001)(66476007)(31696002)(6486002)(41300700001)(316002)(2906002)(6512007)(38100700002)(26005)(186003)(31686004)(2616005)(53546011)(6506007)(44832011)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXRvNnZaRHNqdWJqVjdNVnVJMHNIOFZGSDRqZkV3VmE0dmFiTmpSK3BDZkU0?= =?utf-8?B?ZFdCRTZQOHB1SHo0OFNwNVYxWFdlSm1HZlpOY3hmSGY4dXIxMUxnWFVCa0dV?= =?utf-8?B?UVdWOEw4ZVJQUWNmbWVzaGhjRFhjd3lRa3BrMzB1QStyZlVjQ254VnZ5cGNE?= =?utf-8?B?cE81djgrdElBWHpFK01saU01WVVXTFE3SDFtS1VkcGNjbXVsRlBlaFVnUVdV?= =?utf-8?B?ZWpxMGpSTEtwSHBaR2VQMW9rQ2djMk1ReFZkTnJHeUFIb2ZqRmd1R0dPeUxV?= =?utf-8?B?K1N0b3dhTVN5bmVVbzVCWXhBaFlsK3N2TUIwVDRwdnlsQU5ZRFdkRVJiUUhE?= =?utf-8?B?VEhCb1BrZjJBWW56WUoycjlMTXVhdnVETWM2SGVwWk40bHAxc0xIbnpaT0tv?= =?utf-8?B?a3FYbUVHbk11djVPMkJNVDZqbjFhUGVDcS9ZY2cwbGlLVkdtcjYwOVUrbW1v?= =?utf-8?B?UHZPUWdzTDBPanBRUVZtRFZDZW9BRGlsYXJBdkNOU0Q5WExYQVVVWXlaRkNz?= =?utf-8?B?TEVmOGhlY2dla3gweUZ6YkpyRzltM3dEMTlmVlUvL1lRM3dDenJJMDk5S3dt?= =?utf-8?B?aEs3TnVNdVk1VzJaM0dPSVdqZTZnSFBMakx0bEJMMEI4YUNMVEk4VFJ2RjdW?= =?utf-8?B?cXV4dkxRb3RlOGJzRFNtUEM5R3luQjlObGdrbVdORVNtbksxWENCSHlVbWh1?= =?utf-8?B?cFpUTFNQbUtPU0ZJNGFBTndnb0xQdXl3OW9kTTBKUkRVQTBxRk5rWTB4ZFZ1?= =?utf-8?B?MFBJOGh1M1NiNm9XQ2l5MldjOWcxVnBoQlBXSHFoeE9Bcm5qL3NPNkF2emQx?= =?utf-8?B?RXV3VDVpN3BYOHlEUVdHYk9iWCtYTy9idjdxV1hwTWdDYndNMXdBcmY3N2d2?= =?utf-8?B?bkwrdGpCNElmWlIzYWk0TUFEN0Y5QzhMTjg4Z25vRVM3N2tYb0syaS9tRXdI?= =?utf-8?B?aWtnc2RKZkFsT1gvUWV6VDluOGgxRmNWMEh5THFqVWhYTDRielhWM0hnWTY1?= =?utf-8?B?TkFkNkdsSWc5c3YzYTZvdkJ5M0J2blNBTDB4WGZ5cHovZG5rWUg1UFpYcHRy?= =?utf-8?B?VENWN01KQjVPUXA3T0RvVkRkM2Mxa2hVT2tvVzBIRFRqRzJwMk5EVXRlVERY?= =?utf-8?B?WEFEMjBIMEpyNkhvRXZNMkh6M2pjSkVOTHEzbS9XaS9ESCs5Unc3YTlPYnZT?= =?utf-8?B?WUt4M0lZUXo2b0pVWjd1Rlo2WktFN0JxTit4azBYdmRBaGpERTJaSFE0RmJ2?= =?utf-8?B?Q1ZxTzFCSkNWT3JWS1ZpbVhVK0ZRb0hvMkpMaWxrcGNFV2g3Mnkyb0ZKZUxC?= =?utf-8?B?WWJUbGFWN1ByVmJFUStJMXBHSjRrRXpEd2NNYk9Gdkk1VURuZUE5Y0N5ZG43?= =?utf-8?B?VUhwWmV1a0JDOFd1eUtvb0Nhenc4Zm0zd2ZOZ3JGRVRHN2MyalVSR2pGWE02?= =?utf-8?B?SFNqWnV0WHN4QWp6M3hNVmhPeVRVUzR4ajMxamg2d2ZYRFdOWVdJcXlkQlZz?= =?utf-8?B?SHl5bjNZOHdzV29DMVFSdWI5Vk1Cd1JsajJ4U1FoS3J5a1pHa0Nwa2pLNWkv?= =?utf-8?B?bmI1SDFNVkEvV3gzcmZVdTNYckVPRGxiWVRFMFpiclVZdmoyeDhVSVNTT1Yz?= =?utf-8?B?MlFQS0lLeDZ0Y2xhM3FWTGlrZ2kveWd4UC8rQXVMdVJXSENVTi90bWlSUE1m?= =?utf-8?B?MGh1VHQrV2RKSzFCWUpvRU1uWEJtZ1NCQlppWU16a1lZMkcwRW5JWm5aYXpY?= =?utf-8?B?T1ZmTkhXQ1hFZ3pLcEc3a3FYbzY0dkRsQ1RvVDRBa0NnRVZsOWxlcVh2SU1r?= =?utf-8?B?Z3NmUVJSdTV1Z3B4L2xYMHNVZWZTY25oMFBDWnZPWlNZMmpyY29obnowbDRV?= =?utf-8?B?T0dyblFXenZ1ME5sR0h5SXRsN3gxL1B3UVdZQWlRTnJEZXdkaUJHdkhCOEd6?= =?utf-8?B?TkhWNXFkVTBWN1lmeWtCWU5iY21RV3Z6cDU1ZkVVNWYrdzRZMUlidXpVWlIv?= =?utf-8?B?MFVXRWhEY0hzYWdjakJhR09SdE8rL0JRL05YNFBDZ2ZSektYVG44YlpzK2Rv?= =?utf-8?B?SjZYYUVIdllBZVZ5UWNPclBqWXdUT2cwbE85UG9aY0xtK1N4clhIS1RuYlNm?= =?utf-8?Q?kAbM3aLT13Qd77p7lQYNarX/D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: bca6a532-d274-4a6a-b181-08db1024d19c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2023 13:50:52.6818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HJhnWJFvqsqUY50ciw36UaZFr6py/NOxmhkvXLswo/b7h+djSUjVZ95g7UBXhEJ8 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5981 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/2023 4:30 PM, Shibin Koikkara Reeny wrote: > Integrate support for the AF_XDP CNI and device plugin [1] so that the > DPDK AF_XDP PMD can work in an unprivileged container environment. > Part of the AF_XDP PMD initialization process involves loading > an eBPF program onto the given netdev. This operation requires > privileges, which prevents the PMD from being able to work in an > unprivileged container (without root access). The plugin CNI handles > the program loading. CNI open Unix Domain Socket (UDS) and waits > listening for a client to make requests over that UDS. The client(DPDK) > connects and a "handshake" occurs, then the File Descriptor which points > to the XSKMAP associated with the loaded eBPF program is handed over > to the client. The client can then proceed with creating an AF_XDP > socket and inserting the socket into the XSKMAP pointed to by the > FD received on the UDS. > > A new vdev arg "use_cni" is created to indicate user wishes to run > the PMD in unprivileged mode and to receive the XSKMAP FD from the CNI. > When this flag is set, the XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD libbpf flag > should be used when creating the socket, which tells libbpf not to load the > default libbpf program on the netdev. We tell libbpf not to do this because > the loading is handled by the CNI in this scenario. > > Patch include howto doc explain how to configure AF_XDP CNI to > working with DPDK. > > [1]: https://github.com/intel/afxdp-plugins-for-kubernetes > > Signed-off-by: Shibin Koikkara Reeny Keeping tags from previous version, since change is only in documentation I believe they are still valid, please let me know if not, I can drop them in next-net: Tested-by: Anatoly Burakov Reviewed-by: Qi Zhang Acked-by: John McNamara Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.