From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A8F4A046B for ; Thu, 27 Jun 2019 14:28:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E0F3559A; Thu, 27 Jun 2019 14:28:09 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 747754F91 for ; Thu, 27 Jun 2019 14:28:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2019 05:28:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,423,1557212400"; d="scan'208";a="313778180" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.3.102]) ([10.252.3.102]) by orsmga004.jf.intel.com with ESMTP; 27 Jun 2019 05:28:06 -0700 To: Bruce Richardson , dev@dpdk.org Cc: thomas@monjalon.net, jerinj@marvell.com References: <20190530212525.40370-1-bruce.richardson@intel.com> <20190627104055.8244-1-bruce.richardson@intel.com> <20190627104055.8244-5-bruce.richardson@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 27 Jun 2019 13:28:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190627104055.8244-5-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 4/8] raw/ioat: create device on probe and destroy on release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 27-Jun-19 11:40 AM, Bruce Richardson wrote: > Add the create/destroy driver functions so that we can actually allocate > a rawdev and destroy it when done. No rawdev API functions are actually > implemented at this point. > > Signed-off-by: Bruce Richardson > --- > + rawdev->driver_name = dev->device.driver->name; > + > + ioat = rawdev->dev_private; > + ioat->rawdev = rawdev; > + ioat->regs = dev->mem_resource[0].addr; > + ioat->ring_size = 0; > + ioat->desc_ring = NULL; > + ioat->status_addr = rte_malloc_virt2iova(ioat) + > + offsetof(struct rte_ioat_rawdev, status); While reviewing other patch, i remembered that i've seen this here. You can't make any guarantees about IOVA addresses in rte_malloc-allocated memory. Are you sure you don't require IOVA-contiguous memory here? -- Thanks, Anatoly