Re: [PATCH v4] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices

[Maxime Coquelin <maxime.coquelin@redhat.com>]

Hi Abhishek,

On 12/15/22 04:48, Abhishek Maheshwari wrote:
> Amending the match table for vdpa/ifcvf driver to work with virtio-blk
> devices that have default subsystem IDs.
> 
> Cc: stable@dpdk.org

Is that really a fix? If so, you need to add the Fixes tag so that LTS
maintainers know on which LTS it applies.

Other than that:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

If you provide me with the faulty commit, I can add it when applying.

Thanks,
Maxime


Thanks,
Maxime

> 
> Signed-off-by: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
> 
> ---
> v3:
> * Removing match with ANY_IDs
> * Adding support for only default subsystem IDs
> 
> v2:
> * commit message update
> ---
>   drivers/vdpa/ifc/base/ifcvf.h | 1 +
>   drivers/vdpa/ifc/ifcvf_vdpa.c | 7 +++++++
>   2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h
> index 3726da7a33..04c81c8196 100644
> --- a/drivers/vdpa/ifc/base/ifcvf.h
> +++ b/drivers/vdpa/ifc/base/ifcvf.h
> @@ -20,6 +20,7 @@
>   #define IFCVF_SUBSYS_DEVICE_ID              0x001A
>   #define IFCVF_SUBSYS_NET_DEVICE_ID          0x0001
>   #define IFCVF_SUBSYS_BLK_DEVICE_ID          0x0002
> +#define IFCVF_SUBSYS_DEFAULT_DEVICE_ID      0x0000
>   
>   #define IFCVF_MAX_QUEUES		32
>   
> diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c
> index 49d68ad1b1..edc6db545d 100644
> --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> @@ -1849,6 +1849,13 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
>   	  .subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID,
>   	},
>   
> +	{ .class_id = RTE_CLASS_ANY_ID,
> +	  .vendor_id = IFCVF_VENDOR_ID,
> +	  .device_id = IFCVF_BLK_MODERN_DEVICE_ID,
> +	  .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
> +	  .subsystem_device_id = IFCVF_SUBSYS_DEFAULT_DEVICE_ID,
> +	}, /* virtio-blk devices with default subsystem IDs */
> +
>   	{ .vendor_id = 0, /* sentinel */
>   	},
>   };