From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F5EE42417; Thu, 19 Jan 2023 15:09:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED1E940223; Thu, 19 Jan 2023 15:09:32 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8B95E400D5 for ; Thu, 19 Jan 2023 15:09:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674137371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nZwVWYlQe/zsluFICwLzjarT7RPhKGH5BNXhKUjurKQ=; b=KocH7v4vqgUtvoAVDPxaEKkbMbl6hteOQdbmz9EiUNfF3LYZogQDAhtAZXef6rzcoplKmv eDKq2yrXdfWVW69ViYY/ZfdulwJWK4g8bAgRhsyOOHjEVcURgXzINkYqBUs7LzcMtSUyME Ve3F82WQs9f2DugCP/1tN9f0XttJhHg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-621-w4z2CekUMo-0z4sznTnjsA-1; Thu, 19 Jan 2023 09:09:27 -0500 X-MC-Unique: w4z2CekUMo-0z4sznTnjsA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2B3D78A0100; Thu, 19 Jan 2023 14:09:27 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 388521121315; Thu, 19 Jan 2023 14:09:25 +0000 (UTC) Message-ID: Date: Thu, 19 Jan 2023 15:09:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v4] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices To: Abhishek Maheshwari , xiao.w.wang@intel.com Cc: dev@dpdk.org, stable@dpdk.org, chenbo.xia@intel.com, purna.chandra.mandal@intel.com References: <20221215034207.2145419-1-abhishek.maheshwari@intel.com> <20221215034818.2145612-1-abhishek.maheshwari@intel.com> From: Maxime Coquelin In-Reply-To: <20221215034818.2145612-1-abhishek.maheshwari@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Abhishek, On 12/15/22 04:48, Abhishek Maheshwari wrote: > Amending the match table for vdpa/ifcvf driver to work with virtio-blk > devices that have default subsystem IDs. > > Cc: stable@dpdk.org Is that really a fix? If so, you need to add the Fixes tag so that LTS maintainers know on which LTS it applies. Other than that: Reviewed-by: Maxime Coquelin If you provide me with the faulty commit, I can add it when applying. Thanks, Maxime Thanks, Maxime > > Signed-off-by: Abhishek Maheshwari > > --- > v3: > * Removing match with ANY_IDs > * Adding support for only default subsystem IDs > > v2: > * commit message update > --- > drivers/vdpa/ifc/base/ifcvf.h | 1 + > drivers/vdpa/ifc/ifcvf_vdpa.c | 7 +++++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/vdpa/ifc/base/ifcvf.h b/drivers/vdpa/ifc/base/ifcvf.h > index 3726da7a33..04c81c8196 100644 > --- a/drivers/vdpa/ifc/base/ifcvf.h > +++ b/drivers/vdpa/ifc/base/ifcvf.h > @@ -20,6 +20,7 @@ > #define IFCVF_SUBSYS_DEVICE_ID 0x001A > #define IFCVF_SUBSYS_NET_DEVICE_ID 0x0001 > #define IFCVF_SUBSYS_BLK_DEVICE_ID 0x0002 > +#define IFCVF_SUBSYS_DEFAULT_DEVICE_ID 0x0000 > > #define IFCVF_MAX_QUEUES 32 > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c > index 49d68ad1b1..edc6db545d 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -1849,6 +1849,13 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = { > .subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID, > }, > > + { .class_id = RTE_CLASS_ANY_ID, > + .vendor_id = IFCVF_VENDOR_ID, > + .device_id = IFCVF_BLK_MODERN_DEVICE_ID, > + .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID, > + .subsystem_device_id = IFCVF_SUBSYS_DEFAULT_DEVICE_ID, > + }, /* virtio-blk devices with default subsystem IDs */ > + > { .vendor_id = 0, /* sentinel */ > }, > };