From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D1543A0C40;
	Tue,  8 Jun 2021 14:13:08 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5233740689;
	Tue,  8 Jun 2021 14:13:08 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 10F3D4067A
 for <dev@dpdk.org>; Tue,  8 Jun 2021 14:13:07 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 9B1007F514;
 Tue,  8 Jun 2021 15:13:06 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 9B1007F514
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1623154386;
 bh=rUitMt5hgWjl2OtMutdJEl8Ij+3VM2Zwb9KGz1bxuZw=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=X9KVVC6ALvURt1x6QUggHsh7qSN8mhMudc+CUDFo5xkRkN4teKcJd6IGQcijm/iyl
 N/9GHHrt9VMBjW29f38J02yF5EG9awzzlGpWGfM4Zd5aU2y+JK2Vfg5xRorA9vYg9i
 w9gubZy9gt77pfexYzU6NRoy4JWhsPc6pSQ/r7pI=
To: Tyler Retzlaff <roretzla@linux.microsoft.com>,
 Olivier Matz <olivier.matz@6wind.com>
Cc: Raslan Darawsheh <rasland@nvidia.com>, dev@dpdk.org,
 ferruh.yigit@intel.com, orika@nvidia.com, ivan.malov@oktetlabs.ru,
 ying.a.wang@intel.com, viacheslavo@nvidia.com, shirik@nvidia.com
References: <20210330075036.6579-2-rasland@nvidia.com>
 <20210404074552.24190-1-rasland@nvidia.com>
 <20210404074552.24190-2-rasland@nvidia.com> <20210408122956.GX1650@platinum>
 <20210429162917.GC21799@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <f6ce57a6-e152-03df-fcef-cb57615e9c67@oktetlabs.ru>
Date: Tue, 8 Jun 2021 15:13:06 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <20210429162917.GC21799@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add new ext hdr for gtp psc
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 4/29/21 7:29 PM, Tyler Retzlaff wrote:
> On Thu, Apr 08, 2021 at 02:29:56PM +0200, Olivier Matz wrote:
>> Hi Raslan,
>>
>>> +/**
>>> + * Optional extension for GTP with next_ext set to 0x85
>>> + * defined based on RFC 38415-g30.
>>> + */
>>> +__extension__
>>> +struct rte_gtp_psc_hdr {
>>> +	uint8_t ext_hdr_len; /**< PDU ext hdr len in multiples of 4 bytes */
>>> +	uint8_t type:4; /**< PDU type */
>>> +	uint8_t qmp:1; /**< Qos Monitoring Packet */
> 
> would it be a lot ot ask to have the structure defined using standard C
> instead of using compiler specific extensions?
> 

It is a valid request, but I'm afraid bit fields are used
in many-many core DPDK libraries. So, change of the approach
or at least direction for a new code should be discussed and
approved by techboard.