From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D54541C62; Sat, 11 Feb 2023 01:54:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEDA640E50; Sat, 11 Feb 2023 01:54:03 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2065.outbound.protection.outlook.com [40.107.243.65]) by mails.dpdk.org (Postfix) with ESMTP id 2C74540E0F; Sat, 11 Feb 2023 01:54:02 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jvSZkijYiW2zjRcvXxfkjyROlgYOKaq6xy/nj1nScjdBO8PZXDOX0Mbu4w4NgFyX+x6/Wq/YY6KqE0/asTuUO8Fj7Rqvs1+Le6n8L8X7ohnjcEaHK59XZDbFHxPurMuTIPC0Wb35cr/ywnnms4Q2E2Juil42dqFHSinnnev1XDhwhJTUTdmPGEjF5r8yuPFbFt+2Lslmh2cfkd7SWQ1V60FRWNLS55tIZ8W5GCM81el0j8oZZsWi0VambolzWkuUJDUSBVBuNBSqJQBWvCCIEN1qwyn0/qB64OBu03BnIAotQbe3wdFEHGQ1DV4Z4hzhaDVnyXUBiFs9XT7DaZNWow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ngnZHM0/lN/7fOOu7QRz9Fg8G1p0hD18NqRc/tyhAoU=; b=oglBXo6bC5uGbYNrj6V3iXfcUZcayEdn9+LQU585vj7RuoZjoyag3FjghQ9orsiqmoOArTX5Azji/512P+3RXOJE4Ba3COJXUk/Ytly6A20MMSBV2a8G9TsLYAD5wEJj677c1DRpUCDB+kK+o6t1Aza2HzC5K3FBtrf9nXUjCcbKi0A9UrZNS9mDQRin16Xl4Bfmpg+duJW7qgN3rCKX8D3HXnJvQIzthvc7X38T9hizzRarRLaki+rjEdWU35MXDk5MRImwZCyRjPu3rv+ICuOkf+U01LpF0KcXdFcotnuhHnbwXmn6wCFVikWdX/KBL0NOsdPJyAwg11Pyn7UYhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ngnZHM0/lN/7fOOu7QRz9Fg8G1p0hD18NqRc/tyhAoU=; b=aoZ9anXgilBNBXYzY5UrIwmjr0WmPnrw/HSPV0B2Ovs2/gnml4rIZaCMyQ4gzEYbZij4BSHFslAXCStxADpdEWbbgWRPlHYHwgJDVJ54wz2HsInMf2NlENGYCOCeNdOGjmHg8ZlasIKQwzCOD/Bk9YEcf1W458ipcDXsZGPyRtY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB5294.namprd12.prod.outlook.com (2603:10b6:5:39e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.22; Sat, 11 Feb 2023 00:53:57 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%8]) with mapi id 15.20.6086.021; Sat, 11 Feb 2023 00:53:56 +0000 Message-ID: Date: Sat, 11 Feb 2023 00:53:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] net/nfp: fix length comparison for max DMA length Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, Richard Donkin , stable@dpdk.org References: <20230203022328.15674-1-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <20230203022328.15674-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP123CA0001.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB5294:EE_ X-MS-Office365-Filtering-Correlation-Id: 30e1ccb4-b4a5-446c-d7ac-08db0bca7450 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X4m0VXp+LRsFf4idnXSaLeR5j7ZRzc+LGrTqxBqqsuemUCAx/CFvrBxXwGrhd9gJu737o0CShrRYWFTukiahftkK6vPPr2m5y1e0yuhwPTahGqY7QfrMrS+SNU1UniOZ8KMUJWSPDPZKRkxaiaq0NFGXfqpcEaXfdLXAAn//nX8Y/cYPNFHWzrpoZHEGq/4tilMJgbZRGqoQz1bajkmwU1PXOUrZppMAPWnzCKIelqaBvV9AZ8nKAMoFA/VVK5yUEfhavvz5jG+MQOwRrWryL4CYmZ4RRAgckdvkHJkdjaF8WebzmPoG+3WSRFqu/XSWj0kPP7UD+3diyrxpQ7oiLeLTodrOydrgEG3eWb96LvESGuc+TdyB985zV3Fykecg0v48q603pUJfc6LAPi0mb5MTYjsz86/1BfvyBxpQeHE6K/pQwHTqE6A0D1BgS37s0YKBRWVz4TNdsC+gRXo9A7yzSjCZSt6v6tUitr0NP0VIXYQ0CHl598RKNBxwvOOooRsrphhExfhmNN47t1D/BVjgjj9sB2n4rCUkFMvuj8VR5AlfgKNgtmTr1hUmDdBIPjG1floK33D1nCBl+IZWaMQYl6sWfsO2vJGfVOLds76IY93T3FWn0+RW7hikOcrxaS54ac6apy3B3X3YyrY3Hmkm4QJXBOooMx7Jy2y4zdHlPurp1U3yjew4wKbRnnuRcuBoEllg5t3lwYE0VXVd3DhOc3lxR2yLFwNB/96IYSU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(39860400002)(396003)(376002)(366004)(136003)(451199018)(6512007)(186003)(26005)(2616005)(6486002)(478600001)(66946007)(66556008)(66476007)(83380400001)(6506007)(53546011)(6666004)(8676002)(4326008)(8936002)(5660300002)(4744005)(44832011)(2906002)(41300700001)(38100700002)(36756003)(31696002)(86362001)(31686004)(316002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NU15b0YwSWdCekVtS0plUDl4TlBPMVF3UlJhSXF3ajdkcUhEMWQyVTJaSHUy?= =?utf-8?B?a29ndkpxdFc3Q0lGd0gxeXlvaGkyb1V3V01KVE9YdHNDVmdySVdocWRSOFg0?= =?utf-8?B?bC82NlJlYVljMlQ5OXJ3RFVldnIySW1FSm8wL2FkbU5KSUpiYzl5di8yNS9j?= =?utf-8?B?WjhGdGlUMXg1VWxZaFp4QVpIMks5VlhQNmNMV2c3WTNNbDVIb2kyTFBIZWFF?= =?utf-8?B?Y2k4K05KYldxUTJDWEZxYzYvY1IwYWNDNVMvY2hwR0djSW5jT2xHN05DSXQx?= =?utf-8?B?ZFQzTkxlRWt1RTA3R1pRWE55a3RlUHBpSjdINVVkb1BZem9NZ0Nkb2xwL2ha?= =?utf-8?B?amo1Yk5OT2x1WXkxK1YwZ1hTOXNhU082K0FpQXV5SW5ldjFFQTU5b3g1ZWl4?= =?utf-8?B?MTBrZEhUdFEwUTZlYTEyYmpQUEJDTTJ1TURXVi9pN25FMmRNM0x2c2phQzVj?= =?utf-8?B?V0JYS08zSE56Q0liT3dPdzV3dkp1bW9aVE1zRTlSU0UxQ09DenUxMmJjZmJC?= =?utf-8?B?M3A0OTFiMklhdUloL2FWTVg0UWgxNkZuOWlGQllCL2JLcDdGL2VoOG91L3F5?= =?utf-8?B?VlNVZEMvdGVTMU4xaG5sUjNBMkFTenZIQitmSnFCaE41SWRQVHN6WU91K0VC?= =?utf-8?B?NmxjR20zMkRDTlRIcE5PVEFseXUvUFkrYWg4bWRxaTYxU2dPMktRSGdXNFNV?= =?utf-8?B?NjA3ZmNtd0pSRGFiT2x1WUFEQTNsZWNDU1doTGFnR3ZBSk9LUGxFNlBUWmtz?= =?utf-8?B?WnVBVVRnWWZOWUkzMlp2V090TnJ1LzZWZ3NGNXR1OHVJMXN1VTNYNytmQWNY?= =?utf-8?B?TFVLNldPcjBscnNJeVZ5RkFaaE96OTlOT045S0V3Y3VLOHl1VEdNZW9XVjFI?= =?utf-8?B?ZnZSeXEzWTEwK0hqSVE3SWk0OWhPeFRLVHNqaDRIOTJMOTd1UnEwOXZpYnNq?= =?utf-8?B?Vkk0T3BQb0o1em9CMlludkVUR204SFA2aVNDdEgzNG9hSEhmQUVDSTFBUzJW?= =?utf-8?B?WHUrbmdsUVJidTN4ZGlNWmtVaEZEYmpyZWt4eGFmbTNCVmd0ZGhDTGpKRXZQ?= =?utf-8?B?VzRTTnc1MkhsU0pmKzZKRDFoanJIb0hkMkswRURCTjVyaXErWmFiakN5V2JK?= =?utf-8?B?ajRYb2FycENpbTlYOWxaSkU4TEZML2thV0hBcUxUUk53WFI3L3BERmZSaXRr?= =?utf-8?B?S3lLQ0J6ck93L0VHeGxaTEVRTXZPVjlqTCtLMTlGK2t6VzZFYmNodElnY1hj?= =?utf-8?B?MlFUMytkTmY0MHFJUUwyWTlxUXlqV2tzWjNLcHkybGd1cW5Ndlc2TmRJNUtp?= =?utf-8?B?RUdRblNFTU0rQmxzYmhXb01hYkNBaEZxMlI3aTJaYlVzY3l2WHZRd0xRNUVY?= =?utf-8?B?VEVodkJSSjN2WkFWL2RSRG9NZU1veXpmUDE4TEl1a1pPbzBNY1YxSDNZSjE1?= =?utf-8?B?eTNKbWM4RVVkMHBnMFQybk9wdkl1eGJNKzdYeEtFN2NtTUhzV0t1cDI4RFVY?= =?utf-8?B?TmxQbXFpN2VqTi84dVArYU14VlZONzUzWXdCajNvdnFtMDZZQjZocEdocm1P?= =?utf-8?B?ZnpSSTROdGJsYk80STRSb1NNUFdTSG1lQTRpM05pY3BkWFdxcGMrWDd2T0d6?= =?utf-8?B?Q1o2NCtVUEl4NjlDZHQ2UGIyZHZCQk13L2lHbVZiZVZXdVo2UFlOVGUxRUFo?= =?utf-8?B?cE01QTJ3cHZhTWxHa281cUp5dk9pSjAvOWs4eFdLUkNLUit0L256NkgrZmRa?= =?utf-8?B?WFA2M2JibXAvaWVRczFXWGlBVTE4QTJLa3UxQ0prYWdzMDN1U3JISGgxRldQ?= =?utf-8?B?K0RnTG5ZRmRYczlnSUxDNWFmMFA3NzUvbjdQWXlCemFDb2kxOExEV2Z5OVk5?= =?utf-8?B?SmtHQjRaZVh2VG5GdzF0MHc0S1hrZk5SVk9mYnlYdVNDcEd2YXFtaUE5NjQ3?= =?utf-8?B?d3BKcFdtZDdnUHF6aTM4V0JuYkY1eHI3OEJ4ZU9UMldWN0YzWWpDa0h4V0N3?= =?utf-8?B?a3JpTlJ3ckdpN09ZNU5SNklQMWEvTm5hR3FHVnFJMGRVSVA1NkxYRExNSEx1?= =?utf-8?B?K3lVaUh2QlRHUlZmV2Y3MERjNkQrc2JuYTFKamUvRjZ3NDQ1ZXdkUHorZ20r?= =?utf-8?Q?L6zAsZvJQ+MaAvNRL9TPZY+/M?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30e1ccb4-b4a5-446c-d7ac-08db0bca7450 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2023 00:53:56.8779 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kaoVDjdtFGDhcUQOZnmqeFtVNFCdsKxYNMtmncX0OiC6rjRlSMH3FcQOz68pybck X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5294 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/3/2023 2:23 AM, Chaoyong He wrote: > From: Richard Donkin > > The DMA transfer length is allowed to be as large as > NFDK_TX_MAX_DATA_PER_HEAD. The existing check would not allow a simple- > type descriptor to be created for a packet of size > NFDK_TX_MAX_DATA_PER_HEAD, but it would also not enable gather-type > descriptors to be created correctly later. > > Change the limit of simple-type descriptors to include packets of size > NFDK_TX_MAX_DATA_PER_HEAD. > > In practice this fixes traffic with packets of size 4096. Previously > such packets would not be transmitted correctly. > > Fixes: c73dced48c8c ("net/nfp: add NFDk Tx") > Cc: stable@dpdk.org > > Signed-off-by: Richard Donkin > Reviewed-by: Chaoyong He Applied to dpdk-next-net/main, thanks.