From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB24242C4D; Wed, 7 Jun 2023 13:36:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCE35410F9; Wed, 7 Jun 2023 13:36:28 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2058.outbound.protection.outlook.com [40.107.220.58]) by mails.dpdk.org (Postfix) with ESMTP id 8CE57410F2 for ; Wed, 7 Jun 2023 13:36:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ze2gGmb7/sdZE4K1dhEBfpOq8cx6U8RgscJOGUTSnjct6jvKmiIbleRH5zcHM83lBnOMsRhxiRwOg3u6l+rfEW/X9Kv5fR867MThLtRMvKx7E6plPS7sowwW4Ujfm5hglDld6ElsgtL5N2huVigpXkbBmhKum1oDReKI5+24ov0h2SCIXQLi2IPN74hZRhACWDq2Ls2qVp+e2dDO0S43egYhX+BFqqM4AQ/kpfZ5JqWTVSVcIrCRNi3b6GuPEwKXq4jZLFC+l8IU021maiYxm8dOmphOX5KGTvqdvrbhrq3PGcEwL5bk3QQ1dahhrW6LabVKbPs8vGVPieE1OyLjpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eEEXITeDUe0EwOumvPuurmrVvQIM2iuW6iXlNjFBGOw=; b=QuAQi/pW0slSBwrP0V4Zb6TQ/QJp45XekpJbivGit7SldBgG7X3ZbRBPVqBFq5vy1Q3UWIZsD2mER9ytsyoLcfBp45E6fD+aw+uzwDv76RRunY58VA+AZSHHjHBdOntQj5Y1q6aKYvO9uQr9/AF+9zXR8Z+ft+l9lKLhyqyVEuAw1292sjGs9b5MmaXCo4Dwa/eEVswCzHA3Y2XpW8XwapsJGPp9PIgVbqAxvHvvBwF3qt3cNN7AYTjiPDuGMr9z3xogqadtUqcD99b7dAPOc+lTifkL8z5gozHlrOtaRLL/Q9QFhuMm/B82FiXZLhBqmyXNs3RvfteROgU3xnB9Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eEEXITeDUe0EwOumvPuurmrVvQIM2iuW6iXlNjFBGOw=; b=nbTtu/5oKq7+aU8skpIlDWU7djU5d95lu+pvX1bnM+Ge8f6lU0q0UvAGy3TMVujNeMfOzKnaYjMdhGkwrbl9f9rgFm64ZSP31TXhoikrnaJkY3XgMZMldE1XQ5T5lxTnS77YOXXY2yzt+a/0djkniHi0a7KxuzZ6zfu4ShfeQDI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by PH8PR12MB6914.namprd12.prod.outlook.com (2603:10b6:510:1cb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.36; Wed, 7 Jun 2023 11:36:24 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::3b9d:9ac6:f3ce:e106]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::3b9d:9ac6:f3ce:e106%3]) with mapi id 15.20.6455.034; Wed, 7 Jun 2023 11:36:23 +0000 Message-ID: Date: Wed, 7 Jun 2023 12:35:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Jie Hai , Thomas Monjalon , Andrew Rybchenko , =?UTF-8?Q?Morten_Br=c3=b8rup?= , Chengwen Feng Cc: dev@dpdk.org, liudongdong3@huawei.com References: <20230530090510.56812-1-haijie1@huawei.com> <20230607074209.4798-1-haijie1@huawei.com> <20230607074209.4798-2-haijie1@huawei.com> From: Ferruh Yigit Subject: Re: [PATCH v2 01/13] ethdev: fix incorrect argument of calloc In-Reply-To: <20230607074209.4798-2-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0193.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::7) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|PH8PR12MB6914:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d9c354a-8325-41da-8d80-08db674b6bc8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vEsv7PRVPLsaFOJePQ/b70A3o2x0glOTpWGzp2FhUlz0sM6XtqtVs2lmUQucE9dc1Y/MmMZQ1CzpnBRsE56p9V8pSyDgMFOgnK1sZ7BwLBpIBh6M3YzIOnDvZxlg0AiOpSM3pKJ6bkFnca+4j6h5PaPKl8BYlvVbEc5yk9ZG8L7pG9ixOnho4R8Rk63Cezj6m8zesepEIVM25hvbVB/vTUN6K0NbxLjSxdetWdfJRDyn7wesL5P4173gIfzHswCNTDzuVv6rHy0FkYST/w5QPDfwtCkY9aL7AsA3VtoxJ392qETcanBk2xxCJwOotuPO8G2L1/l/yWpQTeRD0Q+6akMVNSte1WQ1thL9xgY8b5zzHN0nMGBMf+M4OK6FE8aoAWY0hGkZoXCCTZn6mw5nxV4/kmoDEOQodSkWxGDktBtrn9zugGtc2zxxKVaejklXEa1uy+hmWZTp1GyMOAkrNGdgvmnEuPBR1/DjF38M8w0w4J9y3N3HOJr2jGx/KrBGnGKvTcWnCC7HmZEqhuknvR2UhWp1I27tjTPT5fNxCgdVXzuIOd31YAybgbz96/8fys/4JIXi9LVgreGb9UCRRpHYoX1v+riHLfaUcgJRDPbGQGCpvt93MgKOf4uNZk/bsPhXl3e3ZkKFEG+nQucGkA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(366004)(376002)(346002)(136003)(451199021)(36756003)(41300700001)(186003)(26005)(6512007)(6506007)(53546011)(5660300002)(83380400001)(2616005)(8676002)(8936002)(110136005)(478600001)(66946007)(66556008)(66476007)(4326008)(316002)(6486002)(38100700002)(2906002)(4744005)(86362001)(31696002)(44832011)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1ZkcTFpMzlCdERwZXNOQ2tBc00rOTJYZFJ4NHBTa3hPWnNlRlhLd0tYNWR2?= =?utf-8?B?M2h3YmtaVUJjd1dXK2g3RktFZFFXWmdFMnl6TWFoRXdQSFMwU0FJUS93Zkh3?= =?utf-8?B?YVFlcEtNcWM1cEpqNW81NXM1SFhoZVVLN1A0SWlON2RHSGViSVhHeUc4WFoz?= =?utf-8?B?NnhieXVGUjRYTE5sekovRTBSemJObllZVDJRbnVLM2Iwb2ZNZ0xZZmY3VWlW?= =?utf-8?B?NzVpTk9UQmFJWDdFS2p5R1JQVjRYRk43bHZUckZMVFF2eTlBNFpwRnBXbzM3?= =?utf-8?B?bisySUN4cXdML3hueXgzUFdSYmVTU1lQYVpJVzhWN1RUK1I0N2dnRklTQmpX?= =?utf-8?B?aDFKYzVxeTdzaTM1SzFSWlNTbmIyNXhyTVNiUmI2Zk0wYnlQdlhaZVZiV0Jk?= =?utf-8?B?cCtOdXRUR2ZKYXVScjI5MVlkZ1RXU2U1TXljd3pBU1BoOEVDYlVETzA0MXFD?= =?utf-8?B?MjhWam45REd6UDNEQVByZFc2YjRmMDZ2VDJCYVV2YlJCY3lTcmQ0MFlkNmxs?= =?utf-8?B?QlZtVUNzekhZS1VuQkJRUDdaaE0zY0VJeTg3MHp4YVk0Vnkwd1kxOEpOZ3p0?= =?utf-8?B?SGNEZS9GQ01OOU9IUzU5ZHhSRjdueDNwVGlvaEZkbk5NdmFpTlZiRSs2eW1z?= =?utf-8?B?NTVGMG10SEo0U1Q2QkVneGdTV2hReXhxbkVoNUl0TnhpVFV3NUQ0YUszRDlw?= =?utf-8?B?Sjh0V1dObC9KZ2g5UDZVMDdFZ3dmcjFZaHJlMHh0TGoxczlQOGxUS05KUlg2?= =?utf-8?B?TzN6c2lRYTBWNEM4aU0rWk5zcWppUktwejd6V0ZtMHBXZW02akhTYmNZM2lj?= =?utf-8?B?N1FYMXF1c3B0bGtSMytWMDd4NkhieEYvM2ZNRmVTbE5iWWtXNjJBajZSNzFJ?= =?utf-8?B?WXZGbXRHUXhlYWhBKzhjSkh4d0FPRjV1cGR5ZUFkK0EvUXZnOGRSVGFGVkJO?= =?utf-8?B?RkpSQ2liZTdHQklCTFEwWVRBdElhM3Y2MUtxYWdKc3ZTdHZreWIyUjNUeVh1?= =?utf-8?B?RloxYXJ0N2NRZ1MvWFFETXloU2VXSlg4TkFjQ2xaRVUwR2Z4YnpsVWxZQnov?= =?utf-8?B?eHJtNGkxeTlrd2hka0I1R1VNaytQQ3BnSUlaQm5pY2V2bnV0UklUU0tVTmdj?= =?utf-8?B?cWVHT1JvdmJqUWduRkxMS3ZkN3ArUW1XbzRjVCtYNnFNbGtiYlpneTF0Wnkz?= =?utf-8?B?MHJzU2JDV0J2UjJDdit5cmZ3b2xhdzFxdE93VUxwbElBL0VrSTU2eGEzc282?= =?utf-8?B?cDI1SVhyV3JlR1hyOFEvdVprSTk4a2loQlZKMGV3M3VHWGd1WDZSWlovSUdR?= =?utf-8?B?K0tvWkdEbVk2a3VUMXdxZ0Y4bDd4dDltWE9GQmlSWXVTOUFLZTNkUDhHSXph?= =?utf-8?B?QVJJcG1mL1BGMmNCeXQwY1U5dVBZYjFNUUNjbjVLNXVDcEk3ZDc5ZXFmZTg4?= =?utf-8?B?VHMrcGJPamwyWjVGRGRLR3k3V04ycFArU2I5ZHB0SkdLZW9tK1p2RzdkWVVE?= =?utf-8?B?Y0Fva2xHMXhFYmlQazhub2xocXJTcDdzMURYeHVFY1ZRN2x0aXVJSWNYN0RY?= =?utf-8?B?YmViOGUzN0dMWStuV2hHRlU3QXY2Z2xCemQ0R3EvR3Zac09mODlqUlZjUndZ?= =?utf-8?B?MDdNMmZFV2RVNE1oTVNqYVNIU0toSGlmR3dqaXYxK2hSRy90N1BpSThSZTFj?= =?utf-8?B?alU3aTVvQjNrRytzSEZHTllwUi9GSElaZW5EakFRdkw2YS9HcU1JWk80bkhh?= =?utf-8?B?aUprKzZwOWp1Qm5UazMyTGdpYVkzRFRXcFRpNkU1REYrS3dLTmszM0dJVmRz?= =?utf-8?B?OFVyanVvdkJwZlVOOXV6SU9YNUN6alBxWnNHK3RTVVp3Q3JwWlpHOEpXSTZV?= =?utf-8?B?YjdMSGd3ODJMS1A0TUkxa0tXTXd0OElmS2xJZWdEdXRWZWVwTjRmcUVLZVVZ?= =?utf-8?B?bit1R0VVVXpUbkJmaUVhRmk1QWRQczZZRlZjME1YMFEzL25QeU8za051dkl4?= =?utf-8?B?dlV1aVFDa1FOWDk5Z29zM3FZdDZwd0JvU29wa2dOYmZKNVJpMWtDckVBd3g0?= =?utf-8?B?cUQ4R3E0Rll4U2lhUWhCZGJWRWJlZEVxdEd6cjBycE9RdDYyNmVUMnZSUjc5?= =?utf-8?Q?uTmUQWPa+ob18WGh/HLlJ42Pr?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d9c354a-8325-41da-8d80-08db674b6bc8 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 11:36:23.4299 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8uFY8gAltrvpBAtD9A2acEqWJaKOdmbAdvG5UkVrHZ6S2jkJlptnVRphuj/7Brzb X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6914 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/7/2023 8:41 AM, Jie Hai wrote: > The 'calloc' uses number as first argument, sizeof is generally wrong. > This patch fixes it. > > Fixes: 8af559f94cef ("ethdev: support telemetry private dump") > Cc: stable@dpdk.org > > Signed-off-by: Jie Hai > --- > lib/ethdev/rte_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > index d46e74504e64..503d500429c0 100644 > --- a/lib/ethdev/rte_ethdev.c > +++ b/lib/ethdev/rte_ethdev.c > @@ -6548,7 +6548,7 @@ eth_dev_handle_port_dump_priv(const char *cmd __rte_unused, > if (!rte_eth_dev_is_valid_port(port_id)) > return -EINVAL; > > - buf = calloc(sizeof(char), RTE_TEL_MAX_SINGLE_STRING_LEN); > + buf = calloc(RTE_TEL_MAX_SINGLE_STRING_LEN, sizeof(char)); > if (buf == NULL) > return -ENOMEM; > Functionality should be same, but there is no harm to fix, hence: Acked-by: Ferruh Yigit