From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 68D1E29C7 for ; Wed, 5 Apr 2017 14:06:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491394015; x=1522930015; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=hGYuVvpfegJceEN9tBDgUWZr4AE2vUPvMOLX9NKN4rw=; b=SwoCjLOBrdmSQrhxq8miiRTCzfo9wRbtCL9cAacN/3UC3h+/INgZhsXz JP2Sns1EWqVfnxX4z0gF8wtLm3xVEg==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2017 05:06:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,278,1486454400"; d="scan'208";a="85002581" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 05 Apr 2017 05:06:51 -0700 To: nelio.laranjeiro@6wind.com, Adrien Mazarguil References: <1488966121-22853-1-git-send-email-olivier.matz@6wind.com> <20170404162807.20157-1-olivier.matz@6wind.com> <2948467.vjfs1XSdfO@xps13> Cc: Thomas Monjalon , Olivier Matz , dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com, mb@smartsharesystems.com, andrey.chilikin@intel.com, jblunck@infradead.org, arybchenko@solarflare.com, jerin.jacob@caviumnetworks.com From: Ferruh Yigit Message-ID: Date: Wed, 5 Apr 2017 13:06:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <2948467.vjfs1XSdfO@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 0/8] mbuf: structure reorganization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 12:06:55 -0000 On 4/5/2017 10:37 AM, Thomas Monjalon wrote: > 2017-04-04 18:27, Olivier Matz: >> Based on discussions done in [1] and in this thread, this patchset reorganizes >> the mbuf. >> >> The main changes are: >> - reorder structure to increase vector performance on some non-ia >> platforms. >> - add a 64bits timestamp field in the 1st cache line. This timestamp >> is not normalized, i.e. no unit or time reference is enforced. A >> library may be added to do this job in the future. >> - m->next, m->nb_segs, and m->refcnt are always initialized for mbufs >> in the pool, avoiding the need of setting m->next (located in the >> 2nd cache line) in the Rx path for mono-segment packets. >> - change port and nb_segs to 16 bits >> - move seqn in the 2nd cache line > > Applied, thanks for the long work Hi Nelio, Adrien, After this patch, mlx5 with debug enabled giving following build error [1] with gcc, not really sure about reason of the error, can you please check? [1] .../drivers/net/mlx5/mlx5_rxtx.c: In function ‘mlx5_rx_burst’: .../drivers/net/mlx5/mlx5_rxtx.c:2082:17: error: ‘len’ may be used uninitialized in this function [-Werror=maybe-uninitialized] DATA_LEN(seg) = len;