From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA30BA00C5; Thu, 4 Jun 2020 14:22:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CF5891D5D0; Thu, 4 Jun 2020 14:22:52 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id CE7C91D5C7 for ; Thu, 4 Jun 2020 14:22:50 +0200 (CEST) IronPort-SDR: M8DNCHUOFcC7xnsyHGfKN1a8Kt94Mh+bRkKUkbRWguxy4kz2PqkLjHH2DGF//PFadUWVifxc+d /JQ4+8BDGs+A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2020 05:22:49 -0700 IronPort-SDR: th4ZTQ0grdI8llamitUqQYv6/+BryA9uDLO5Yl4VQMn2wOV1miJEcvPCrtrFnyw6QdSL93Jm0i g7u2+MI263RQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,472,1583222400"; d="scan'208";a="471512903" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.233.208]) ([10.213.233.208]) by fmsmga005.fm.intel.com with ESMTP; 04 Jun 2020 05:22:48 -0700 To: =?UTF-8?Q?Juraj_Linke=c5=a1?= , Thomas Monjalon Cc: "arybchenko@solarflare.com" , "dev@dpdk.org" , Honnappa Nagarahalli References: <1591177738-32338-1-git-send-email-juraj.linkes@pantheon.tech> <2931549.x8W8VkzX4A@thomas> <22f0804e528042df8a4d5f32e0be4953@pantheon.tech> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: Date: Thu, 4 Jun 2020 13:22:47 +0100 MIME-Version: 1.0 In-Reply-To: <22f0804e528042df8a4d5f32e0be4953@pantheon.tech> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] ethdev: fix dpdk gcc build on Arm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/4/2020 11:36 AM, Juraj Linkeš wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Wednesday, June 3, 2020 1:41 PM >> To: Thomas Monjalon ; Juraj Linkeš >> >> Cc: arybchenko@solarflare.com; dev@dpdk.org >> Subject: Re: [PATCH] ethdev: fix dpdk gcc build on Arm >> >> On 6/3/2020 11:16 AM, Thomas Monjalon wrote: >>> 03/06/2020 11:48, Juraj Linkeš: >>>> Directive #include in gcc implementation searches for files in >>>> a standard list of system directories, which leads to a sporadici >>>> build error on Taishan arm machines: >>>> /tmp/openvpp-testing/dpdk/lib/librte_ethdev/rte_ethdev.h:4287:10: >>>> fatal error: rte_ethdev_core.h: >>>> No such file or directory #include >>> >>> Would be interesting to know why nobody else hit such error? >> >> >> I can't see why this is happening, in the 'mk/rte.lib.mk' we have following: >> >> " >> install: _preinstall build _postinstall >> build: _preinstall >> " >> >> Which should cause the library header files installed before building .c files in >> that library. >> So when compiling 'rte_class_eth.c', the header files should be already in install >> folder. >> >> >> I can see how/why changing to "" fixes the issue but I am not sure about this fix. >> "rte_ethdev.h" is a public header file, that applications will include it in their >> applications. In the public library it is more proper to have other includes from >> system folder, using format <>. >> Again, I can't see why it is failing but I believe we should find another solution >> for _internal_ build error. >> >> >> A very simple solution can be following, but that is also not good, since it solves >> the issue by creating a dependency to the order of the header includes: >> diff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_ethdev/rte_class_eth.c >> index 6338355e25..3030c49020 100644 >> --- a/lib/librte_ethdev/rte_class_eth.c >> +++ b/lib/librte_ethdev/rte_class_eth.c >> @@ -10,8 +10,8 @@ >> #include >> #include >> >> -#include "rte_ethdev.h" >> #include "rte_ethdev_core.h" >> +#include "rte_ethdev.h" >> #include "rte_ethdev_driver.h" >> #include "ethdev_private.h" >> > > Thomas, Ferruh, what should be the solution? I'm not an expert on this and I can't really offer anything better, but I'd like that this gets fixed. First we need to root cause this before trying to solve it. Honnappa also said he can reproduce this but our CI builds can't (we are talking about tens of builds daily on various platforms), need to understand why. Also from Makefile I can't see how this is happening, I am feeling uneasy to fix something before figuring out how/why it is failing. Can you please try to collect more data on when/how this happens, initial questions I can think of: - Can you reproduce this with meson build? - Is it bare DPDK build, or build part of other project (I guess I saw fd.io on the link) - - If this is not bare DPDK build what changes has been done to build system? - Do you see this with fresh build (new clone) or rebuild of existing clone? - Can you confirm you have correct RTE_SDK and RTE_TARGET environment variables? - Can you please share your build command? Thanks, ferruh > >>> >>> >>>> Fix this by replacing the directive with #include "file" which >>>> searches for files first in the directory containing the current file >>>> and other directories only after that. >>>> >>>> Signed-off-by: Juraj Linkeš >>> >>> What about #include ? >>> >>> Except this, >>> Acked-by: Thomas Monjalon >>> >>> >>> I would change the title to be more generic (nothing specific to gcc or Arm >> here): >>> ethdev: fix local include >>> >>> It needs to be backported, so these lines are required: >>> Fixes: 7f0a669e7b04 ("ethdev: add allocation helper for virtual drivers") >>> Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers") >>> Fixes: ffc905f3b856 ("ethdev: separate driver APIs") >>> Fixes: 331c447ad913 ("ethdev: separate internal structures into own >> header") >>> Cc: stable@dpdk.org >>> >>> >>> >