From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C2F1A0A0C; Tue, 3 Aug 2021 00:50:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4806740E32; Tue, 3 Aug 2021 00:50:10 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mails.dpdk.org (Postfix) with ESMTP id 269A94069C for ; Tue, 3 Aug 2021 00:50:08 +0200 (CEST) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 172MX9Xh024651; Mon, 2 Aug 2021 18:50:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=Xe/z+poIKBwL+kMZZNdxVQZR3yZv5z7BR7xmfqM/OAo=; b=kfB6bLIr0SQqE8AbD8XYaqIqEQuaPTiSRJD795+yvmxkdGKcEdM/65qEtleCDG5QH5JD uMwrXlejjTl1GJb4AoF4usjfDh3zY7tY4jQ9Y6/PlTh3EC0uhVqbFFNeqUvrcAsAgrTo rYybH+5wPSqey09TCEgzo4UgVE1Wz5F5jIIqjpNcWs6Y3iLwg8ChNrMCU19hZiGIuJaQ bopVhaKd1DPAKtTntgeiRQRmnDLHOVJ8ORXaGcdlUg/ghzBOF2fXK1CtsuFHyNpyo/EU IphswpdFcvX+ZpWBjC5HTPH2PubZIfXczCUmaBLGbKFa5tD0Ap7lT3hiha/fWJxBMc26 rw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3a5kkdh9f5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Aug 2021 18:50:05 -0400 Received: from m0098393.ppops.net (m0098393.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 172MYBYJ026868; Mon, 2 Aug 2021 18:50:05 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 3a5kkdh9ej-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Aug 2021 18:50:05 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 172MhNK9001758; Mon, 2 Aug 2021 22:50:04 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma01dal.us.ibm.com with ESMTP id 3a4x5c06qk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Aug 2021 22:50:04 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 172MnpxR11076282 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 2 Aug 2021 22:49:51 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6076F12405C; Mon, 2 Aug 2021 22:49:51 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D6D3F124054; Mon, 2 Aug 2021 22:49:49 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.211.121.80]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 2 Aug 2021 22:49:49 +0000 (GMT) To: jerinj@marvell.com, dev@dpdk.org Cc: thomas@monjalon.net, david.marchand@redhat.com, bruce.richardson@intel.com, dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, konstantin.ananyev@intel.com, ruifeng.wang@arm.com, viktorin@rehivetech.com References: <20210730084938.2426128-1-jerinj@marvell.com> <20210730084938.2426128-6-jerinj@marvell.com> From: David Christensen Message-ID: Date: Mon, 2 Aug 2021 15:49:49 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210730084938.2426128-6-jerinj@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: GAVI1w2l6Bk_wCANpNnXeyow6rMe2Nss X-Proofpoint-ORIG-GUID: QhjfZE8l1QxHzyrbJhEfIXRzytUhx3TJ X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-02_07:2021-08-02, 2021-08-02 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 mlxscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 adultscore=0 mlxlogscore=999 phishscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108020143 Subject: Re: [dpdk-dev] 5/6] eal/arm64: support register dump for oops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/30/21 1:49 AM, jerinj@marvell.com wrote: > From: Jerin Jacob > > Dump the arm64 arch state register in oops > handling routine. > > Signed-off-by: Jerin Jacob > --- > lib/eal/unix/eal_oops.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/lib/eal/unix/eal_oops.c b/lib/eal/unix/eal_oops.c > index da71481ade..7469610d96 100644 > --- a/lib/eal/unix/eal_oops.c > +++ b/lib/eal/unix/eal_oops.c > @@ -162,6 +162,25 @@ archinfo_dump(ucontext_t *uc) > stack_code_dump((void *)mc->gregs[REG_RSP], (void *)mc->gregs[REG_RIP]); > } > > +#elif defined(RTE_ARCH_ARM64) && defined(RTE_EXEC_ENV_LINUX) > + > +static void > +archinfo_dump(ucontext_t *uc) > +{ > + mcontext_t *mc = &uc->uc_mcontext; > + int i; > + > + oops_print("PC : 0x%.16llx", mc->pc); > + oops_print("SP : 0x%.16llx\n", mc->sp); > + for (i = 0; i < 31; i++) ~~~ Maybe <= instead of < ?? 31 is a strange number of registers and the line feed doesn't seem to line things up for PSTATEn below. > + oops_print("X%.2d: 0x%.16llx%s", i, mc->regs[i], > + i & 0x1 ? "\n" : " "); Dave