From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67038A00BE; Thu, 11 Jun 2020 20:54:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADD8DE07; Thu, 11 Jun 2020 20:54:07 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 6D600DE3 for ; Thu, 11 Jun 2020 20:54:06 +0200 (CEST) IronPort-SDR: oFQRrJKh64dZwmeJT8V8vP9Q7JRbb2sRevbJmACDfH9CHY+YNVoIZneD8b/L+VkhGTqw0pL8ax kuKyuGCzlxLQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 11:54:05 -0700 IronPort-SDR: oCqnmp2GQU0KDUAJF3Qh5lyl6QZZZkYOAciiqVGQAYnrWnItpIjTgO1vPUG+5sl0qtq6jOCSbP L1FnniM9M8cw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,500,1583222400"; d="scan'208";a="296691643" Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.254.36.106]) ([10.254.36.106]) by fmsmga004.fm.intel.com with ESMTP; 11 Jun 2020 11:54:04 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, tbashar@mellanox.com, Harini.Ramakrishnan@microsoft.com, bruce.richardson@intel.com References: <20200514203945.1484-1-pallavi.kadam@intel.com> <20200528231455.13636-1-pallavi.kadam@intel.com> <20200528231455.13636-3-pallavi.kadam@intel.com> <198987692.ZIs5KhJ6DU@thomas> From: "Kadam, Pallavi" Message-ID: Date: Thu, 11 Jun 2020 11:54:04 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <198987692.ZIs5KhJ6DU@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/2] build: treat warning as an error on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/11/2020 9:12 AM, Thomas Monjalon wrote: > 29/05/2020 01:14, Pallavi Kadam: >> Added -Werror in meson file to consider all the warnings >> as errors on Windows. >> >> Signed-off-by: Pallavi Kadam >> Reviewed-by: Ranjit Menon >> --- >> --- a/config/meson.build >> +++ b/config/meson.build >> +# add -Werror to treat warnings as errors on Windows >> +if is_windows >> + warning_flags += '-Werror' >> +endif > > This should be not needed. > When configuring meson in a CI, we are supposed to use > --werror as it is done in devtools/test-meson-builds.sh. > > > Ok, will fix this in v4.