DPDK patches and discussions
 help / color / Atom feed
From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: "Stillwell Jr, Paul M" <paul.m.stillwell.jr@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Ye, Xiaolong" <xiaolong.ye@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>
Cc: "Zhao1, Wei" <wei.zhao1@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support
Date: Sat, 14 Mar 2020 01:57:11 +0000
Message-ID: <f76729d04773456daaf9adf6300806c1@intel.com> (raw)
In-Reply-To: <MW3PR11MB453890644E94D4CACD5E833CE0FA0@MW3PR11MB4538.namprd11.prod.outlook.com>

> -----Original Message-----
> From: Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>
> Sent: Saturday, March 14, 2020 01:48
> To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: Zhao1, Wei <wei.zhao1@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support
> 
> OK, I looked at the code further and it seems like what you are doing is you are using the iavf PCI
> device ID instead of the PF device ID when the user says cap=dcf. This doesn't seem like the right
> thing to do.

No, how can you get the PF device ID from the VF hardware ? ;-)

> Why not modify the iavf code to support being the DCF? Or create a new PMD? You are
> calling iavf functions from within the ice PMD which seems wrong to me.

No, you still can't get my point about the ice rte_flow framework. Please see Wei's next patch 

https://patchwork.dpdk.org/patch/66621/ net/ice: enable switch flow on DCF

> 
> Paul
> 
> > -----Original Message-----
> > From: Wang, Haiyue <haiyue.wang@intel.com>
> > Sent: Friday, March 13, 2020 10:05 AM
> > To: Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>; dev@dpdk.org; Ye,
> > Xiaolong <xiaolong.ye@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> > Yang, Qiming <qiming.yang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> > Cc: Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support
> >
> > Hi Paul,
> >
> > > -----Original Message-----
> > > From: Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>
> > > Sent: Saturday, March 14, 2020 00:50
> > > To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org; Ye, Xiaolong
> > > <xiaolong.ye@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Yang,
> > > Qiming <qiming.yang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> > > Cc: Zhao1, Wei <wei.zhao1@intel.com>
> > > Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support
> > >
> > > Hi Haiyue,
> > >
> > > This statement is confusing to me "But the flow setting is the ice PF
> > > AdminQ message, so the DCF shares most of ice PMD flow control." What
> > do you mean by "flow setting"?
> >   It is DPDP rte_flow API calling.
> >
> > > The way I understand DCF
> > > working is that there is a trusted VF (the DCF) that is setting switch
> > > rules for other VFs on the same PF. The mechanism for doing that is
> > > the DCF sends a virtchnl message to the Linux kernel driver PF to
> >
> > DCF needs: 1). virtchnl message is handles by 'dpdk/drivers/common/iavf/',
> > which is the original iavf base code.
> >
> > > add/delete a switch rule. None of this requires the ice PMD as far as
> > > I can tell. This seems like a
> >
> > DCF needs: 2). add/delete a switch rule.
> >                rte_flow API -->
> > 'dpdk/drivers/net/ice/ice_switch_filter.c/ice_generic_flow.c' (ice flow
> > framework)
> >                      |
> >                                  `--> 'dpdk/drivers/net/ice/base' ...
> >
> > So, put it under the ice PMD is the best way.
> >
> > > driver just like the iavf driver; the iavf driver is separate from the
> > > ice PMD and it seems like DCF should also be separate.
> > >
> > > Paul
> > >
> > > > -----Original Message-----
> > > > From: Wang, Haiyue <haiyue.wang@intel.com>
> > > > Sent: Friday, March 13, 2020 9:25 AM
> > > > To: Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>;
> > > > dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>; Zhang, Qi Z
> > > > <qi.z.zhang@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Xing,
> > > > Beilei <beilei.xing@intel.com>
> > > > Cc: Zhao1, Wei <wei.zhao1@intel.com>
> > > > Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support
> > > >
> > > > Hi Paul,
> > > >
> > > > Yes, it's VF (VF hardware initialization like virtchnl). But the
> > > > flow setting is the ice PF AdminQ message, so the DCF shares most of ice
> > PMD flow control.
> > > >
> > > > BR,
> > > > Haiyue
> > > >
> > > > > -----Original Message-----
> > > > > From: Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>
> > > > > Sent: Saturday, March 14, 2020 00:19
> > > > > To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org; Ye,
> > > > > Xiaolong <xiaolong.ye@intel.com>; Zhang, Qi Z
> > > > > <qi.z.zhang@intel.com>; Yang, Qiming <qiming.yang@intel.com>;
> > > > > Xing, Beilei <beilei.xing@intel.com>
> > > > > Cc: Zhao1, Wei <wei.zhao1@intel.com>; Wang, Haiyue
> > > > > <haiyue.wang@intel.com>
> > > > > Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support
> > > > >
> > > > > I'm confused. Shouldn't the DCF be a separate driver since it is a
> > > > > VF, not part of a PF? You are starting to combine PF/VF code and
> > > > > I'm not sure if
> > > > that is the correct way to go.
> > > > >
> > > > > Paul
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: dev <dev-bounces@dpdk.org> On Behalf Of Haiyue Wang
> > > > > > Sent: Monday, March 9, 2020 11:50 PM
> > > > > > To: dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>; Zhang,
> > > > > > Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> > > > > > <qiming.yang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> > > > > > Cc: Zhao1, Wei <wei.zhao1@intel.com>; Wang, Haiyue
> > > > > > <haiyue.wang@intel.com>
> > > > > > Subject: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support
> > > > > >
> > > > > > A DCF (Device Config Function) based approach is proposed where
> > > > > > a device bound to the device's VF0 can act as a sole controlling
> > > > > > entity to exercise advance functionality (such as switch, ACL)
> > > > > > for rest of
> > > > the VFs.
> > > > > >
> > > > > > The DCF works as a standalone PMD to support this function,
> > > > > > which shares the ice PMD flow control core function and the iavf
> > > > > > virtchnl mailbox core module.
> > > > > >
> > > > > > This patchset is based on:
> > > > > > [1] https://patchwork.dpdk.org/cover/66417/ : update ice base
> > > > > > code [2] https://patchwork.dpdk.org/cover/66472/ : iavf share
> > > > > > code update
> > > > > >
> > > > > > Depends-on: series-8843
> > > > > > Depends-on: series-8855
> > > > > >
> > > > > > v2:
> > > > > >    1. update the iavf patchset link.
> > > > > >    2. split more patches for making this work be more understandable
> > > > > >    3. fix the log function usage, devargs checking from v1.
> > > > > >
> > > > > > Haiyue Wang (7):
> > > > > >   net/iavf: stop the PCI probe in DCF mode
> > > > > >   net/ice: add the DCF hardware initialization
> > > > > >   net/ice: initiate to acquire the DCF capability
> > > > > >   net/ice: handle the AdminQ command by DCF
> > > > > >   net/ice: export the DDP definition symbols
> > > > > >   net/ice: handle the PF initialization by DCF
> > > > > >   net/ice: get the VF hardware index in DCF
> > > > > >
> > > > > >  doc/guides/nics/ice.rst                |  47 ++
> > > > > >  doc/guides/nics/img/ice_dcf.png        | Bin 0 -> 39168 bytes
> > > > > >  doc/guides/rel_notes/release_20_05.rst |   5 +
> > > > > >  drivers/common/Makefile                |   1 +
> > > > > >  drivers/net/iavf/iavf_ethdev.c         |  43 ++
> > > > > >  drivers/net/ice/Makefile               |   6 +
> > > > > >  drivers/net/ice/ice_dcf.c              | 651
> > +++++++++++++++++++++++++
> > > > > >  drivers/net/ice/ice_dcf.h              |  61 +++
> > > > > >  drivers/net/ice/ice_dcf_ethdev.c       | 321 ++++++++++++
> > > > > >  drivers/net/ice/ice_dcf_ethdev.h       |  33 ++
> > > > > >  drivers/net/ice/ice_dcf_parent.c       | 344 +++++++++++++
> > > > > >  drivers/net/ice/ice_ethdev.c           |   9 +-
> > > > > >  drivers/net/ice/ice_ethdev.h           |   8 +
> > > > > >  drivers/net/ice/meson.build            |   8 +-
> > > > > >  mk/rte.app.mk                          |   1 +
> > > > > >  15 files changed, 1528 insertions(+), 10 deletions(-)  create
> > > > > > mode
> > > > > > 100644 doc/guides/nics/img/ice_dcf.png  create mode 100644
> > > > > > drivers/net/ice/ice_dcf.c  create mode 100644
> > > > > > drivers/net/ice/ice_dcf.h create mode 100644
> > > > > > drivers/net/ice/ice_dcf_ethdev.c  create mode 100644
> > > > > > drivers/net/ice/ice_dcf_ethdev.h  create mode 100644
> > > > > > drivers/net/ice/ice_dcf_parent.c
> > > > > >
> > > > > > --
> > > > > > 2.25.1
> > > > >
> > > >
> > >
> >
> 


  reply index

Thread overview: 94+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09 14:14 [dpdk-dev] [PATCH v1 0/4] " Haiyue Wang
2020-03-09 14:14 ` [dpdk-dev] [PATCH v1 1/4] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-09 15:38   ` Ye Xiaolong
2020-03-10  2:19     ` Wang, Haiyue
2020-03-10  3:37       ` Ye Xiaolong
2020-03-10  4:26         ` Wang, Haiyue
2020-03-23  1:50   ` Wu, Jingjing
2020-03-23  1:55     ` Wang, Haiyue
2020-03-09 14:14 ` [dpdk-dev] [PATCH v1 2/4] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-09 16:25   ` Ye Xiaolong
2020-03-09 14:14 ` [dpdk-dev] [PATCH v1 3/4] net/ice: add the DCF framework Haiyue Wang
2020-03-10  4:17   ` Ye Xiaolong
2020-03-10  5:09     ` Wang, Haiyue
2020-03-10  5:23       ` Ye Xiaolong
2020-03-09 14:14 ` [dpdk-dev] [PATCH v1 4/4] doc: add release notes for Intel ice PMD Haiyue Wang
2020-03-09 15:22   ` Ye Xiaolong
2020-03-10  2:16     ` Wang, Haiyue
2020-03-09 15:36 ` [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support David Marchand
2020-03-09 16:20   ` Ye Xiaolong
2020-03-09 17:57     ` Thomas Monjalon
2020-03-09 19:34       ` Kevin Traynor
2020-03-10  2:00         ` Wang, Haiyue
2020-03-10  7:48           ` Thomas Monjalon
2020-03-10  9:36             ` Ferruh Yigit
2020-03-10 14:11               ` Aaron Conole
2020-03-10 14:09   ` Aaron Conole
2020-03-10  6:50 ` [dpdk-dev] [PATCH v2 0/7] " Haiyue Wang
2020-03-10  6:50   ` [dpdk-dev] [PATCH v2 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-13  5:27     ` Ye Xiaolong
2020-03-10  6:50   ` [dpdk-dev] [PATCH v2 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-10  6:50   ` [dpdk-dev] [PATCH v2 3/7] net/ice: initiate to acquire the DCF capability Haiyue Wang
2020-03-13  5:51     ` Ye Xiaolong
2020-03-13  6:19       ` Wang, Haiyue
2020-03-13  6:04     ` Ye Xiaolong
2020-03-13  6:10       ` Wang, Haiyue
2020-03-10  6:50   ` [dpdk-dev] [PATCH v2 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-10  6:50   ` [dpdk-dev] [PATCH v2 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-10  6:50   ` [dpdk-dev] [PATCH v2 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-13  7:59     ` Ye Xiaolong
2020-03-13  8:03       ` Ye Xiaolong
2020-03-16  4:52       ` Wang, Haiyue
2020-03-13 14:06     ` Ye Xiaolong
2020-03-13 14:11       ` Wang, Haiyue
2020-03-10  6:50   ` [dpdk-dev] [PATCH v2 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-13  7:01     ` Ye Xiaolong
2020-03-16  5:58       ` Wang, Haiyue
2020-03-13 16:19   ` [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support Stillwell Jr, Paul M
2020-03-13 16:25     ` Wang, Haiyue
2020-03-13 16:50       ` Stillwell Jr, Paul M
2020-03-13 17:05         ` Wang, Haiyue
2020-03-13 17:47           ` Stillwell Jr, Paul M
2020-03-14  1:57             ` Wang, Haiyue [this message]
2020-03-15  1:49     ` Zhang, Qi Z
2020-03-16 18:54       ` Stillwell Jr, Paul M
2020-03-17  2:35         ` Wang, Haiyue
2020-03-16  5:52 ` [dpdk-dev] [PATCH v3 " Haiyue Wang
2020-03-16  5:52   ` [dpdk-dev] [PATCH v3 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-16  5:52   ` [dpdk-dev] [PATCH v3 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-16  5:52   ` [dpdk-dev] [PATCH v3 3/7] net/ice: acquire and disable the DCF capability Haiyue Wang
2020-03-16  5:52   ` [dpdk-dev] [PATCH v3 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-16  5:52   ` [dpdk-dev] [PATCH v3 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-16  5:52   ` [dpdk-dev] [PATCH v3 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-16  5:52   ` [dpdk-dev] [PATCH v3 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-26  3:03 ` [dpdk-dev] [PATCH v4 0/7] add Intel DCF PMD support Haiyue Wang
2020-03-26  3:03   ` [dpdk-dev] [PATCH v4 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-26  3:28     ` Wu, Jingjing
2020-03-26  3:03   ` [dpdk-dev] [PATCH v4 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-26  3:03   ` [dpdk-dev] [PATCH v4 3/7] net/ice: acquire and disable the DCF capability Haiyue Wang
2020-03-26  3:03   ` [dpdk-dev] [PATCH v4 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-26  3:03   ` [dpdk-dev] [PATCH v4 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-26  3:03   ` [dpdk-dev] [PATCH v4 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-26  3:03   ` [dpdk-dev] [PATCH v4 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-26  4:11   ` [dpdk-dev] [PATCH v4 0/7] add Intel DCF PMD support Zhang, Qi Z
2020-03-26  5:05   ` Ye Xiaolong
2020-03-26  5:26     ` Wang, Haiyue
2020-03-26  7:15 ` [dpdk-dev] [PATCH v5 " Haiyue Wang
2020-03-26  7:15   ` [dpdk-dev] [PATCH v5 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-26  7:15   ` [dpdk-dev] [PATCH v5 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-26  7:15   ` [dpdk-dev] [PATCH v5 3/7] net/ice: acquire and disable the DCF capability Haiyue Wang
2020-03-26  7:15   ` [dpdk-dev] [PATCH v5 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-26  7:15   ` [dpdk-dev] [PATCH v5 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-26  7:15   ` [dpdk-dev] [PATCH v5 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-26  7:15   ` [dpdk-dev] [PATCH v5 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-27  2:56 ` [dpdk-dev] [PATCH v6 0/7] add Intel DCF PMD support Haiyue Wang
2020-03-27  2:56   ` [dpdk-dev] [PATCH v6 1/7] net/iavf: stop the PCI probe in DCF mode Haiyue Wang
2020-03-27  2:56   ` [dpdk-dev] [PATCH v6 2/7] net/ice: add the DCF hardware initialization Haiyue Wang
2020-03-31  8:50     ` Ferruh Yigit
2020-03-31 12:17       ` Wang, Haiyue
2020-03-27  2:56   ` [dpdk-dev] [PATCH v6 3/7] net/ice: acquire and disable the DCF capability Haiyue Wang
2020-03-27  2:56   ` [dpdk-dev] [PATCH v6 4/7] net/ice: handle the AdminQ command by DCF Haiyue Wang
2020-03-27  2:56   ` [dpdk-dev] [PATCH v6 5/7] net/ice: export the DDP definition symbols Haiyue Wang
2020-03-27  2:56   ` [dpdk-dev] [PATCH v6 6/7] net/ice: handle the PF initialization by DCF Haiyue Wang
2020-03-27  2:56   ` [dpdk-dev] [PATCH v6 7/7] net/ice: get the VF hardware index in DCF Haiyue Wang
2020-03-27 15:26   ` [dpdk-dev] [PATCH v6 0/7] add Intel DCF PMD support Ye Xiaolong

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f76729d04773456daaf9adf6300806c1@intel.com \
    --to=haiyue.wang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=paul.m.stillwell.jr@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=wei.zhao1@intel.com \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox