From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A1D745B56; Thu, 17 Oct 2024 01:49:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 023774021F; Thu, 17 Oct 2024 01:49:28 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2045.outbound.protection.outlook.com [40.107.244.45]) by mails.dpdk.org (Postfix) with ESMTP id 59CED40144 for ; Thu, 17 Oct 2024 01:49:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ytlr0R5nCN12rDekpSHgFpOX10BLu+cOxHPjVafb+IJNWjgIkwwuw5KBr2Rf4YygferlZLvtiNQiWXQ5GWMyZaBCapvccq5Ce3zsGNe8Li3Jkg8bev2Xi4k7QoUWCleJ+3xGVhqfdyDTMBRBP9/t4A0x0RnD5hyESDRaVxpkBVkq8vNbp0FhJ+taPg3lEpr7zHHEmhw7G4ziXbW0sLx5H2vVLBTsmNJUplJFFTimyjy4UHXRe25GYKsiFxkf1l53Ben6uv5QKCrwebuOygkcxTouCWEr5Jfgu8iH/L1n1eQcrytTBEskIdbztQ7/spHf2jIlMBBk1bwt4FikE71YOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9L/7Gz/msiv4W6mtbCTOhB4HDctPmKseZy8a97q0lbM=; b=l/VCGOmMECPIKkv2xfGZU6fzCKKikDHUJ9lvSz+6tQrQ2mVjsk3ZnacDRPQoot/J6KcRSBP/0VU244+y3scHcnseri8Vu8ZL4wg0JiT7i5Jfl2nUcUDsUpMdXxWArYrwdLgPMmefP29uZ8DyxDP+ei9NbqrLW41S+KUzFp4Ze8uy67GERkSgf8fPF7Y9o7q/3chd/AbLtuTmcqlWL4IYfh89p4cvN7Huh9QIR3A9YzflSG4owkvlPypnC6xF2WxxoEfC3A9pLihwb4k+1sTNtQBpKU/fjx6oLG8ogJK8tTMk0E7QbUiEL0GPwZC6hC6DkR8YyxutLEnquhjVXzHLGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9L/7Gz/msiv4W6mtbCTOhB4HDctPmKseZy8a97q0lbM=; b=fsOOke2fY8ekB1HghGSCDkuAd3TxfHpdl9vTLFvRJMiH+g9JAl2bQSCqL1OBIMYVobcM2cO9C1MWGmFRIEIcwcUEFuQLb+IL2VkUwHwnsDjsjnIQfKyibKX0zSwJNHEDlOuosJl8lt1HC1TCi5C4w3ZFcXfYhoIaIKgJTv/1PsQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by MN0PR12MB5953.namprd12.prod.outlook.com (2603:10b6:208:37c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.18; Wed, 16 Oct 2024 23:49:21 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8048.020; Wed, 16 Oct 2024 23:49:21 +0000 Message-ID: Date: Thu, 17 Oct 2024 00:49:17 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v01] net/af_packet: don't specify protocol on socket create To: Gur Stavi Cc: dev@dpdk.org, "John W. Linville" References: Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0213.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::33) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|MN0PR12MB5953:EE_ X-MS-Office365-Filtering-Correlation-Id: b960282a-5517-475b-81ef-08dcee3d2851 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cVdVSitHZVJZanVZektWV3NiWXlxc3NxMGVpRnRBcm1ZOU5kSHBOT2RXV2VQ?= =?utf-8?B?RllBbmw1Z3ZxM09oZEVKbVd0aGljanhONWlndk9FKzlRb3lhNlF3WE5qdmVS?= =?utf-8?B?cWxSVnJHQm8wcm0rRG9WeU1uOHZlNE1ldGRaTnNCK0UxdUxCZzZzT3E4M3Jv?= =?utf-8?B?SGpWVU1WR3Fmck40MXM5WUtJbE4rNm4wTlYrc1FtVVRVWnd0YmJubmREU3JY?= =?utf-8?B?L1VBWXpHTm5rWFM0bUJ2SlVuVDdKVDI2SC9oNU4wdGErc29lWEtsMUNrbS8v?= =?utf-8?B?R0k4TjhmTGR0WjRZbzZzanQ2bWxiQ3F5KzhEYlhiSDFxQWVxRnpxZlZLdEEz?= =?utf-8?B?K1NPUEJHZkxlTURoT0luN2t1QmkzS2YxOXh1MUNWN0E0ZkJFMjJPU1FPM3FR?= =?utf-8?B?MDdaTXlwZ1llR2kreGczYU1oajI5MG9iM1o4UTUxQm41azRXOEFNbU1sMjN5?= =?utf-8?B?OExLelZhUHRpNmhmbDVQbjhZTG5PanVlVFR5ZHVDTjBTZmhKaU1zYXIwU0JR?= =?utf-8?B?NkFRZHFDdmdSbUFneFE5MklEdlIvZVAydFpXRDIwUXFIVk1HRzByT090TG44?= =?utf-8?B?NjNlNFdZVXNJTExoempETkN0VTB1cy9jTkZaSzhxakU2VmJEM2ZsWEYrUG13?= =?utf-8?B?YjQ0aEJTd1hQbkRvcW1OYlZ3OHJsZVpQbW8yUUZLTTdOanNRbVM5MmE2NXVl?= =?utf-8?B?eHRWNUgycHdEYWZMcXcvQ0d3b2ZHMkorNFdwZUFDUkdGWGhqOEdBdU9PVnYx?= =?utf-8?B?cVdFLy90RmIrTHU2eWN0MEtnQjBSOUd1V09OOVJEUkcrM2RHR0NSWDNaSWVG?= =?utf-8?B?V0NTZzc4ZUtHakRKTEJySTkxRHNQSFhiazFIWEdkUk1OUk9BSFlQNkpQYjRI?= =?utf-8?B?bng5M2NXbkI0aXVXZEtsZmNRZmZSbEwybENIcndxdVRWUUxyR0FHV1NGNnNm?= =?utf-8?B?anAxYkhGVUd5clFIVGU4bjVJRjZ2SU9jdlo2emwxTFVlcGdDRGVMYVJXU3Nm?= =?utf-8?B?RlZZZlg4Vngyb1l5eXdDYnc4NjBvRnprWXJWZ09IZ1l5akZzUURuRmJWa1NW?= =?utf-8?B?bGhqdnZIb2pvNlRpeVZWTlovSWMrMGU5UlFmU3ZEODkrYXFkejhLaktuWFlv?= =?utf-8?B?eEdpczZpUVFZSEVZUkl6bkFJVDZ3bUdORk1uTnZjc2JteW9HQkVGQkREbUNV?= =?utf-8?B?S0FrVmxGSGdtV1dpVkFhWE9id2poWUVackN5dmJzVUdiWmVGZzgwYWxJKyt4?= =?utf-8?B?YzRKQjhEdTFZdkhCQjdCdTBhTEpIMFhPYkZUV0UraVphamhxSXJzQWxPR1Qr?= =?utf-8?B?Y291Zzh1Sm9hTEJCa08wd20xNllCVHlpQ1Y0b01qK3BRa2V5bFFiblZVUnF0?= =?utf-8?B?ZlJDZ2hsbDVQSW01R2R4aXp5R0NNVUxiQ1pQS0FaSjdzREMwOStjVjFiTWpT?= =?utf-8?B?K3drS3kzQ2hsbUoyakxpQWxiUzU2WXFrbkFxMTljd2d0ZkxnTWgwZTJRT3BL?= =?utf-8?B?WktxWU1iM2ZSQlJJLzlxNlJDVkZDdWFpNUpVcktZZUQrQVZmTVJUV2NBSnhj?= =?utf-8?B?SVRqanBxbnFGTzh0L0t4bi9UVzVoVWlSUGJCY3U4VCswaDNncVM4ZHVFcjBR?= =?utf-8?B?VmlHWVhSYk9Rd3NVbUEwU2duRmRZaHFheUU0YWdBUHJyblcrRi91TXV4elpC?= =?utf-8?B?N3hSa2thMUJXdlZDOW0zdnpDVlBWTFRBblhWVFk3ald3MnFrbUJWT2VwM2Qw?= =?utf-8?Q?luvSjq/5IJn0p2A6PzB1sR5xRodwK/ZjmanZ7kT?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGlIbStRWmRJdXA3VUNaUTdpQ0JsU2dyd3ZBRVFURUhZQlV5ODg2cGFoeXBW?= =?utf-8?B?bm9ycmFqd3FkeTlYamdzaFpxeXFpOXR5VDYzcEVZdEEvWnZTbHA0N0VZOEhJ?= =?utf-8?B?aUlwNFBXVmE0RFBVVldnSmJ5YmdUeTY4cUh4RjdBQWthVGxwYk5XbHNqUjlq?= =?utf-8?B?UytFK0l4Tmt5SzNCN3lDb2pTZ1l1TmpsamNoK0tDOVV0TkhPMnhRYnNDTmpB?= =?utf-8?B?S3JNZ0thaFZTWlFQcWt6c1FRd3hoYnJ0V1dLcHZDRjhhRFI4UVhBOHlvYVVY?= =?utf-8?B?S1ExakNnR3ZTVmgyczRBeXpxNnJ5YmtEQ1R2eXUvM1oydzk5emZZVU50L2tM?= =?utf-8?B?eXJqMm9DVUwzV0N3dXQwTy9DaTl4QWlpY1FvTVdlcUEvZGN4SFBMUkJyNW95?= =?utf-8?B?cGJmdWpZSHVlYXppZEt4ZVFlRC9MZ0p1TTMxcGdmc2o5cHhIcGJzRjJPS2ZJ?= =?utf-8?B?U3NIQWxobjdIOUh2c3YwSkxyR2Uyc1Q1Z29IaGtlNFZGYjJxRmRKV0QrYmcz?= =?utf-8?B?ZHlIZllNV2I3Q1A0eUtoVXZQRHc2Yjh4bElCbXlOdmQwNGFvVUJCUDd2cElx?= =?utf-8?B?ZHlyMS80WnludWx3NWxoTHdwYUdDWWRZOTI2NFBxYTVHNzE3K3hRWHVuQ2xi?= =?utf-8?B?WWg0RkEwaVlKNEdYZm1BclRMQkJNcE9WSDBNOXV5YUVxbUtUbUhxbVBkbzhM?= =?utf-8?B?NHRzMkQvUExyaWRlZ2ZDVDZTZVlSa1kyK3FqNUhjd3piVjZsdSs0NWNKM0ZB?= =?utf-8?B?emswaXArQjVhWUR6dERYeFF1c2Yvd21xSUpBNXA1U3Q4QTJPZHhVazk1b3dk?= =?utf-8?B?NncxYk9TbjE5WENzOFVCUWRjdXJua2hMMFh1YmUvaS9MZ0dMdEFrNnhjUCtM?= =?utf-8?B?WTJ0QWZvK2pqOGJlL0FVV0QxOHhNeVJGdGVIU1h4ci95NE52bS81bG1tVE5u?= =?utf-8?B?aDBldW0wNjNJQ1ZpWUhEay96V2FMelV1Tnkyakw2YVNYS3lyZEl4bXBOa1FT?= =?utf-8?B?Mmk3N3RUM05XN2ZvSnVndFFBQ3Rwcm1TVllIbk9BM2FKOUFnbTFiZHdvOHJa?= =?utf-8?B?d01aTys4L1V3azBnQkxHQ25BUkN4U2F4K1BhaTR0VUFYdnRmVVJPazB1Tm1l?= =?utf-8?B?SjUwZjJacm1BNktlbmZQSE5UTVY0bmp4SXZZMjV5YWl4bzUzTmNWeTV0WnlJ?= =?utf-8?B?MEoxZVpUZXhJcnNad2Z6WlJ0Nm15SUxHOFU2TE9qTG1WeVJMblpWc0FGWlcy?= =?utf-8?B?S2VxOXBBWm5SY0MwbXQwVlRrUHpJcDZhNjBlay9HM1dSUFZ2a3doR2hUbUUw?= =?utf-8?B?aGFpR1krTEJRRzVDcGxPVFBzR1JRZDBqL0FTcFJuaFRnWnFISjcxSjRzbjl5?= =?utf-8?B?SHZWMHBpQ2tCWnQ1bXQ5UldnME04RkFtSjlRRXVhZ2RjSHAzL28yNUltM0ZU?= =?utf-8?B?dVhDSkpVZmZBYys5Ly83bTBEN2RTaFRHckhvUG05aFdiUC9qQ00vVjAvS3cw?= =?utf-8?B?MXVtbEdBaTgrZ0o0a3E2UWU0YjF3Ym5GUnpoMTNXbTYraTZEMFpYMjFLalFI?= =?utf-8?B?MU9HU3RqTGJYcUNiZDZsL3dYWEpLVlBxK2ExOVBQcVBuZ2RnM1hmeldLamI5?= =?utf-8?B?OWlrTzFpbFpSWXFmVjVnbGZ5bEw1Z0ZvaXVNbEo1L3l4L1VmQ0JGQ01JQWE4?= =?utf-8?B?Qnl0b3pVRG5wSzR5YWxKY3F2TjBUZkhDT2ZIQmx1eTlrNzg3S3QwOHBZYVpz?= =?utf-8?B?MS95NDFEVFlRNkhYQS91N1llVXRVY2xOL2dwcVl1WkRvd3hHRHJWRGM5MjJ6?= =?utf-8?B?NjJnWnp2anVEekkvOWkycXFvdFo1VXBKR0ZIQ2tkODR2N3ZyemVSVWFpeDk0?= =?utf-8?B?NzA5S3EzWUplRW9VQkFVN0liazk1VE1yV0lkQzFFSzQ2Q2RVNlk0Wk9aNWdi?= =?utf-8?B?bEQrbGNBMlRTQ2YraGtwTjREYlBDU3BZMkpXaG5NVXZ6VEMvYVJLa2lZTzEx?= =?utf-8?B?aktJM1RVVUlzaGZqWWdkM3Z0dnhlbzZmRXlxUlRib2xjNk1Cd1YyQWJJQmJH?= =?utf-8?B?dnJjQVhHbkpRc29pWTZXd05QVTI5YkJIZ2xpVVNlcE00SlJmUTJBZ2NMVnJP?= =?utf-8?Q?6f6mlakUKCUc3KGJS3Vbw7bfl?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b960282a-5517-475b-81ef-08dcee3d2851 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2024 23:49:21.7457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fbU7UvCQMdr6nSNtNYTz2QpIaRfK06xY0rc2q6tzNM19FTMEvjNF/l0u4SU87ccB X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5953 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/13/2024 2:59 PM, Gur Stavi wrote: > When creating AF_PACKET socket with specified protocol it is > immediately implicitly bound to any existing interface and > becomes RUNNING. Calling bind on such socket is affectively unbind > from "any interface", then bind to the specific interface. > Doesn't mean even if we don't bind the socket, will it receive packets? And what is "any interface" here, does it mean all active interfaces or one active interface, like first one? > When creating socket with 0 as protocol, it is created in non-RUNNING > state, then it can be bound to interface and protocol in a single bind > call and switch to RUNNING state. > > Especially with ETH_P_ALL, binding to any interface is not a good idea. > It is safer and faster to use the 2nd approach. > I can see unbinding and binding may add to initialization time but that is slow path anyway. Why it is not good idea, or less safe? > > This patch replaces protocol in socket creation from ETH_P_ALL to 0. > > Signed-off-by: Gur Stavi > --- > drivers/net/af_packet/rte_eth_af_packet.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c > index 68870dd3e2..b30f88d618 100644 > --- a/drivers/net/af_packet/rte_eth_af_packet.c > +++ b/drivers/net/af_packet/rte_eth_af_packet.c > @@ -650,7 +650,7 @@ open_packet_iface(const char *key __rte_unused, > int *sockfd = extra_args; > > /* Open an AF_PACKET socket... */ > - *sockfd = socket(AF_PACKET, SOCK_RAW, htons(ETH_P_ALL)); > + *sockfd = socket(AF_PACKET, SOCK_RAW, 0); > if (*sockfd == -1) { > PMD_LOG(ERR, "Could not open AF_PACKET socket"); > return -1; > @@ -778,7 +778,7 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, > > for (q = 0; q < nb_queues; q++) { > /* Open an AF_PACKET socket for this queue... */ > - qsockfd = socket(AF_PACKET, SOCK_RAW, htons(ETH_P_ALL)); > + qsockfd = socket(AF_PACKET, SOCK_RAW, 0); > if (qsockfd == -1) { > PMD_LOG_ERRNO(ERR, > "%s: could not open AF_PACKET socket", > > base-commit: 98613d32e3dac58d685f4f236cf8cc9733abaaf3