From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C5153D14E for ; Wed, 29 Mar 2017 17:03:31 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0EB8861B90; Wed, 29 Mar 2017 15:03:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0EB8861B90 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=maxime.coquelin@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0EB8861B90 Received: from [10.36.112.26] (ovpn-112-26.ams2.redhat.com [10.36.112.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C0128996BD; Wed, 29 Mar 2017 15:03:29 +0000 (UTC) To: Yuanhan Liu , dev@dpdk.org References: <1490253059-28112-1-git-send-email-yuanhan.liu@linux.intel.com> <1490705142-893-1-git-send-email-yuanhan.liu@linux.intel.com> <1490705142-893-5-git-send-email-yuanhan.liu@linux.intel.com> Cc: Harris James R , Liu Changpeng From: Maxime Coquelin Message-ID: Date: Wed, 29 Mar 2017 17:03:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1490705142-893-5-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 29 Mar 2017 15:03:31 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 04/22] vhost: make notify ops per vhost driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 15:03:32 -0000 On 03/28/2017 02:45 PM, Yuanhan Liu wrote: > Assume there is an application both support vhost-user net and > vhost-user scsi, the callback should be different. Making notify > ops per vhost driver allow application define different set of > callbacks for different driver. > > Signed-off-by: Yuanhan Liu > --- > > v2: - check the return value of callback_register and callback_get > - update release note > --- > doc/guides/prog_guide/vhost_lib.rst | 2 +- > doc/guides/rel_notes/release_17_05.rst | 3 +++ > drivers/net/vhost/rte_eth_vhost.c | 20 +++++++++++--------- > examples/tep_termination/main.c | 7 ++++++- > examples/vhost/main.c | 9 +++++++-- > lib/librte_vhost/rte_virtio_net.h | 3 ++- > lib/librte_vhost/socket.c | 32 ++++++++++++++++++++++++++++++++ > lib/librte_vhost/vhost.c | 16 +--------------- > lib/librte_vhost/vhost.h | 5 ++++- > lib/librte_vhost/vhost_user.c | 22 ++++++++++++++++------ > 10 files changed, 83 insertions(+), 36 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime