From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6083A0613 for ; Fri, 30 Aug 2019 16:57:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC2DB1E87C; Fri, 30 Aug 2019 16:57:32 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 96A251E555 for ; Fri, 30 Aug 2019 16:57:31 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Aug 2019 07:57:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,447,1559545200"; d="scan'208";a="183822985" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.4]) ([10.237.221.4]) by orsmga003.jf.intel.com with ESMTP; 30 Aug 2019 07:57:22 -0700 To: Jerin Jacob Kollanukkaran , "Wei Hu (Xavier)" , "dev@dpdk.org" Cc: "linuxarm@huawei.com" , "xavier_huwei@163.com" , "liudongdong3@huawei.com" , "forest.zhouchang@huawei.com" References: <1566568031-45991-1-git-send-email-xavier.huwei@huawei.com> <1566568031-45991-23-git-send-email-xavier.huwei@huawei.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Fri, 30 Aug 2019 15:57:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/23/2019 3:08 PM, Jerin Jacob Kollanukkaran wrote: >> -----Original Message----- >> From: dev On Behalf Of Wei Hu (Xavier) >> Sent: Friday, August 23, 2019 7:17 PM >> To: dev@dpdk.org >> Cc: linuxarm@huawei.com; xavier_huwei@163.com; >> liudongdong3@huawei.com; forest.zhouchang@huawei.com >> Subject: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files >> >> This patch add build related files for hns3 PMD driver. >> >> Signed-off-by: Wei Hu (Xavier) >> Signed-off-by: Min Hu (Connor) >> Signed-off-by: Chunsong Feng >> Signed-off-by: Hao Chen >> Signed-off-by: Huisong Li >> --- >> +# Hisilicon HNS3 PMD driver >> +# >> +CONFIG_RTE_LIBRTE_HNS3_PMD=y > > # Please add meson support > # Move build infra to the first patch +1 to move this to be beginning of the patchset > # See git log drivers/net/octeontx2 as example > > >> diff --git a/config/common_base b/config/common_base >> index 8ef75c2..71a2c33 100644 >> --- a/config/common_base >> +++ b/config/common_base >> @@ -282,6 +282,11 @@ >> CONFIG_RTE_LIBRTE_E1000_PF_DISABLE_STRIP_CRC=n >> CONFIG_RTE_LIBRTE_HINIC_PMD=n >> >> # >> +# Compile burst-oriented HNS3 PMD driver >> +# >> +CONFIG_RTE_LIBRTE_HNS3_PMD=n >> + >> +# >> # Compile burst-oriented IXGBE PMD driver >> # >> CONFIG_RTE_LIBRTE_IXGBE_PMD=y >> diff --git a/config/defconfig_arm64-armv8a-linuxapp-clang >> b/config/defconfig_arm64-armv8a-linuxapp-clang >> index d3b4dad..c73f5fb 100644 >> --- a/config/defconfig_arm64-armv8a-linuxapp-clang >> +++ b/config/defconfig_arm64-armv8a-linuxapp-clang >> @@ -6,3 +6,5 @@ >> >> CONFIG_RTE_TOOLCHAIN="clang" >> CONFIG_RTE_TOOLCHAIN_CLANG=y >> + >> +CONFIG_RTE_LIBRTE_HNS3_PMD=n >> diff --git a/doc/guides/nics/features/hns3.ini >> b/doc/guides/nics/features/hns3.ini >> new file mode 100644 >> index 0000000..d38d35e >> --- /dev/null >> +++ b/doc/guides/nics/features/hns3.ini >> @@ -0,0 +1,38 @@ >> +; >> +; Supported features of the 'hns3' network poll mode driver. > > Add doc changes when driver feature gets added. > # See git log drivers/net/octeontx2 as example +1, I put comments on the patches for same thing > >> +; >> +; Refer to default.ini for the full list of available PMD features. >> +; >> +[Features] >> +Link status = Y >> +MTU update = Y >> +Jumbo frame = Y >> +Promiscuous mode = Y >> +Allmulticast mode = Y >> diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst >> new file mode 100644 >> index 0000000..c9d0253 >> --- /dev/null >> +++ b/doc/guides/nics/hns3.rst >> @@ -0,0 +1,55 @@ >> +.. SPDX-License-Identifier: BSD-3-Clause >> + Copyright(c) 2018-2019 Hisilicon Limited. >> + >> +HNS3 Poll Mode Driver >> +=============================== >> + >> +The Hisilicon Network Subsystem is a long term evolution IP which is >> +supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920. >> + >> +The HNS3 PMD (librte_pmd_hns3) provides poll mode driver support >> +for hns3(Hisilicon Network Subsystem 3) network engine. >> + >> +Features >> +-------- >> + >> +Features of the HNS3 PMD are: >> + >> +- Arch support: ARMv8. > > Is it an integrated NIC controller? Why it is supported only on ARMv8? > The reason why I asking because, Enabling CONFIG_RTE_LIBRTE_HNS3_PMD=y > only on arm64 will create a case where build fails for arm64 and passes for > x86. I would like to avoid such disparity. If the build is passing on x86 make it > enable in the common code, not in arm64 config. > > >> +- Multiple queues for TX and RX >> +- Receive Side Scaling (RSS) >> +- Packet type information >> +- Checksum offload >> +- Promiscuous mode >> +- Multicast mode >> +- Port hardware statistics >> +- Jumbo frames >> +- Link state information >> +- VLAN stripping > > >> +cflags += '-DALLOW_EXPERIMENTAL_API' >> diff --git a/drivers/net/hns3/rte_pmd_hns3_version.map >> b/drivers/net/hns3/rte_pmd_hns3_version.map >> new file mode 100644 >> index 0000000..3aef967 >> --- /dev/null >> +++ b/drivers/net/hns3/rte_pmd_hns3_version.map >> @@ -0,0 +1,3 @@ >> +DPDK_19.08 { > > Change to 19.11 >