From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 71CC758C5 for ; Fri, 2 Dec 2016 11:00:52 +0100 (CET) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DA9449C0AF; Fri, 2 Dec 2016 10:00:51 +0000 (UTC) Received: from [10.36.126.11] ([10.36.126.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB2A0m1c027704 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 2 Dec 2016 05:00:50 -0500 To: Zhiyong Yang , dev@dpdk.org References: <1480926387-63838-1-git-send-email-zhiyong.yang@intel.com> Cc: yuanhan.liu@linux.intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com From: Maxime Coquelin Message-ID: Date: Fri, 2 Dec 2016 11:00:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480926387-63838-1-git-send-email-zhiyong.yang@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 02 Dec 2016 10:00:51 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 0/4] eal/common: introduce rte_memset and related test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2016 10:00:52 -0000 Hi Zhiyong, On 12/05/2016 09:26 AM, Zhiyong Yang wrote: > DPDK code has met performance drop badly in some case when calling glibc > function memset. Reference to discussions about memset in > http://dpdk.org/ml/archives/dev/2016-October/048628.html > It is necessary to introduce more high efficient function to fix it. > One important thing about rte_memset is that we can get clear control > on what instruction flow is used. > > This patchset introduces rte_memset to bring more high efficient > implementation, and will bring obvious perf improvement, especially > for small N bytes in the most application scenarios. > > Patch 1 implements rte_memset in the file rte_memset.h on IA platform > The file supports three types of instruction sets including sse & avx > (128bits), avx2(256bits) and avx512(512bits). rte_memset makes use of > vectorization and inline function to improve the perf on IA. In addition, > cache line and memory alignment are fully taken into consideration. > > Patch 2 implements functional autotest to validates the function whether > to work in a right way. > > Patch 3 implements performance autotest separately in cache and memory. > > Patch 4 Using rte_memset instead of copy_virtio_net_hdr can bring 3%~4% > performance improvements on IA platform from virtio/vhost non-mergeable > loopback testing. > > Zhiyong Yang (4): > eal/common: introduce rte_memset on IA platform > app/test: add functional autotest for rte_memset > app/test: add performance autotest for rte_memset > lib/librte_vhost: improve vhost perf using rte_memset > > app/test/Makefile | 3 + > app/test/test_memset.c | 158 +++++++++ > app/test/test_memset_perf.c | 348 +++++++++++++++++++ > doc/guides/rel_notes/release_17_02.rst | 11 + > .../common/include/arch/x86/rte_memset.h | 376 +++++++++++++++++++++ > lib/librte_eal/common/include/generic/rte_memset.h | 51 +++ > lib/librte_vhost/virtio_net.c | 18 +- > 7 files changed, 958 insertions(+), 7 deletions(-) > create mode 100644 app/test/test_memset.c > create mode 100644 app/test/test_memset_perf.c > create mode 100644 lib/librte_eal/common/include/arch/x86/rte_memset.h > create mode 100644 lib/librte_eal/common/include/generic/rte_memset.h > Thanks for the series, idea looks good to me. Wouldn't be worth to also use rte_memset in Virtio PMD (not compiled/tested)? : diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 22d97a4..a5f70c4 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -287,7 +287,7 @@ virtqueue_enqueue_xmit(struct virtnet_tx *txvq, struct rte_mbuf *cookie, rte_pktmbuf_prepend(cookie, head_size); /* if offload disabled, it is not zeroed below, do it now */ if (offload == 0) - memset(hdr, 0, head_size); + rte_memset(hdr, 0, head_size); } else if (use_indirect) { /* setup tx ring slot to point to indirect * descriptor list stored in reserved region. Cheers, Maxime