From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 70D8032A5 for ; Thu, 8 Dec 2016 17:45:24 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP; 08 Dec 2016 08:45:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,320,1477983600"; d="scan'208";a="910145456" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga003.jf.intel.com with ESMTP; 08 Dec 2016 08:45:22 -0800 To: Harish Patil , dev@dpdk.org References: <1480733039-13046-1-git-send-email-harish.patil@qlogic.com> <1480733039-13046-6-git-send-email-harish.patil@qlogic.com> Cc: Dept-EngDPDKDev@qlogic.com From: Ferruh Yigit Message-ID: Date: Thu, 8 Dec 2016 16:45:21 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1480733039-13046-6-git-send-email-harish.patil@qlogic.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 6/7] net/qede: fix maximum VF count to 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2016 16:45:24 -0000 On 12/3/2016 2:43 AM, Harish Patil wrote: > Set max_vfs to 0 since it is relevant only to SR-IOV PF > which is not supported yet. > > Fixes: 2ea6f76a ("qede: add core driver") > > Signed-off-by: Harish Patil Can you please update patch title to indicate what has been fixed instead of what has been done in the patch. btw, while checking feature list, I have seen qede_vf supports SR-IOV, is that correct? > --- > drivers/net/qede/qede_ethdev.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c > index ee8fb43..10abb8b 100644 > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -976,10 +976,7 @@ static int qede_dev_configure(struct rte_eth_dev *eth_dev) > dev_info->max_rx_queues = (uint16_t)QEDE_MAX_RSS_CNT(qdev); > dev_info->max_tx_queues = dev_info->max_rx_queues; > dev_info->max_mac_addrs = qdev->dev_info.num_mac_addrs; > - if (IS_VF(edev)) > - dev_info->max_vfs = 0; > - else > - dev_info->max_vfs = (uint16_t)NUM_OF_VFS(&qdev->edev); > + dev_info->max_vfs = 0; > dev_info->reta_size = ECORE_RSS_IND_TABLE_SIZE; > dev_info->hash_key_size = ECORE_RSS_KEY_SIZE * sizeof(uint32_t); > dev_info->flow_type_rss_offloads = (uint64_t)QEDE_RSS_OFFLOAD_ALL; >