From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A1EAA00C3; Thu, 3 Feb 2022 21:21:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 926FE40143; Thu, 3 Feb 2022 21:21:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BB59E40140 for ; Thu, 3 Feb 2022 21:21:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643919672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TM8gDYxq5JrDek4SzA5Dbtfyq5csgsFHsuky/WbzHxM=; b=TpvjcfPee0YXgcDg/7NERDz3GLZHEpYBXQCOTyPSB6uY0ilADi9bvHF+lxbVPUKgnQnf7p fYKejiS7W+lZ+mHHF3NG5iXwIFpz3MFdR6mVnrd/LscZF7whE/ZjP120OwSb4dMZ5HpVfQ E2k3RLERJH9M1BKCB+vG3x8B2k7je3w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-191-18PmBi2UNiOc-2aiI8TUbA-1; Thu, 03 Feb 2022 15:21:09 -0500 X-MC-Unique: 18PmBi2UNiOc-2aiI8TUbA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A3E5B1898292; Thu, 3 Feb 2022 20:21:07 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.33.96]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E08495FC03; Thu, 3 Feb 2022 20:21:06 +0000 (UTC) From: Aaron Conole To: Thomas Monjalon Cc: aconole@redhat.com, david.marchand@redhat.com, dev@dpdk.org, Josh Soref Subject: Re: [PATCH 1/1] ci: restrict concurrency References: <20220112065019.58924-1-jsoref@gmail.com> <3172041.VqM8IeB0Os@thomas> <2566114.Isy0gbHreE@thomas> Date: Thu, 03 Feb 2022 15:21:06 -0500 In-Reply-To: <2566114.Isy0gbHreE@thomas> (Thomas Monjalon's message of "Wed, 02 Feb 2022 15:17:20 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thomas Monjalon writes: > Aaron, David, > Please could you review this patch? > Thanks > > 13/01/2022 13:41, Josh Soref: >> On Thu, Jan 13, 2022, 6:42 AM Thomas Monjalon wrote: >> >> > Hi, >> > >> > The explanation should be in the patch, not the cover letter. >> > Actually, you don't need a cover letter for a single patch. >> > Copying it here: >> > " >> > dpdk is fairly expensive to build in GitHub. >> > >> > It's helpful to abandon old builds as soon as there's a new >> > build waiting instead of wasting resources on the previous >> > round. >> > " >> > >> > 12/01/2022 07:50, Josh Soref: >> > > Signed-off-by: Josh Soref >> > > --- >> > > + concurrency: >> > > + group: build-${{ matrix.config.os }}-${{ matrix.config.compiler >> > }}-${{ matrix.config.library }}-${{ matrix.config.cross }}-${{ >> > matrix.config.mini }}-${{ github.event.pull_request.number || github.ref }} >> > > + cancel-in-progress: true >> > >> > The goal of the CI is to catch any issue in a submitted patch. >> > Is your change cancelling a test of a patch when another one is submitted? >> > >> >> If it's on the same branch or if it's in the same pull request yes, >> otherwise, no. We currently have a report on every patch, which helps us when a patch series has a breaking failure in the middle and then fixes it in a later patch. With the mechanism you have here, we lose that ability - it is important to have, as a `git bisect` can be broken without this feature. How much of a problem is this in practice? I want us to be good citizens, but also I don't want to lose the bisect-ability of the series.