[dpdk-dev] [PATCH v1] net/ice: fix the reversed priority of DCF switch rule

[dpdk-dev] [PATCH v1] net/ice: fix the reversed priority of DCF switch rule

[Wenjun Wu]

This patch fixes the reversed priority of DCF switch rule. Priority 0 and 1
are supported, and priority 0 should be the highest priority.

Fixes: 2321e34c23b3 ("net/ice: support flow priority for DCF switch filter")

Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
---
 drivers/net/ice/ice_switch_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
index eeed386c63..f222cb9cb0 100644
--- a/drivers/net/ice/ice_switch_filter.c
+++ b/drivers/net/ice/ice_switch_filter.c
@@ -1572,7 +1572,7 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad,
 	rule_info->sw_act.src = rule_info->sw_act.vsi_handle;
 	rule_info->sw_act.flag = ICE_FLTR_RX;
 	rule_info->rx = 1;
-	rule_info->priority = priority + 5;
+	rule_info->priority = 6 - priority;
 
 	return 0;
 }
-- 
2.25.1

Re: [dpdk-dev] [PATCH v1] net/ice: fix the reversed priority of DCF switch rule

[Zhang, Qi Z]

> -----Original Message-----
> From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> Sent: Monday, August 2, 2021 3:25 PM
> To: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>
> Cc: Wu, Wenjun1 <wenjun1.wu@intel.com>
> Subject: [PATCH v1] net/ice: fix the reversed priority of DCF switch rule
> 
> This patch fixes the reversed priority of DCF switch rule. Priority 0 and 1 are
> supported, and priority 0 should be the highest priority.
> 
> Fixes: 2321e34c23b3 ("net/ice: support flow priority for DCF switch filter")
> 
> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

Re: [dpdk-dev] [PATCH v1] net/ice: fix the reversed priority of DCF switch rule

[Ferruh Yigit]

On 8/2/2021 8:25 AM, Wenjun Wu wrote:
> This patch fixes the reversed priority of DCF switch rule. Priority 0 and 1
> are supported, and priority 0 should be the highest priority.
> 
> Fixes: 2321e34c23b3 ("net/ice: support flow priority for DCF switch filter")
> 

I guess 'Cc: stable@dpdk.org' tag is needed, will add in next-net.
Please check if it is needed next time, './devtools/check-git-log.sh' should help.

@Aaron, @Thomas, Can we add 'check-git-log.sh' checks to the CI?

Thanks,
ferruh

> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
> ---
>  drivers/net/ice/ice_switch_filter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
> index eeed386c63..f222cb9cb0 100644
> --- a/drivers/net/ice/ice_switch_filter.c
> +++ b/drivers/net/ice/ice_switch_filter.c
> @@ -1572,7 +1572,7 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad,
>  	rule_info->sw_act.src = rule_info->sw_act.vsi_handle;
>  	rule_info->sw_act.flag = ICE_FLTR_RX;
>  	rule_info->rx = 1;
> -	rule_info->priority = priority + 5;
> +	rule_info->priority = 6 - priority;
>  
>  	return 0;
>  }
> 

Re: [dpdk-dev] [PATCH v1] net/ice: fix the reversed priority of DCF switch rule

[Thomas Monjalon]

13/08/2021 12:45, Ferruh Yigit:
> On 8/2/2021 8:25 AM, Wenjun Wu wrote:
> > This patch fixes the reversed priority of DCF switch rule. Priority 0 and 1
> > are supported, and priority 0 should be the highest priority.
> > 
> > Fixes: 2321e34c23b3 ("net/ice: support flow priority for DCF switch filter")
> > 
> 
> I guess 'Cc: stable@dpdk.org' tag is needed, will add in next-net.
> Please check if it is needed next time, './devtools/check-git-log.sh' should help.
> 
> @Aaron, @Thomas, Can we add 'check-git-log.sh' checks to the CI?

We need first to fix the rule for the patches touching "common/".
There is a patch in progress.

Re: [dpdk-dev] [PATCH v1] net/ice: fix the reversed priority of DCF switch rule

[Aaron Conole]

Thomas Monjalon <thomas@monjalon.net> writes:

> 13/08/2021 12:45, Ferruh Yigit:
>> On 8/2/2021 8:25 AM, Wenjun Wu wrote:
>> > This patch fixes the reversed priority of DCF switch rule. Priority 0 and 1
>> > are supported, and priority 0 should be the highest priority.
>> > 
>> > Fixes: 2321e34c23b3 ("net/ice: support flow priority for DCF switch filter")
>> > 
>> 
>> I guess 'Cc: stable@dpdk.org' tag is needed, will add in next-net.
>> Please check if it is needed next time, './devtools/check-git-log.sh' should help.
>> 
>> @Aaron, @Thomas, Can we add 'check-git-log.sh' checks to the CI?
>
> We need first to fix the rule for the patches touching "common/".
> There is a patch in progress.

I think it's possible to add - I don't think it will be too much work.