From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 782C4A0548; Fri, 16 Apr 2021 14:32:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34D8B141D78; Fri, 16 Apr 2021 14:32:41 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 38209141D77 for ; Fri, 16 Apr 2021 14:32:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618576359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kLzsApMZh4xPqT0rC2y/3qjmribUv8XJQj5ygxZuOcM=; b=VTijlI9mTiBZ+nX83cn+qEiWv3ElAj4tDVRBn2ePRWxhrPsPqeOZAxfuRGM4C/FCwh7kGo bKn72hTGzgvOvhIegBgIrdtAoNcz/bZCjsiQcV2KOzXc1ivXkBJijxf3S1hYie0bjjnLEb dn3nk8YMMgf5R0CA1JVCR5PhKvidLkw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-602-neePOsPpN82Hr3Rk0DeyBQ-1; Fri, 16 Apr 2021 08:32:36 -0400 X-MC-Unique: neePOsPpN82Hr3Rk0DeyBQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1AB0A10053F7; Fri, 16 Apr 2021 12:32:33 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-115-147.rdu2.redhat.com [10.10.115.147]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 39F8860C0F; Fri, 16 Apr 2021 12:32:18 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: dpdklab , Thomas Monjalon , Gaetan Rivet , dev , "Xueming\(Steven\) Li" , Asaf Penso , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Gaetan Rivet , Anatoly Burakov , Ray Kinsella , Neil Horman , Ferruh Yigit , Andrew Rybchenko , Dodji Seketeli , ci@dpdk.org, Owen Hilyard References: <1608304614-13908-2-git-send-email-xuemingl@nvidia.com> <1618283653-16510-1-git-send-email-xuemingl@nvidia.com> <1618283653-16510-2-git-send-email-xuemingl@nvidia.com> Date: Fri, 16 Apr 2021 08:32:17 -0400 In-Reply-To: (David Marchand's message of "Fri, 16 Apr 2021 09:00:13 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [PATCH v5 1/5] devargs: unify scratch buffer storage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" David Marchand writes: > On Tue, Apr 13, 2021 at 5:15 AM Xueming Li wrote: >> diff --git a/lib/librte_eal/include/rte_devargs.h b/lib/librte_eal/include/rte_devargs.h >> index 296f19324f..134b44a887 100644 >> --- a/lib/librte_eal/include/rte_devargs.h >> +++ b/lib/librte_eal/include/rte_devargs.h >> @@ -60,16 +60,16 @@ struct rte_devargs { >> /** Name of the device. */ >> char name[RTE_DEV_NAME_MAX_LEN]; >> RTE_STD_C11 >> - union { >> - /** Arguments string as given by user or "" for no argument. */ >> - char *args; >> + union { /**< driver-related part of device string. */ >> + const char *args; /**< legacy name. */ >> const char *drv_str; >> }; >> struct rte_bus *bus; /**< bus handle. */ >> struct rte_class *cls; /**< class handle. */ >> const char *bus_str; /**< bus-related part of device string. */ >> const char *cls_str; /**< class-related part of device string. */ >> - const char *data; /**< Device string storage. */ >> + char *data; >> + /**< Raw string including bus, class and driver arguments. */ >> }; >> >> /** > > - Flagging this patch for info and its impact on UNH jobs. > > This change is fine, but older libabigail versions could not deal with > such changes (anonymous union, changes of const fields). > This results in an ABI check failure in the UNH x86 job on Ubuntu > 18.04 (and for some people not using recent libabigail). > I can see the ARM job passes fine, so I suppose it is using a more > recent libabigail (running Ubuntu 20.04 maybe?). > > We either need to disable this x86 job or update its libabigail > package (maybe aligning with what we have for public CI which is > libabigail 1.8 manually compiled). > > > - For the longer term, what do you think of using/extending the .ci/ > scripts for use by UNH jobs? I think it would be great if we had some of the scripts shared as a common resource. That would also help us to look at fixes / changes when needed.