From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B88243B38; Wed, 14 Feb 2024 17:25:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96CC4427DF; Wed, 14 Feb 2024 17:25:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 887CB4026A for ; Wed, 14 Feb 2024 17:25:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707927936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XS8/qdQmw0uOUXNmi3Go49eHuAaSthpuqSttIv+cqwA=; b=Mr9zprwjU02ap3WGQSvKWG7W0FgztTvppYzOEpT3C+OIFB7c/l2Rad8Ju9/fVVsNJWXiGr adMA2xBKRz/PtKhzet2vQhtQfUNMK/KW6pc0ux2ysE2d+QcEgiceWo8ZGOiW/9I0l38xvx StRsNp35v6pe3BkcVZtsEwalGX04yKA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-580-Z_RB9bXJNLy2UpFDd4BMug-1; Wed, 14 Feb 2024 11:25:32 -0500 X-MC-Unique: Z_RB9bXJNLy2UpFDd4BMug-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 18B5A85A588; Wed, 14 Feb 2024 16:25:32 +0000 (UTC) Received: from RHTPC1VM0NT (dhcp-17-72.bos.redhat.com [10.18.17.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F7D1492C2D; Wed, 14 Feb 2024 16:25:31 +0000 (UTC) From: Aaron Conole To: Ferruh Yigit Cc: Cristian Dumitrescu , dev@dpdk.org, stable@dpdk.org, David Marchand , Bruce Richardson , Patrick Robb Subject: Re: [PATCH V2] examples/pipeline: fix include path for rte_log.h References: <20240213145218.1532323-1-cristian.dumitrescu@intel.com> <20240213173809.1536955-1-cristian.dumitrescu@intel.com> Date: Wed, 14 Feb 2024 11:25:31 -0500 In-Reply-To: (Ferruh Yigit's message of "Wed, 14 Feb 2024 11:22:16 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Ferruh Yigit writes: > On 2/13/2024 5:38 PM, Cristian Dumitrescu wrote: >> When rte_log.h was moved to a new directory, the include path was not >> updated for the generated C code produced by the pipeline library, >> which results in build failure for this code. >> >> Fixes: 09ce41310930 ("log: separate logging functions out of EAL") >> Cc: stable@dpdk.org >> > > Hi Cristian, > > How can I verify the fix? Can you please list the required steps? I guess maybe (?) with the pipeline DTS case, but I'm not sure that would be sufficient. > And I wonder how this skipped the testing, I guess v23.11 released with > this defect. Is there a gap in the CI or internal build/test scripts? I don't know that softnic driver is used in the lab. Actually, would DTS suite even have triggered this issue? I'm not sure if there is a set of tests which covers the case. Maybe Patrick can confirm about the pipeline test? >> Signed-off-by: Cristian Dumitrescu >> --- >> drivers/net/softnic/rte_eth_softnic_cli.c | 2 ++ >> examples/pipeline/cli.c | 2 ++ >> 2 files changed, 4 insertions(+) >> >> diff --git a/drivers/net/softnic/rte_eth_softnic_cli.c b/drivers/net/softnic/rte_eth_softnic_cli.c >> index 085523fe03..95e705c553 100644 >> --- a/drivers/net/softnic/rte_eth_softnic_cli.c >> +++ b/drivers/net/softnic/rte_eth_softnic_cli.c >> @@ -337,6 +337,7 @@ cmd_softnic_pipeline_libbuild(struct pmd_internals *softnic __rte_unused, >> "-I %s/lib/eal/include " >> "-I %s/lib/eal/x86/include " >> "-I %s/lib/eal/include/generic " >> + "-I %s/lib/log " >> "-I %s/lib/meter " >> "-I %s/lib/port " >> "-I %s/lib/table " >> @@ -361,6 +362,7 @@ cmd_softnic_pipeline_libbuild(struct pmd_internals *softnic __rte_unused, >> install_dir, >> install_dir, >> install_dir, >> + install_dir, >> log_file, >> obj_file, >> lib_file, >> diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c >> index 2ae6cc579f..afb143c01f 100644 >> --- a/examples/pipeline/cli.c >> +++ b/examples/pipeline/cli.c >> @@ -714,6 +714,7 @@ cmd_pipeline_libbuild(char **tokens, >> "-I %s/lib/eal/include " >> "-I %s/lib/eal/x86/include " >> "-I %s/lib/eal/include/generic " >> + "-I %s/lib/log " >> "-I %s/lib/meter " >> "-I %s/lib/port " >> "-I %s/lib/table " >> @@ -738,6 +739,7 @@ cmd_pipeline_libbuild(char **tokens, >> install_dir, >> install_dir, >> install_dir, >> + install_dir, >> log_file, >> obj_file, >> lib_file,