From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73EBB45D05; Thu, 14 Nov 2024 14:52:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 544D84028A; Thu, 14 Nov 2024 14:52:06 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5BDC84025D for ; Thu, 14 Nov 2024 14:52:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731592323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A1QOPuhROtHO63Y2cNey5Y1HPfxy04svsCoE2NdNNO0=; b=gLTTHLbReA9DFpAPV1yYq/bw10dvvibLgWaf4lgVr1KcQp74yDNmXcXNgyZUoZNa9NhB0b IOJ7M39Qiy8WME09k/+T0NxuyqwxZOgA+p0R5vjeB1X7OPYFmnmhyFemxMebOuTAnfYPsG Y2GGcfsg//5SmoFDJ07/AyG6m7jG5Hw= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-534-Jop0dzvMOFeXCOVLl9Sb8g-1; Thu, 14 Nov 2024 08:52:00 -0500 X-MC-Unique: Jop0dzvMOFeXCOVLl9Sb8g-1 X-Mimecast-MFC-AGG-ID: Jop0dzvMOFeXCOVLl9Sb8g Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AB5BD19560B0; Thu, 14 Nov 2024 13:51:59 +0000 (UTC) Received: from RHTRH0061144 (unknown [10.22.81.7]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0EA7730000DF; Thu, 14 Nov 2024 13:51:57 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, Michael Santana Subject: Re: [PATCH v2 2/2] ci: install libvirt In-Reply-To: <20241112140107.1916734-2-david.marchand@redhat.com> (David Marchand's message of "Tue, 12 Nov 2024 15:01:06 +0100") References: <20241112103454.1543861-1-david.marchand@redhat.com> <20241112140107.1916734-1-david.marchand@redhat.com> <20241112140107.1916734-2-david.marchand@redhat.com> Date: Thu, 14 Nov 2024 08:51:55 -0500 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xQbcRia5CrmHFMc32LcYPlD18y2NYXC4cXz3AFTYwaE_1731592320 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org David Marchand writes: > Install libvirt so that vm_power_manager example compilation is tested. > > Signed-off-by: David Marchand > --- LGTM Acked-by: Aaron Conole > .github/workflows/build.yml | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml > index f7d3affbaa..067862d96a 100644 > --- a/.github/workflows/build.yml > +++ b/.github/workflows/build.yml > @@ -107,7 +107,7 @@ jobs: > - name: Install packages > run: sudo apt install -y ccache libarchive-dev libbsd-dev libbpf-dev > libfdt-dev libibverbs-dev libipsec-mb-dev libisal-dev libjansson-dev > - libnuma-dev libpcap-dev libssl-dev ninja-build pkg-config python3-pip > + libnuma-dev libpcap-dev libssl-dev libvirt-dev ninja-build pkg-config python3-pip > python3-pyelftools python3-setuptools python3-wheel zlib1g-dev > - name: Install libabigail build dependencies if no cache is available > if: env.ABI_CHECKS == 'true' && steps.libabigail-cache.outputs.cache-hit != 'true' > @@ -196,8 +196,8 @@ jobs: > if: steps.image_cache.outputs.cache-hit != 'true' > run: docker exec -i dpdk dnf install -y ccache intel-ipsec-mb-devel > isa-l-devel jansson-devel libarchive-devel libatomic libbsd-devel > - libbpf-devel libfdt-devel libpcap-devel libxdp-devel ninja-build > - numactl-devel openssl-devel python3-pip python3-pyelftools > + libbpf-devel libfdt-devel libpcap-devel libvirt-devel libxdp-devel > + ninja-build numactl-devel openssl-devel python3-pip python3-pyelftools > python3-setuptools python3-wheel rdma-core-devel zlib-devel > - name: Save image in cache > if: steps.image_cache.outputs.cache-hit != 'true' > @@ -271,8 +271,8 @@ jobs: > - name: Install packages > run: docker exec -i dpdk dnf install -y ccache intel-ipsec-mb-devel > isa-l-devel jansson-devel libarchive-devel libatomic libbsd-devel > - libbpf-devel libfdt-devel libpcap-devel libxdp-devel ninja-build > - numactl-devel openssl-devel python3-pip python3-pyelftools > + libbpf-devel libfdt-devel libpcap-devel libvirt-devel libxdp-devel > + ninja-build numactl-devel openssl-devel python3-pip python3-pyelftools > python3-setuptools python3-wheel rdma-core-devel zlib-devel > ${{ matrix.config.compiler }} > - name: Run setup