From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CE984318A; Tue, 17 Oct 2023 14:24:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA4FB40273; Tue, 17 Oct 2023 14:24:44 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3AEA140270 for ; Tue, 17 Oct 2023 14:24:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697545482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9/ZZA3JlGi5LFymRZx0r90NZTgSIkROwbDeRtn9FJvw=; b=NcVpjAvkZv+Ke7Xy+UKVPe7TX/RlcVyoaJhqVWLevyZzlZqrF2en+stH539LQVoqIgiq3K 7figRlzDVx+JZqBsCC+7i0u7KWE6K9dwEnS9L9Ou8E8g+1P8gsrdM6SH7NiS4OwlEW0zBI A3rBtYmk55wodjJgnZIUSI8NStyKxJM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-108-vx_BS1oPPguZ6-_om06qeA-1; Tue, 17 Oct 2023 08:24:37 -0400 X-MC-Unique: vx_BS1oPPguZ6-_om06qeA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CBC29805B3E; Tue, 17 Oct 2023 12:24:36 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.17.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 85E2A2166B26; Tue, 17 Oct 2023 12:24:36 +0000 (UTC) From: Aaron Conole To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com, rjarry@redhat.com, Michael Santana Subject: Re: [PATCH v4 3/7] ci: allow use of DPDK tools when building examples References: <20230802170052.955323-1-bruce.richardson@intel.com> <20231016140612.664853-1-bruce.richardson@intel.com> <20231016140612.664853-4-bruce.richardson@intel.com> Date: Tue, 17 Oct 2023 08:24:36 -0400 In-Reply-To: <20231016140612.664853-4-bruce.richardson@intel.com> (Bruce Richardson's message of "Mon, 16 Oct 2023 15:06:08 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Bruce Richardson writes: > To allow use of the DPDK python scripts (installed in $(prefix)/bin) > from within the makefiles of our examples, we need to export the PATH > variable with the location of our installed scripts from within our CI > scripts. This matches what is already done for other paths e.g. the > PKG_CONFIG_PATH variable. > > Signed-off-by: Bruce Richardson > --- I guess this should work, but it's a bit strange that we need to key off something like dpdk-devbind.py. Not a complaint, just an observation. Maybe a future change would be to update the meson.build to set the exec_prefix variable - but I guess for now that might be a much bigger change. But it means we could get the path after setting the pkgconfig path and then just run something like: pkg-config libdpdk --variable=exec_prefix and wouldn't need to search for the python utility. As I wrote - it's a more involved change, and I don't think it should hold up this patch. Just something to consider for the future (maybe Michael or I could look at it) > .ci/linux-build.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh > index e0b62bac90..3db9d9de6e 100755 > --- a/.ci/linux-build.sh > +++ b/.ci/linux-build.sh > @@ -174,6 +174,7 @@ fi > if [ "$BUILD_EXAMPLES" = "true" ]; then > [ -d install ] || DESTDIR=$(pwd)/install meson install -C build > export LD_LIBRARY_PATH=$(dirname $(find $(pwd)/install -name librte_eal.so)):$LD_LIBRARY_PATH > + export PATH=$(dirname $(find $(pwd)/install -name dpdk-devbind.py)):$PATH > export PKG_CONFIG_PATH=$(dirname $(find $(pwd)/install -name libdpdk.pc)):$PKG_CONFIG_PATH > export PKGCONF="pkg-config --define-prefix" > find build/examples -maxdepth 1 -type f -name "dpdk-*" |