From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C1F3A055A; Tue, 25 Feb 2020 15:36:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7EA1A2C4F; Tue, 25 Feb 2020 15:36:26 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 52FCAB62 for ; Tue, 25 Feb 2020 15:36:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582641384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sbQOqxh6nZ1QLf6YrIn0maeIIgAvy0oU5WlX411+JpI=; b=D+khWYanhAucjLApA1QWWl16f5VNJEN8Qd1qPBJel4CF0iQEsVhU0in08+whKi3WsDmLNl VWj6EVAsM2aCABnlzi/z/yaDDRCFok5w2WySNG2suR35NWCU41QlffYjjxRfaW/n4ghYcq BiVOxbRzmM6cRD2pSgzNjKnsWsj97tY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-308-n87h-JSaOSCiTMZvMgtjfw-1; Tue, 25 Feb 2020 09:36:21 -0500 X-MC-Unique: n87h-JSaOSCiTMZvMgtjfw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 44FEB107ACC5; Tue, 25 Feb 2020 14:36:20 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.177]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8B76B6031E; Tue, 25 Feb 2020 14:36:16 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: Ruifeng Wang , Michael Santana , Bruce Richardson , dev , Gavin Hu , Honnappa Nagarahalli , nd References: <20200225073236.135581-1-ruifeng.wang@arm.com> Date: Tue, 25 Feb 2020 09:36:15 -0500 In-Reply-To: (David Marchand's message of "Tue, 25 Feb 2020 10:14:45 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v1] ci: add test suite run without hugepage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" David Marchand writes: > On Tue, Feb 25, 2020 at 8:33 AM Ruifeng Wang wrote= : >> >> This test suite is derived from fast-tests suite. Cases in this >> suite are run with '--no-huge' flag. >> >> The suite aims to cover as many as possible test cases out of the >> fast-tests suites in the environments without huge pages support, >> like containers. >> >> Signed-off-by: Ruifeng Wang >> Reviewed-by: Gavin Hu > > Compilation time is what makes the most of a "tests" job in Travis. > So I'd prefer we avoid adding more jobs for x86_64 (see below). > > >> --- >> .ci/linux-build.sh | 4 +++ >> .travis.yml | 12 +++++++ >> app/test/meson.build | 75 ++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 91 insertions(+) >> >> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh >> index d500c4c00..39515d915 100755 >> --- a/.ci/linux-build.sh >> +++ b/.ci/linux-build.sh >> @@ -92,3 +92,7 @@ fi >> if [ "$RUN_TESTS" =3D "1" ]; then >> sudo meson test -C build --suite fast-tests -t 3 >> fi >> + >> +if [ "$RUN_TESTS_NO_HUGE" =3D "1" ]; then >> + sudo meson test -C build --suite nohuge-tests -t 3 >> +fi > > You can replace the "boolean" RUN_TESTS with a TESTSUITES variable > that contains a list of testsuites. > Then this part becomes: > > for testsuite in ${TESTSUITES:-}; do > sudo meson test -C build --suite $testsuite -t 3 > done > > (I wonder if we reaaaally need to be root to run those tests w/ and > w/o hugepages, Aaron?) Last I tested, we didn't need root access when not using hugepages (at least for core library functionality). It's possible that the test suites for PMDs might need that access, but we don't run them in the travis environment. > >> diff --git a/.travis.yml b/.travis.yml >> index b64a81bd0..0e07d52d0 100644 >> --- a/.travis.yml >> +++ b/.travis.yml >> @@ -43,6 +43,9 @@ jobs: >> - env: DEF_LIB=3D"shared" RUN_TESTS=3D1 >> arch: amd64 >> compiler: gcc >> + - env: DEF_LIB=3D"shared" RUN_TESTS_NO_HUGE=3D1 >> + arch: amd64 >> + compiler: gcc > > And then we only need to update the existing RUN_TESTS jobs for x86_64. I like the suggestion. But I guess we'd just make RUN_TESTS=3D1 set TESTSUITES=3D"..." and otherwise, we can have an ARM64 test to do all the test suites. Actually, the ideal would be for the tests to automatically SKIP when no hugepages are enabled. > >> - env: DEF_LIB=3D"shared" BUILD_DOCS=3D1 >> arch: amd64 >> compiler: gcc >> @@ -66,6 +69,9 @@ jobs: >> - env: DEF_LIB=3D"shared" RUN_TESTS=3D1 >> arch: amd64 >> compiler: clang >> + - env: DEF_LIB=3D"shared" RUN_TESTS_NO_HUGE=3D1 >> + arch: amd64 >> + compiler: clang >> - env: DEF_LIB=3D"shared" BUILD_DOCS=3D1 >> arch: amd64 >> compiler: clang >> @@ -101,6 +107,9 @@ jobs: >> - env: DEF_LIB=3D"static" >> arch: arm64 >> compiler: gcc >> + - env: DEF_LIB=3D"shared" RUN_TESTS_NO_HUGE=3D1 >> + arch: arm64 >> + compiler: gcc >> - env: DEF_LIB=3D"shared" BUILD_DOCS=3D1 >> arch: arm64 >> compiler: gcc >> @@ -124,3 +133,6 @@ jobs: >> - env: DEF_LIB=3D"shared" >> arch: arm64 >> compiler: clang >> + - env: DEF_LIB=3D"shared" RUN_TESTS_NO_HUGE=3D1 >> + arch: arm64 >> + compiler: clang > > > -- > David Marchand