From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14360A04F3; Wed, 8 Jan 2020 17:10:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE5091DAA1; Wed, 8 Jan 2020 17:10:11 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 99E781D5C3 for ; Wed, 8 Jan 2020 17:10:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578499809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SCdj8wXk3x2onoM2U+Eg/cQ+S/MRV2NFRPKuqraWD80=; b=Ybcol8LIXxCEwYVOt0egLFGt5qG3T2GW0z2CQhV88UqnLYM21qsKb641b8GuEyVsNbYPY9 pmzS+tQ7vk5QAmnb5A3m3HpGIXM60RrCTHSJyT+IsnzwRPY6c9RYJEFyaVZwWwpyNNyEU5 6lRxIxP4VczjVkVpckce+ZRz05CWr+M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-s2w9MeGlM8eEjohpGdlQqQ-1; Wed, 08 Jan 2020 11:10:05 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3A7E107ACC7; Wed, 8 Jan 2020 16:10:03 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7EA51271B2; Wed, 8 Jan 2020 16:10:00 +0000 (UTC) From: Aaron Conole To: Bruce Richardson Cc: David Marchand , Luca Boccassi , dev , Michael Santana , Thomas Monjalon References: <20200108110251.20916-1-david.marchand@redhat.com> <8a5bc72da0875617a690d6a95d310974413f46da.camel@debian.org> <20200108121011.GA235@bricha3-MOBL.ger.corp.intel.com> <20200108155025.GA239@bricha3-MOBL.ger.corp.intel.com> Date: Wed, 08 Jan 2020 11:09:59 -0500 In-Reply-To: <20200108155025.GA239@bricha3-MOBL.ger.corp.intel.com> (Bruce Richardson's message of "Wed, 8 Jan 2020 15:50:25 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: s2w9MeGlM8eEjohpGdlQqQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] ci: pin meson to 0.52.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Bruce Richardson writes: > On Wed, Jan 08, 2020 at 10:10:00AM -0500, Aaron Conole wrote: >> David Marchand writes: >>=20 >> > On Wed, Jan 8, 2020 at 1:10 PM Bruce Richardson >> > wrote: >> >> >> >> On Wed, Jan 08, 2020 at 12:59:35PM +0100, David Marchand wrote: >> >> > On Wed, Jan 8, 2020 at 12:29 PM Luca Boccassi wr= ote: >> >> > > >> >> > > On Wed, 2020-01-08 at 12:02 +0100, David Marchand wrote: >> >> > > > meson 0.53.0 has a compatibility issue [1] with the python 3.5.= 2 that >> >> > > > comes >> >> > > > in Ubuntu 16.04. >> >> > > > Let's pin meson to 0.52.0 while the fix is being prepared in me= son. >> >> > > > >> >> > > > 1: >> >> > > > https://github.com/mesonbuild/meson/issues/6427 >> >> > > > >> >> > > > >> >> > > > Signed-off-by: David Marchand < >> >> > > > david.marchand@redhat.com >> >> > > > > >> >> > > > --- >> >> > > > .ci/linux-setup.sh | 2 +- >> >> > > > 1 file changed, 1 insertion(+), 1 deletion(-) >> >> > > >> >> > > Acked-by: Luca Boccassi >> >> > >> >> > There is a 0.52.1 version available, so I suppose we can blacklist >> >> > meson < 0.53 instead. >> >> > Thought? >> >> > >> >> > If noone objects, I will apply a fix by the end of the day. >> >> > >> >> Wondering if there is value in using 0.47.1, the minimum version we >> >> support, to catch potential issues with someone using features from n= ewer >> >> versions? I suspect there are more people using the latest releases o= f >> >> meson than the baseline supported version? >> > >> > Testing with a fixed version seems better in a CI, and since we >> > announce this minimum version, then yes, it makes sense. >> > I will post a v2. >>=20 >> Why is 0.47.1 still the minimum? Don't we require features that are >> introduced as of 0.50? >>=20 > No, it should still work fine, and a quick sanity check tested with 0.47.= 1 > on my system shows no issues, so I think we are good. > > There are some warnings printed about future features when you use a late= r > version, but in all cases the extra parameters added are just ignored by > the older versions, so compatiblity is maintained. Adding 0.47.1 to the C= I > will also help avoid any inadvertent new version requirements from sneaki= ng > in. Makes sense to me. Is there a way to make it whitelist the warnings we know about already? It would be nice to have the CI environment be warning-free (but I don't object to 0.47.1 being a minimum version or anything). > /Bruce