From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D71FA04F3; Fri, 20 Dec 2019 15:52:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E1ACF2C60; Fri, 20 Dec 2019 15:52:16 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 1CB882C19 for ; Fri, 20 Dec 2019 15:52:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576853534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8D+jzNYd08CovAFZf354YZ5oqBCIC5C1t3PDKPts18s=; b=PmA8WxuLiaOpKHh3KR3z6iu3r64IipyCwjjoSSDON5fn49BRupNv1IGMu0jlmDkv9JS/3q SriCR2y3wVwaCKiRPZ00oeRzjryTx9EZ4GTgi7+k/Im9DAB4YO6d2bnVH8wQNY8/mA/2M2 f0PWtjnRjmx6P7gilYdw4jGnIlEbUe4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-76-Rq-nL2l3PISHv4lXcQmf7Q-1; Fri, 20 Dec 2019 09:52:10 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 84C061005513; Fri, 20 Dec 2019 14:52:09 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A17CD1001B00; Fri, 20 Dec 2019 14:52:06 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: dev , dpdk stable References: <20191204205241.5691-1-david.marchand@redhat.com> <20191220140149.1043-1-david.marchand@redhat.com> Date: Fri, 20 Dec 2019 09:52:05 -0500 In-Reply-To: (David Marchand's message of "Fri, 20 Dec 2019 15:43:20 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: Rq-nL2l3PISHv4lXcQmf7Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] test/common: fix log2 check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" David Marchand writes: > On Fri, Dec 20, 2019 at 3:02 PM David Marchand > wrote: >> >> We recently started to get random failures on the common_autotest ut wit= h >> clang on Ubuntu 16.04.6. >> >> Example: https://travis-ci.com/DPDK/dpdk/jobs/263177424 >> >> Wrong rte_log2_u64(0) val 0, expected ffffffff >> Test Failed >> >> The ut passes 0 to log2() to get an expected value. >> >> Quoting log2 / log(3) manual: >> If x is zero, then a pole error occurs, and the functions return >> -HUGE_VAL, -HUGE_VALF, or -HUGE_VALL, respectively. >> >> rte_log2_uXX helpers handle 0 as a special value and return 0. >> Let's have dedicated tests for this case. >> >> Fixes: 05c4345ef5c2 ("test: add unit test for integer log2 function") >> Cc: stable@dpdk.org >> >> Signed-off-by: David Marchand >> Acked-by: Aaron Conole > > Applied with mentioned fix. Thanks!