From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93312A10DA for ; Fri, 2 Aug 2019 15:37:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 12BF31C2A1; Fri, 2 Aug 2019 15:37:48 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6F3E31C28F; Fri, 2 Aug 2019 15:37:46 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DC4AA756; Fri, 2 Aug 2019 13:37:45 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C465D5D9E5; Fri, 2 Aug 2019 13:37:42 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: dev , Michael Santana , dpdk stable References: <1564662465-2925-1-git-send-email-david.marchand@redhat.com> Date: Fri, 02 Aug 2019 09:37:42 -0400 In-Reply-To: (David Marchand's message of "Thu, 1 Aug 2019 14:29:21 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 02 Aug 2019 13:37:45 +0000 (UTC) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" David Marchand writes: > On Thu, Aug 1, 2019 at 2:28 PM David Marchand wrote: >> >> The memory tests currently check that, for normal mode (not legacy mode), >> there is no memory left behind when exiting. >> >> The problem is that if a ethdev port is allocated when scanning pci >> devices (even if the driver probe fails like when you have a virtio >> management interface attached to the kernel), on exit, dpdk won't free >> the associated memory since ethdev never frees the ethdev memzone. >> >> Workaround this by disabling pci scan. > > Not entirely happy with this patch. > I am open to suggestions :-) Seems like an order of allocation / free issue. Is it possible to change the order to be consistent? IE: we only allocate something after we know there's good reason to do so and then we can be sure to always free? I don't know the code in this area well enough yet to comment any more than that. >> >> Fixes: 651cc78f83b5 ("test: fix hugepage file handling in EAL flags autotest") >> Fixes: 690fd3577e90 ("test/eal: add cases for in-memory and single-file-segments") >> Cc: stable@dpdk.org > > And we might want to drop stable.