[dpdk-dev] [PATCH 1/2] test/rib: speed up rib autotests

[dpdk-dev] [PATCH 1/2] test/rib: speed up rib autotests

[Vladimir Medvedkin]

Split slow part of rib_autotest into rib_slow_autotest

Fixes: b35df4dd666e ("test/rib: add autotests")

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
 app/test/autotest_data.py |  6 ++++++
 app/test/meson.build      |  1 +
 app/test/test_rib.c       | 20 ++++++++++++++++++--
 3 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/app/test/autotest_data.py b/app/test/autotest_data.py
index e89707e..ab150db 100644
--- a/app/test/autotest_data.py
+++ b/app/test/autotest_data.py
@@ -117,6 +117,12 @@
         "Report":  None,
     },
     {
+        "Name":    "RIB slow autotest",
+        "Command": "rib_slow_autotest",
+        "Func":    default_autotest,
+        "Report":  None,
+    },
+    {
         "Name":    "RIB6 autotest",
         "Command": "rib6_autotest",
         "Func":    default_autotest,
diff --git a/app/test/meson.build b/app/test/meson.build
index 37ab9d2..8847d5a 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -259,6 +259,7 @@ perf_test_names = [
         'reciprocal_division',
         'reciprocal_division_perf',
         'lpm_perf_autotest',
+        'rib_slow_autotest',
         'fib_slow_autotest',
         'fib_perf_autotest',
         'red_all',
diff --git a/app/test/test_rib.c b/app/test/test_rib.c
index c95957a..3dc48fe 100644
--- a/app/test/test_rib.c
+++ b/app/test/test_rib.c
@@ -76,7 +76,7 @@ test_multiple_create(void)
 
 	config.ext_sz = 0;
 
-	for (i = 0; i < 10; i++) {
+	for (i = 0; i < 100; i++) {
 		config.max_nodes = MAX_RULES - i;
 		rib = rte_rib_create(__func__, SOCKET_ID_ANY, &config);
 		RTE_TEST_ASSERT(rib != NULL, "Failed to create RIB\n");
@@ -329,7 +329,6 @@ static struct unit_test_suite rib_tests = {
 	.teardown = NULL,
 	.unit_test_cases = {
 		TEST_CASE(test_create_invalid),
-		TEST_CASE(test_multiple_create),
 		TEST_CASE(test_free_null),
 		TEST_CASE(test_insert_invalid),
 		TEST_CASE(test_get_fn),
@@ -339,6 +338,16 @@ static struct unit_test_suite rib_tests = {
 	}
 };
 
+static struct unit_test_suite rib_slow_tests = {
+	.suite_name = "rib slow autotest",
+	.setup = NULL,
+	.teardown = NULL,
+	.unit_test_cases = {
+		TEST_CASE(test_multiple_create),
+		TEST_CASES_END()
+	}
+};
+
 /*
  * Do all unit tests.
  */
@@ -348,4 +357,11 @@ test_rib(void)
 	return unit_test_suite_runner(&rib_tests);
 }
 
+static int
+test_slow_rib(void)
+{
+	return unit_test_suite_runner(&rib_slow_tests);
+}
+
 REGISTER_TEST_COMMAND(rib_autotest, test_rib);
+REGISTER_TEST_COMMAND(rib_slow_autotest, test_slow_rib);
-- 
2.7.4

[dpdk-dev] [PATCH 2/2] test/rib: speed up rib6 autotests

[Vladimir Medvedkin]

Split slow part of rib6_autotest into rib6_slow_autotest

Fixes: abab6d2966dc ("test/rib: add IPv6 autotests")

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
 app/test/autotest_data.py |  6 ++++++
 app/test/meson.build      |  1 +
 app/test/test_rib6.c      | 20 ++++++++++++++++++--
 3 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/app/test/autotest_data.py b/app/test/autotest_data.py
index ab150db..6deb97b 100644
--- a/app/test/autotest_data.py
+++ b/app/test/autotest_data.py
@@ -129,6 +129,12 @@
         "Report":  None,
     },
     {
+        "Name":    "RIB6 slow autotest",
+        "Command": "rib6_slow_autotest",
+        "Func":    default_autotest,
+        "Report":  None,
+    },
+    {
         "Name":    "FIB autotest",
         "Command": "fib_autotest",
         "Func":    default_autotest,
diff --git a/app/test/meson.build b/app/test/meson.build
index 8847d5a..ff59c31 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -271,6 +271,7 @@ perf_test_names = [
         'member_perf_autotest',
         'efd_perf_autotest',
         'lpm6_perf_autotest',
+        'rib6_slow_autotest',
         'fib6_slow_autotest',
         'fib6_perf_autotest',
         'rcu_qsbr_perf_autotest',
diff --git a/app/test/test_rib6.c b/app/test/test_rib6.c
index 638ba68..a86e465 100644
--- a/app/test/test_rib6.c
+++ b/app/test/test_rib6.c
@@ -76,7 +76,7 @@ test_multiple_create(void)
 
 	config.ext_sz = 0;
 
-	for (i = 0; i < 10; i++) {
+	for (i = 0; i < 100; i++) {
 		config.max_nodes = MAX_RULES - i;
 		rib = rte_rib6_create(__func__, SOCKET_ID_ANY, &config);
 		RTE_TEST_ASSERT(rib != NULL, "Failed to create RIB\n");
@@ -334,7 +334,6 @@ static struct unit_test_suite rib6_tests = {
 	.teardown = NULL,
 	.unit_test_cases = {
 		TEST_CASE(test_create_invalid),
-		TEST_CASE(test_multiple_create),
 		TEST_CASE(test_free_null),
 		TEST_CASE(test_insert_invalid),
 		TEST_CASE(test_get_fn),
@@ -344,6 +343,16 @@ static struct unit_test_suite rib6_tests = {
 	}
 };
 
+static struct unit_test_suite rib6_slow_tests = {
+	.suite_name = "rib6 slow autotest",
+	.setup = NULL,
+	.teardown = NULL,
+	.unit_test_cases = {
+		TEST_CASE(test_multiple_create),
+		TEST_CASES_END()
+	}
+};
+
 /*
  * Do all unit tests.
  */
@@ -353,5 +362,12 @@ test_rib6(void)
 	return unit_test_suite_runner(&rib6_tests);
 }
 
+static int
+test_slow_rib6(void)
+{
+	return unit_test_suite_runner(&rib6_slow_tests);
+}
+
 REGISTER_TEST_COMMAND(rib6_autotest, test_rib6);
+REGISTER_TEST_COMMAND(rib6_slow_autotest, test_slow_rib6);
 
-- 
2.7.4

Re: [dpdk-dev] [PATCH 1/2] test/rib: speed up rib autotests

[Aaron Conole]

Vladimir Medvedkin <vladimir.medvedkin@intel.com> writes:

> Split slow part of rib_autotest into rib_slow_autotest
>
> Fixes: b35df4dd666e ("test/rib: add autotests")
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>

Re: [dpdk-dev] [PATCH 2/2] test/rib: speed up rib6 autotests

[Aaron Conole]

Vladimir Medvedkin <vladimir.medvedkin@intel.com> writes:

> Split slow part of rib6_autotest into rib6_slow_autotest
>
> Fixes: abab6d2966dc ("test/rib: add IPv6 autotests")
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>

Re: [dpdk-dev] [PATCH 1/2] test/rib: speed up rib autotests

[David Marchand]

On Thu, Nov 7, 2019 at 4:21 PM Aaron Conole <aconole@redhat.com> wrote:
>
> Vladimir Medvedkin <vladimir.medvedkin@intel.com> writes:
>
> > Split slow part of rib_autotest into rib_slow_autotest
> >
> > Fixes: b35df4dd666e ("test/rib: add autotests")
> >
> > Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> > ---
>
> Acked-by: Aaron Conole <aconole@redhat.com>

Series applied, thanks.



--
David Marchand