From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 4DAACA0096
for <public@inbox.dpdk.org>; Tue, 4 Jun 2019 15:30:06 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 71EEC1BC1E;
Tue, 4 Jun 2019 15:30:05 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id 025511BC1D
for <dev@dpdk.org>; Tue, 4 Jun 2019 15:30:03 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
[10.5.11.14])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 61BA5C07014A;
Tue, 4 Jun 2019 13:29:58 +0000 (UTC)
Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 1D7275D9D2;
Tue, 4 Jun 2019 13:29:54 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net, msantana@redhat.com,
Anatoly Burakov <anatoly.burakov@intel.com>
References: <1559638792-8608-1-git-send-email-david.marchand@redhat.com>
<1559638792-8608-13-git-send-email-david.marchand@redhat.com>
Date: Tue, 04 Jun 2019 09:29:53 -0400
In-Reply-To: <1559638792-8608-13-git-send-email-david.marchand@redhat.com>
(David Marchand's message of "Tue, 4 Jun 2019 10:59:50 +0200")
Message-ID: <f7t7ea1cwby.fsf@dhcp-25.97.bos.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.31]); Tue, 04 Jun 2019 13:30:03 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH 12/14] test/eal: make the test pass again
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Hi David and Michael,
David Marchand <david.marchand@redhat.com> writes:
> From: Michael Santana <msantana@redhat.com>
>
> The eal_flags_autotest test currently fails due to a memory leak in the
> timer library[1][2]. This failure occurs when the test calls one of its
> subtests test_file_prefix().
>
> Fixing the memory leak is not trivial, so this patch is a workaround that
> makes the eal_flags_autotest test pass. This is accomplished by moving the
> test_file_prefix test to its own test unit. This is a temporary measure
> until the leak is fixed.
>
> [1] http://patchwork.dpdk.org/patch/53268/
> [2] http://patchwork.dpdk.org/patch/53334/
>
> Signed-off-by: Michael Santana <msantana@redhat.com>
> ---
I'm wondering if it's better to just fix the leak outright.
Then again, it might be useful to have the file-prefix test as an
enumerable test anyway.
CC'd Anatoly.
> app/test/autotest_data.py | 6 ++++++
> app/test/meson.build | 1 +
> app/test/test_eal_flags.c | 7 +------
> 3 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/app/test/autotest_data.py b/app/test/autotest_data.py
> index 6cf7eca..15e672f 100644
> --- a/app/test/autotest_data.py
> +++ b/app/test/autotest_data.py
> @@ -93,6 +93,12 @@
> "Report": None,
> },
> {
> + "Name": "EAL flags file prefix autotest",
> + "Command": "eal_flags_prefix_autotest",
> + "Func": default_autotest,
> + "Report": None,
> + },
> + {
> "Name": "Hash autotest",
> "Command": "hash_autotest",
> "Func": default_autotest,
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 7ad3684..212cd1b 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -156,6 +156,7 @@ fast_parallel_test_names = [
> 'cycles_autotest',
> 'debug_autotest',
> 'eal_flags_autotest',
> + 'eal_flags_prefix_autotest',
> 'eal_fs_autotest',
> 'errno_autotest',
> 'event_ring_autotest',
> diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
> index cfa8a61..1e227aa 100644
> --- a/app/test/test_eal_flags.c
> +++ b/app/test/test_eal_flags.c
> @@ -1397,12 +1397,6 @@ enum hugepage_action {
> return ret;
> }
>
> - ret = test_file_prefix();
> - if (ret < 0) {
> - printf("Error in test_file_prefix()\n");
> - return ret;
> - }
> -
> ret = test_misc_flags();
> if (ret < 0) {
> printf("Error in test_misc_flags()");
> @@ -1413,3 +1407,4 @@ enum hugepage_action {
> }
>
> REGISTER_TEST_COMMAND(eal_flags_autotest, test_eal_flags);
> +REGISTER_TEST_COMMAND(eal_flags_prefix_autotest, test_file_prefix);