From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4583AA00BE; Tue, 8 Feb 2022 16:09:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC026410FD; Tue, 8 Feb 2022 16:09:05 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7B16C410FC for ; Tue, 8 Feb 2022 16:09:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644332943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H2ftsTnSll89KY/NsUZlCLZSB+g8xQMh0khTSF37snI=; b=VbjvkjnyPBKDX9IH2F1HaRQ9mu551lwTSwOzBDaH/DNHo8GxcyoBAGj1EkiG1gXNNU64/3 H3cFzdArUwOhzfC+OEyCyv1U6pwT0KV4gcH5tJNe6O9lR4OK3WEaf5HWU2KRnyrJnsUJvC 2O6WsUfSXAuSa6QZx2fRG9OQhYG+IZ4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-280-olEbvTaJMUaP__c3p0-ETQ-1; Tue, 08 Feb 2022 10:09:00 -0500 X-MC-Unique: olEbvTaJMUaP__c3p0-ETQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BDAE2107B263; Tue, 8 Feb 2022 15:08:59 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.10.117]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BA9EE74E94; Tue, 8 Feb 2022 15:08:54 +0000 (UTC) From: Aaron Conole To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, Michael Santana , Lincoln Lavoie , Owen Hilyard Subject: Re: [PATCH] ci: remove outdated default reference tag for ABI References: <20220208134715.796609-1-thomas@monjalon.net> Date: Tue, 08 Feb 2022 10:08:53 -0500 In-Reply-To: <20220208134715.796609-1-thomas@monjalon.net> (Thomas Monjalon's message of "Tue, 8 Feb 2022 14:47:15 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thomas Monjalon writes: > The variable REF_GIT_TAG is set in the CI configuration > like .travis.yml or .github/workflows/build.yml. > The default value is outdated and probably unused. > It is removed completely to avoid forgetting an update in future. > > Signed-off-by: Thomas Monjalon > --- I think the default was there for labs that run the build script manually. Maybe there are no such users, though. I believe the lab has its own script for doing such ABI checks (but can't remember off the top of my head). CC'd Lincoln and Owen just to confirm. Assuming the UNH/other lab doesn't use this feature of the linux build script, Acked-by: Aaron Conole