From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A7DFCA00E6
	for <public@inbox.dpdk.org>; Thu,  8 Aug 2019 16:30:06 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C81971BE55;
	Thu,  8 Aug 2019 16:30:05 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 9193A1BE4F
 for <dev@dpdk.org>; Thu,  8 Aug 2019 16:30:04 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 01EA980F6D
 for <dev@dpdk.org>; Thu,  8 Aug 2019 14:30:04 +0000 (UTC)
Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.67])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id F1E5360BF4;
 Thu,  8 Aug 2019 14:30:00 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org,  msantana@redhat.com
References: <1565266937-8159-1-git-send-email-david.marchand@redhat.com>
Date: Thu, 08 Aug 2019 10:30:00 -0400
In-Reply-To: <1565266937-8159-1-git-send-email-david.marchand@redhat.com>
 (David Marchand's message of "Thu, 8 Aug 2019 14:22:17 +0200")
Message-ID: <f7t8ss3ivbr.fsf@dhcp-25.97.bos.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.27]); Thu, 08 Aug 2019 14:30:04 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] ci: exit setup on any error
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

David Marchand <david.marchand@redhat.com> writes:

> -e is preferrable so that we can catch errors in the middle of this
> script.
> An example is this Travis job [1] that should have errored at the meson
> install step rather than go to the build step.
>
> Adding debug mode as it can help post-mortem.
>
> 1: https://travis-ci.com/DPDK/dpdk/jobs/223511683
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Good call.

Acked-by: Aaron Conole <aconole@redhat.com>