From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B824EA0A02;
	Thu, 25 Mar 2021 14:09:28 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 46E994067B;
	Thu, 25 Mar 2021 14:09:28 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mails.dpdk.org (Postfix) with ESMTP id DA91840147
 for <dev@dpdk.org>; Thu, 25 Mar 2021 14:09:26 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1616677766;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=j6I+Yh1FhlHQxHOWXd4PD6EjNHRygj9w9zrDhfo1ey0=;
 b=hCeeHbo1wf5xTRsA7TZQd5k+zgAwPo3wJWdHrtG9sz90rjleUq+Bs4SWVLjEsdqe0r+yEB
 XxBNatMq85b3SuoD/RRWp7mERTiI/12YxS5JsJIO32/5yL32AQUkza69dtxThCNnpGha8b
 6xyBrZiavVxG65QhSDZfRBnpQ546pNU=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-268-LMNMJkQ8NUGkL0HZzMLsFw-1; Thu, 25 Mar 2021 09:09:24 -0400
X-MC-Unique: LMNMJkQ8NUGkL0HZzMLsFw-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
 [10.5.11.22])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E927681746C;
 Thu, 25 Mar 2021 13:09:22 +0000 (UTC)
Received: from dhcp-25.97.bos.redhat.com (ovpn-115-49.rdu2.redhat.com
 [10.10.115.49])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A14210016FB;
 Thu, 25 Mar 2021 13:09:20 +0000 (UTC)
From: Aaron Conole <aconole@redhat.com>
To: 583493798@qq.com
Cc: dev@dpdk.org, thomas@monjalon.net,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Anatoly Burakov <anatoly.burakov@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
References: <20200501161603.33907-1-583493798@qq.com>
 <tencent_8FA596830F4F89E9E2169503B40DF0FF0307@qq.com>
Date: Thu, 25 Mar 2021 09:09:18 -0400
In-Reply-To: <tencent_8FA596830F4F89E9E2169503B40DF0FF0307@qq.com>
 (583493798@qq.com's message of "Thu, 25 Mar 2021 19:11:30 +0800")
Message-ID: <f7ta6qr2xdt.fsf@dhcp-25.97.bos.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
 auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
Subject: Re: [dpdk-dev] [PATCH v2] ip_frag: fix fragmenting ipv4 packet with
 header option
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

583493798@qq.com writes:

> From: Pu Xu <583493798@qq.com>
>
> When fragmenting ipv4 packet, the data offset should be calculated through
> the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr).
>
> Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper library")
>
> Signed-off-by: Pu Xu <583493798@qq.com>
> ---

Thanks for this patch, it looks okay.

Can you please add a test case to app/test/test_ipfrag.c so that we can
catch any breakage in this area in the future?