From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 14652A0096 for ; Tue, 4 Jun 2019 15:26:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 172D61BC1F; Tue, 4 Jun 2019 15:26:52 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 197031BB83 for ; Tue, 4 Jun 2019 15:26:51 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5795380094; Tue, 4 Jun 2019 13:26:45 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5D75B5B686; Tue, 4 Jun 2019 13:26:40 +0000 (UTC) From: Aaron Conole To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, msantana@redhat.com References: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> <1559638792-8608-12-git-send-email-david.marchand@redhat.com> Date: Tue, 04 Jun 2019 09:26:39 -0400 In-Reply-To: <1559638792-8608-12-git-send-email-david.marchand@redhat.com> (David Marchand's message of "Tue, 4 Jun 2019 10:59:49 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 04 Jun 2019 13:26:50 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 11/14] test/eal: check number of cores before running subtests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" David Marchand writes: > From: Michael Santana > > The eal flags unit test assumes that a certain number of cores are > available (4 and 8 cores), however this may not always be the case. > Individual developers may run the unit test on their local desktop > which typically have 2 to 4 cores, in said case the test is bound > to fail for lacking 4 or 8 cores. > > Additionally, as we push forward introducing CI into DPDK we are limited > to the hardware specification of CI services (e.g. Travis CI) that only > have 2 cores on their servers, in which case the test would fail. > > To fix this we check available cores before running a subtest. This > applies to subtests that are dedicated to test that the -l and --lcore > flags work correctly. If not enough cores are available the subtest is > simply skipped, otherwise the subtest is run. > > Signed-off-by: Michael Santana > Signed-off-by: David Marchand > --- Acked-by: Aaron Conole