From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98A0E42588; Wed, 13 Sep 2023 13:13:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20081402CF; Wed, 13 Sep 2023 13:13:12 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 375E140293 for ; Wed, 13 Sep 2023 13:13:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694603589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QzDdnMhWX6+2iuxb23UkhvtrkH9sMw4XyjJ/mDIIPy4=; b=Pf9wUHEJS14k2HQ8PlnV44DJ2OGEZpgrrvnpZx7HyXtFTqdsH2qlReYNgrrDZAe2qxjQzP gJfMNZaVBg8eJae5ZpUlK56asKyg/HHXHDXTXimJSHwUwZLH7WOQ8GVCFMKn8MT5g/FxMU mPrVT4JrshLmKhNCrr2dwmrm7Vmayi4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-502--TEMc_1cOyOPGRkwW2j3iw-1; Wed, 13 Sep 2023 07:13:04 -0400 X-MC-Unique: -TEMc_1cOyOPGRkwW2j3iw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C7E27185A78E; Wed, 13 Sep 2023 11:13:03 +0000 (UTC) Received: from RHTPC1VM0NT (unknown [10.22.16.175]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FA2C2026D4B; Wed, 13 Sep 2023 11:13:03 +0000 (UTC) From: Aaron Conole To: John Romein Cc: dev@dpdk.org, Elena Agostini Subject: Re: [PATCH] gpu/cuda: Add missing stdlib include In-Reply-To: <8e6f8751-9475-cce5-b827-646f772f64a6@astron.nl> (John Romein's message of "Tue, 12 Sep 2023 19:08:43 +0200") References: <8e6f8751-9475-cce5-b827-646f772f64a6@astron.nl> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Date: Wed, 13 Sep 2023 07:12:56 -0400 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org John Romein writes: > getenv needs stdlib.h to be included. > > Bugzilla ID: 1133 > > Fixes: 24c77594e08f ("gpu/cuda: map GPU memory with GDRCopy") > Signed-off-by: John Romein > --- Hi John, Thanks so much for the contribution. It looks like the patch got corrupted by something. Please check your mail client settings. I'll point out some of the specific characters here. You may also need to switch to using a gmail server or some other mail service to email the patch. -Aaron > =C2=A0drivers/gpu/cuda/gdrcopy.c | 2 ++ > =C2=A01 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/cuda/gdrcopy.c b/drivers/gpu/cuda/gdrcopy.c > index 322a5dbeb2..f19ad396f1 100644 > --- a/drivers/gpu/cuda/gdrcopy.c > +++ b/drivers/gpu/cuda/gdrcopy.c > @@ -2,6 +2,8 @@ > =C2=A0 * Copyright (c) 2022 NVIDIA Corporation & Affiliates ^ This character looks incorrect > =C2=A0 */ ^ Same here =20 > > +#include > + > =C2=A0#include "common.h" ^ Same here > =C2=A0#ifdef DRIVERS_GPU_CUDA_GDRCOPY_H ^ Same here