From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 359BEA00C5; Mon, 6 Jul 2020 20:02:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CADB61DADA; Mon, 6 Jul 2020 20:02:47 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 68E2F1DAD6 for ; Mon, 6 Jul 2020 20:02:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594058565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HmUoT+APEz8i4X3b9uA2gtz3d1K8bKSv+fIIVxUJX5k=; b=Ww47p7aI6ZNAEaBy8R5qaGJIFF8dg+z3cd1KQ1wVH6BVzCqhFR3v+Z6UmV44zxmasOclrz tnRiwu4jG51tJwipcgu8gRQH8K6dYwX4HDCTSIx1VlEapuHZqR7u2iQqE5MKkdTK5YvLsf JrT49lzhHaAeKIGwbtFqHAxq5+Fs8O0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-49-UFYxgxKDNQ2GFlzulwEevA-1; Mon, 06 Jul 2020 14:02:31 -0400 X-MC-Unique: UFYxgxKDNQ2GFlzulwEevA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C5433108BC2F; Mon, 6 Jul 2020 18:02:29 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-114-181.rdu2.redhat.com [10.10.114.181]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C031278129; Mon, 6 Jul 2020 18:02:28 +0000 (UTC) From: Aaron Conole To: Thomas Monjalon Cc: Ferruh Yigit , John McNamara , Marko Kovacevic , dev@dpdk.org, ci@dpdk.org References: <20200701113528.303605-1-ferruh.yigit@intel.com> <20200703095348.232927-1-ferruh.yigit@intel.com> <2764957.7Ma0oT34CT@thomas> Date: Mon, 06 Jul 2020 14:02:27 -0400 In-Reply-To: <2764957.7Ma0oT34CT@thomas> (Thomas Monjalon's message of "Mon, 06 Jul 2020 17:12:18 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=aconole@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [dpdk-dev] [dpdk-ci] [PATCH v2] doc: add dependency syntax to contributing guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thomas Monjalon writes: > 06/07/2020 17:09, Aaron Conole: >> Ferruh Yigit writes: >> >> > To help managing patch dependencies, both for maintainers or automation >> > tasks, document a syntax for commit logs or cover letters to express >> > their dependencies. >> > >> > Using the syntax proposed in Bugzilla ID 210: >> > [https://bugs.dpdk.org/show_bug.cgi?id=210] >> > >> > "Depends-on: series-NNNNN ("Title of the series")' >> > OR >> > 'Depends-on: patch-NNNNN ("Title of the patch")' >> > >> > Signed-off-by: Ferruh Yigit >> > --- >> >> Is the plan that these must be scrubbed before committing? >> >> This data doesn't seem useful in the history. I would prefer it in the >> subject like >> >> [PATCH series-xxxx] lorem ipsum >> >> Since the metadata gets scrubbed. > > Look below: > >> > + Signed-off-by: Alex Smith >> > + --- >> > + Depends-on: series-10000 ("Title of the series") > > Added after line --- > so it won't be kept in the git history. Ahh, I missed it for some reason.