From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F370BA0588; Thu, 16 Apr 2020 14:46:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D49FE1DC67; Thu, 16 Apr 2020 14:46:02 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id AFD6D1DC54 for ; Thu, 16 Apr 2020 14:46:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587041160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4BwgnnzCSxAGRn9c1YPO58EbrpuvXZdzbKVB5GWSA3U=; b=Kyy2ecRb86EjURifAiVF0KOW7CVaqC4yHnR++jIpj/Rpo1UOBw4IoFCW95unamU4pkXj3U 0UiP9e/l7fKQwwnBYS5yFimS6MPKZeAJrpVU7ku81fEUrPUxAv0xcbpJWExPh04vtJ/b+B utQwdx9mBNvBMnqOarlgcbSYX/caCeY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-302-QQUzUZanNf-SqG2yU6vXGw-1; Thu, 16 Apr 2020 08:45:57 -0400 X-MC-Unique: QQUzUZanNf-SqG2yU6vXGw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E06C9149DB; Thu, 16 Apr 2020 12:45:55 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (ovpn-116-136.phx2.redhat.com [10.3.116.136]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 03E347E7D6; Thu, 16 Apr 2020 12:45:50 +0000 (UTC) From: Aaron Conole To: Pavan Nikhilesh Bhagavatula Cc: "dev\@dpdk.org" , Konstantin Ananyev , Bruce Richardson , David Marchand , Ferruh Yigit , Anatoly Burakov References: Date: Thu, 16 Apr 2020 08:45:49 -0400 In-Reply-To: (Pavan Nikhilesh Bhagavatula's message of "Wed, 15 Apr 2020 18:58:58 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v4 3/3] ipfrag: add unit test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Pavan Nikhilesh Bhagavatula writes: >>Initial IP fragmentation unit test. >> >>Signed-off-by: Aaron Conole >>--- >> MAINTAINERS | 1 + >> app/test/meson.build | 2 + >> app/test/test_ipfrag.c | 276 >>+++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 279 insertions(+) >> create mode 100644 app/test/test_ipfrag.c >> >>diff --git a/MAINTAINERS b/MAINTAINERS >>index fe59f0224f..a77c7c17ce 100644 >>--- a/MAINTAINERS >>+++ b/MAINTAINERS >>@@ -1228,6 +1228,7 @@ F: app/test/test_crc.c >> IP fragmentation & reassembly >> M: Konstantin Ananyev >> F: lib/librte_ip_frag/ >>+F: app/test/test_ipfrag.c >> F: doc/guides/prog_guide/ip_fragment_reassembly_lib.rst >> F: examples/ip_fragmentation/ >> F: doc/guides/sample_app_ug/ip_frag.rst >>diff --git a/app/test/meson.build b/app/test/meson.build >>index 04b59cffa4..4b3c3852a2 100644 >>--- a/app/test/meson.build >>+++ b/app/test/meson.build >>@@ -58,6 +58,7 @@ test_sources =3D files('commands.c', >> =09'test_hash_perf.c', >> =09'test_hash_readwrite_lf_perf.c', >> =09'test_interrupts.c', >>+ 'test_ipfrag.c', >> =09'test_ipsec.c', >> =09'test_ipsec_sad.c', >> =09'test_kni.c', >>@@ -187,6 +188,7 @@ fast_tests =3D [ >> ['flow_classify_autotest', false], >> ['hash_autotest', true], >> ['interrupt_autotest', true], >>+ ['ipfrag_autotest', false], >> ['logs_autotest', true], >> ['lpm_autotest', true], >> ['lpm6_autotest', true], >>diff --git a/app/test/test_ipfrag.c b/app/test/test_ipfrag.c >>new file mode 100644 >>index 0000000000..6a13e334d5 >>--- /dev/null >>+++ b/app/test/test_ipfrag.c >>@@ -0,0 +1,276 @@ >>+/* SPDX-License-Identifier: BSD-3-Clause >>+ * Copyright(c) 2020 Red Hat, Inc. >>+ */ >>+ >>+#include >>+ >>+#include >>+#include >>+#include >>+#include >>+#include >>+#include >>+#include >>+#include >>+ >>+#include "test.h" >>+ >>+#ifndef ARRAY_SIZE >>+#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) >>+#endif > > Please use RTE_DIM recently we had a major cleanup of ARRAY_SIZE across D= PDK. Done. > Thanks,=20 > Pavan. > >>+ >>+static struct rte_mempool *pkt_pool, >>+=09=09=09 *direct_pool, >>+=09=09=09 *indirect_pool; >>+