From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A322DA2EEB for ; Fri, 13 Sep 2019 16:41:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8FAEA1F08E; Fri, 13 Sep 2019 16:40:52 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 513A31F07E for ; Fri, 13 Sep 2019 16:40:51 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B47C63064FD1; Fri, 13 Sep 2019 14:40:50 +0000 (UTC) Received: from dhcp-25.97.bos.redhat.com (unknown [10.18.25.226]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ECAC81001B02; Fri, 13 Sep 2019 14:40:49 +0000 (UTC) From: Aaron Conole To: Cc: Yipeng Wang , Sameh Gobriel , Bruce Richardson , Pablo de Lara , , Honnappa Nagarahalli References: <1567748973-24192-3-git-send-email-agupta3@marvell.com> <1568362357-18061-1-git-send-email-agupta3@marvell.com> Date: Fri, 13 Sep 2019 10:40:49 -0400 In-Reply-To: <1568362357-18061-1-git-send-email-agupta3@marvell.com> (agupta3@marvell.com's message of "Fri, 13 Sep 2019 13:42:36 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Fri, 13 Sep 2019 14:40:50 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" writes: > From: Amit Gupta > > hash_readwrite_lf test always getting TIMEOUT as required > time to finish this test was much longer compare to time > required for fast tests(10s). Hence, the test is being renamed > moved to perf test category for its execution to complete. > > Signed-off-by: Amit Gupta > --- Okay. I'll note that we pass the '-t 3' flag, so it is actually timing out with 30s instead of the default 10. We do this because occasionally the lpm6 and table tests would also exceed the 10s timeout in the travis environment. I agree, it's better to pull the perf part of tests out. I think there isn't any additional functional test in this readwrite - is that so? If it is, then we need to also prioritize adding back in some of the functional testing. Maybe I misread the lf_autotest, though. > app/test/meson.build | 2 +- > app/test/test_hash_readwrite_lf.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/app/test/meson.build b/app/test/meson.build > index 94fd9f8..57d5316 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -220,7 +220,6 @@ fast_test_names = [ > 'eventdev_common_autotest', > 'fbarray_autotest', > 'hash_readwrite_func_autotest', > - 'hash_readwrite_lf_autotest', > 'ipsec_autotest', > 'kni_autotest', > 'kvargs_autotest', > @@ -263,6 +262,7 @@ perf_test_names = [ > 'stack_lf_perf_autotest', > 'rand_perf_autotest', > 'hash_readwrite_perf_autotest', > + 'hash_readwrite_lf_perf_autotest', > ] > > driver_test_names = [ > diff --git a/app/test/test_hash_readwrite_lf.c b/app/test/test_hash_readwrite_lf.c > index 1f2fba4..33d63fa 100644 > --- a/app/test/test_hash_readwrite_lf.c > +++ b/app/test/test_hash_readwrite_lf.c > @@ -1431,4 +1431,5 @@ struct { > return 0; > } > > -REGISTER_TEST_COMMAND(hash_readwrite_lf_autotest, test_hash_readwrite_lf_main); > +REGISTER_TEST_COMMAND(hash_readwrite_lf_perf_autotest, > + test_hash_readwrite_lf_main);