From: Aaron Conole <aconole@redhat.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: dev <dev@dpdk.org>, Kevin Laatz <kevin.laatz@intel.com>,
Luca Boccassi <bluca@debian.org>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] build: avoid --as-needed as it causes overlinking
Date: Wed, 28 Aug 2019 09:53:04 -0400 [thread overview]
Message-ID: <f7td0gppfb3.fsf@dhcp-25.97.bos.redhat.com> (raw)
In-Reply-To: <20190828122752.27887-1-christian.ehrhardt@canonical.com> (Christian Ehrhardt's message of "Wed, 28 Aug 2019 14:27:52 +0200")
Christian Ehrhardt <christian.ehrhardt@canonical.com> writes:
> A while ago telemetry was added in 57ae0ec6 and it also added as-needed
> to config/meson.build. This seems no more needed these days as due to other
> build changes the ordering in buildlogs is:
> [...] -lrte_telemetry [...] -Wl,--no-as-needed [...]
> Which means telemetry no more benefits from --no-as-needed anyway.
>
> Overlinking problems get triggered by the meson generated pkgconfig which
> will have:
> [...] -Wl,--no-as-needed <somelibsusedbydpdk>
> This will overlink <somelibs> and in addition anything that follows
> as it also doesn't wrap back to --as-needed. So if a projects includes
> dpdk libs + <other> it will also consider <other> with --no-as-needed.
>
> Fixes: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759
>
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
Hi Christian,
I agree this is something to be fixed. It will need additional work,
though:
https://travis-ci.com/ovsrobot/dpdk/builds/124909245
The unit tests are failing with this patch.
> config/meson.build | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/config/meson.build b/config/meson.build
> index 2bafea530..58800a980 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -93,9 +93,6 @@ dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper(), 1)
>
> dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') == 8)
>
> -add_project_link_arguments('-Wl,--no-as-needed', language: 'c')
> -dpdk_extra_ldflags += '-Wl,--no-as-needed'
> -
> # use pthreads
> add_project_link_arguments('-pthread', language: 'c')
> dpdk_extra_ldflags += '-pthread'
next prev parent reply other threads:[~2019-08-28 13:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 12:27 Christian Ehrhardt
2019-08-28 13:49 ` Luca Boccassi
2019-08-28 13:53 ` Aaron Conole [this message]
2019-08-28 14:48 ` Christian Ehrhardt
2019-08-28 15:14 ` Aaron Conole
2019-08-28 15:23 ` Aaron Conole
2019-08-29 10:18 ` Christian Ehrhardt
2019-08-29 15:25 ` Christian Ehrhardt
2019-08-29 15:30 ` [dpdk-dev] [PATCH v2] " Christian Ehrhardt
2019-08-29 15:34 ` Bruce Richardson
2019-08-29 16:02 ` Luca Boccassi
2019-09-02 7:09 ` Christian Ehrhardt
2019-09-04 9:13 ` Christian Ehrhardt
2019-09-04 9:18 ` Bruce Richardson
2019-09-10 6:48 ` Christian Ehrhardt
2019-09-12 13:43 ` Christian Ehrhardt
2019-10-12 13:02 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7td0gppfb3.fsf@dhcp-25.97.bos.redhat.com \
--to=aconole@redhat.com \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).